Skip to content

Comments

Spawn emulator per test#44

Merged
notmandatory merged 4 commits intomasterfrom
spawn_emulator_per_test
Aug 13, 2025
Merged

Spawn emulator per test#44
notmandatory merged 4 commits intomasterfrom
spawn_emulator_per_test

Conversation

@notmandatory
Copy link
Member

@notmandatory notmandatory commented Aug 13, 2025

Description

  • Added coinkite/coinkite-tap-protocol git submodule
  • Added Justfile to setup the Python venv for coinkite-tap-protocol card emulator
  • Added emulator::EcardSubprocess to spawn a thread with a card emulator for each test on a unique unix pipe
  • Updated tests to use the EcardSubprocess
  • Added new sats_chip module and SatsChip struct
  • Added new TapSignerShared trait for functions shared between TapSigner and SatsChip
  • Fixed test_new_command test to verify it recognizes the difference between TapSigner and SatsChip
  • Updated CI to separate building from testing and to use the emulator for tests.
  • Add new test for the check_certificate command

Notes to the reviewers

You can use the recipe just test-lib to setup the emulator python venv and run the tests.

Changelog notice

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@notmandatory notmandatory self-assigned this Aug 13, 2025
@notmandatory notmandatory force-pushed the spawn_emulator_per_test branch 2 times, most recently from 3aab2fc to c77bace Compare August 13, 2025 03:19
@notmandatory notmandatory added bug Something isn't working chore labels Aug 13, 2025
@notmandatory notmandatory force-pushed the spawn_emulator_per_test branch 2 times, most recently from 0d2fcd2 to 6cfefd1 Compare August 13, 2025 05:07
@notmandatory notmandatory force-pushed the spawn_emulator_per_test branch from 6cfefd1 to 15592e2 Compare August 13, 2025 05:17
@notmandatory notmandatory merged commit 15592e2 into master Aug 13, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant