Conversation
3aab2fc to
c77bace
Compare
0d2fcd2 to
6cfefd1
Compare
6cfefd1 to
15592e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Justfileto setup the Python venv for coinkite-tap-protocol card emulatoremulator::EcardSubprocessto spawn a thread with a card emulator for each test on a unique unix pipeEcardSubprocesssats_chipmodule andSatsChipstructTapSignerSharedtrait for functions shared betweenTapSignerandSatsChiptest_new_commandtest to verify it recognizes the difference betweenTapSignerandSatsChipcheck_certificatecommandNotes to the reviewers
You can use the recipe
just test-libto setup the emulator python venv and run the tests.Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: