feat: satscard status#35
Merged
notmandatory merged 2 commits intobitcoindevkit:masterfrom May 15, 2025
Merged
Conversation
notmandatory
added a commit
that referenced
this pull request
May 15, 2025
2a67970 fix: swift script unique subdir (Matthew) Pull request description: <!-- You can erase any parts of this template not applicable to your Pull Request. --> ### Description Builds on #34 architecture, and #35 Satscard status command. Before this fix, a user might get this error when trying to use 2 swift frameworks created like we do on bdk-ffi bindings. bitcoindevkit/bdk-ffi#621 Example: would prevent a user from using both bdk-swift and cktap-swift in their iOS app potentially. ### Notes to the reviewers <!-- In this section you can include notes directed to the reviewers, like explaining why some parts of the PR were done in a specific way --> ### Changelog notice <!-- Notice the release manager should include in the release tag message changelog --> <!-- See https://keepachangelog.com/en/1.0.0/ for examples --> ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/notmandatory/rust-cktap/blob/master/CONTRIBUTING.md) * [ ] I ran `cargo fmt` and `cargo clippy` before committing #### New Features: * [ ] I've added tests for the new feature * [ ] I've added docs for the new feature #### Bugfixes: * [ ] This pull request breaks the existing API * [ ] I've added tests to reproduce the issue which are now passing * [ ] I'm linking the issue being fixed by this PR ACKs for top commit: notmandatory: ACK 2a67970 Tree-SHA512: 9dce93e3e803c18a5fd7b20f5cbe9b8b5b22715c46a7f01bd11a78407bba65c57bb8483431ed4a9ce1c72992b8d1e42685128963a2443913d4e61139c46eb9cb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Builds on #34 architecture, adds Satscard
statuscommand.Notes to the reviewers
Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: