README Update: set completion of response verifaciton for read and derive commands#26
Conversation
|
@notmandatory @reez |
I can't seems to edit the list of reviewers either so thanks for the ping to take a look at this PR! |
|
UTACK 64d16fd |
|
@upjohnc please rebase on master to fix the CI issue and then I'll get this one merged. |
commands is complete
4bd957a to
9acb78d
Compare
|
I had to redo your rebase, somehow your commit ended up in front of all the recent commits on master. I'll show ya how I fixed next time I see you in the office. |
Alright. I rebased and pushed. The good part is github actions is succeeding. The thing is that it shows all the commits that are new (added from rebase). I don't usually rebase, so need help with what I need to correct with all those commits showing in the git diff. |
Description
This is an update to the README to show that the response
verification has been added to the code for the read and derive
commands.
Notes to the reviewers
The verification for the two commands seem to be done in these
two code references
Read Trait:
https://github.com/notmandatory/rust-cktap/blob/d8258229ff080ce5adaeff65898bcc3846faa6d1/lib/src/commands.rs#L109
Derive:
https://github.com/notmandatory/rust-cktap/blob/d8258229ff080ce5adaeff65898bcc3846faa6d1/lib/src/lib.rs#L281
https://github.com/notmandatory/rust-cktap/blob/d8258229ff080ce5adaeff65898bcc3846faa6d1/lib/src/lib.rs#L132