Read response verification#15
Merged
notmandatory merged 2 commits intobitcoindevkit:masterfrom Jun 9, 2023
Merged
Conversation
notmandatory
approved these changes
Jun 8, 2023
Member
notmandatory
left a comment
There was a problem hiding this comment.
ACK bc7889b
I tested and confirmed read response verification works for each card type. I also did a little side test and was able to convert the read response pubkey to a wpkh bitcoin address that matched what the SatsCard status addr field said to expect.
Member
|
I'm going to open an issue to discuss what sort of commands we should have for the cli vs the lib so we can decide which logic goes where. |
Member
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Validate the signature of the ReadResponse against the signature as described in #6. For Satscard, public key is for active slot. For Tapsigner, the "pubkey" provided in the response must be unzipped (XORed) to get the public key for the current derivation path.
Notes to the reviewers
calc_ekeys_xcvcinterface, the session_key is being recalculated outside.unzipfunction that might be better off as a trait implement by a Vec pubkey, so there may be a follow up commit time-permitting.debugcommand to the cli for developer convenience, but can remove if neededChecklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features: