Refactor: Commands as traits + new Card construction#12
Merged
notmandatory merged 1 commit intobitcoindevkit:masterfrom Jun 2, 2023
Merged
Refactor: Commands as traits + new Card construction#12notmandatory merged 1 commit intobitcoindevkit:masterfrom
notmandatory merged 1 commit intobitcoindevkit:masterfrom
Conversation
as_cktap on transport trait + impl Transport for Card Fix formatting Fix clippy warnings
notmandatory
approved these changes
Jun 2, 2023
Member
notmandatory
left a comment
notmandatory
left a comment
There was a problem hiding this comment.
ACK 04c94d4
Another good refactor, the layering of apdu messages and new commands traits makes sense. I also like how you simplified the apdu file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Notes to the reviewers
Just read the CONTRIBUTING.md. I'll be more mindful of it moving forward, but hopefully it's not too much of an issue this time around.
Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing