Conversation
| chain_code, | ||
| epubkey, | ||
| xcvc, | ||
| pub fn read(&mut self) -> Result<ReadResponse, Error> { |
There was a problem hiding this comment.
Thoughts on using different constructors to build the request objects. Example here:
pub fn read(&mut self) -> Result<ReadResponse, Error> {
let read_cmd = ReadCommand::for_satscard(self.card_nonce.clone());
let read_response = self.transport.transmit_read(read_cmd);
if let Ok(read_response) = &response {
self.card_nonce = read_response.card_nonce.clone();
}
response
}
```
f783e89 to
f23a698
Compare
|
Hey sorry for all the refactoring on top of your changes. But the process has been really helpful in finding a cleaner design. In the latest commit I added If this looks OK to you then I'll merge it. Adding the rest of the commands can go in new PRs. Besides the remaining commands the other near-term TODOs I see are:
|
brh28
left a comment
There was a problem hiding this comment.
LGTM. Gives some structure which should make development easier
Async Transport add `change` and `backup`
No description provided.