release/3.x: Deprecate wallet-owned signing APIs (backport of #505) - #536
Open
noahjoeris wants to merge 3 commits into
Open
release/3.x: Deprecate wallet-owned signing APIs (backport of #505)#536noahjoeris wants to merge 3 commits into
noahjoeris wants to merge 3 commits into
Conversation
Prefer bitcoin::Psbt::sign or Wallet::sign_with_signers in docs, examples, and tests instead of relying on wallet-owned signer state. Keep FullyNoded exports public-only and independent of wallet-owned signer state.
Add TxBuilder::set_condition and wire create_tx to prefer an explicit Condition, falling back to policy-path derivation. Export Condition / Condition::merge. Migrate the compiler example off Wallet::policies.
Mark Wallet::sign, signer/keymap accessors, keymap load/create helpers, Wallet::policies, and TxBuilder::policy_path as deprecated. Replacement: keep KeyMaps/Xprivs outside Wallet; bitcoin::Psbt::sign or Wallet::sign_with_signers; extract_policy + Policy::get_condition + TxBuilder::set_condition for spending paths.
noahjoeris
requested review from
ValuedMammal and
oleonardolima
as code owners
August 21, 2026 09:48
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/3.x #536 +/- ##
===============================================
+ Coverage 81.77% 81.85% +0.07%
===============================================
Files 25 25
Lines 6487 6535 +48
Branches 296 302 +6
===============================================
+ Hits 5305 5349 +44
+ Misses 1080 1077 -3
- Partials 102 109 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
I replicated the cherry-pick on a temporary branch based on release/3.x, diff'd it against this branch and it came up clean. I ran ACK e6aa73d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backports #505 to
release/3.x. Deprecates wallet-owned signing APIs in favor of caller-owned keys (bitcoin::Psbt::sign,Wallet::sign_with_signers).