Skip to content

deprecate network, descriptor and change_descriptor fields#394

Open
110CodingP wants to merge 1 commit intobitcoindevkit:masterfrom
110CodingP:deprecate_fields
Open

deprecate network, descriptor and change_descriptor fields#394
110CodingP wants to merge 1 commit intobitcoindevkit:masterfrom
110CodingP:deprecate_fields

Conversation

@110CodingP
Copy link
Contributor

Description

These fields are planned to be replaced by keyring field when we have the multi-keychain wallet so need to be deprecated following the policy in #391 .

Changelog notice

  • Deprecated network, descriptor and change_descriptor fields of wallet::ChangeSet .

Checklists

All Submissions:

Since these fields(`network`, `descriptor`, `change_descriptor`) will be
replaced by `keyring` when we have the multi-keychain wallet.
@codecov
Copy link

codecov bot commented Mar 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.17%. Comparing base (c422104) to head (a8430c2).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #394   +/-   ##
=======================================
  Coverage   79.17%   79.17%           
=======================================
  Files          24       24           
  Lines        5311     5311           
  Branches      242      242           
=======================================
  Hits         4205     4205           
  Misses       1029     1029           
  Partials       77       77           
Flag Coverage Δ
rust 79.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@luisschwab luisschwab added the api A breaking API change label Mar 4, 2026
@luisschwab luisschwab moved this to Needs Review in BDK Wallet Mar 4, 2026
@luisschwab luisschwab added this to the Wallet 3.0.0 milestone Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api A breaking API change

Projects

Status: Needs Review

Development

Successfully merging this pull request may close these issues.

3 participants