refactor(wallet)!: Remove Wallet::cancel_tx function#393
Merged
ValuedMammal merged 1 commit intobitcoindevkit:masterfrom Mar 4, 2026
Merged
Conversation
Removed because its name is misleading and mark_unused can be used to accomplish the same function.
8c0a9c4 to
1854b8e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #393 +/- ##
==========================================
- Coverage 79.17% 79.08% -0.10%
==========================================
Files 24 24
Lines 5311 5302 -9
Branches 242 241 -1
==========================================
- Hits 4205 4193 -12
- Misses 1029 1032 +3
Partials 77 77
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6 tasks
Wallet::cancel_tx function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Per discussion in team chat today I'm removing the
Wallet::cancel_txfunction because it's name is misleading and theWallet::mark_unusedfunction can be used to accomplish the same function.closes #326 and closes #212 and closes #41
Notes to the reviewers
This is an example of how to use
mark_unusedinstead ofcancel_txChangelog notice
Checklists
All Submissions:
just pbefore pushingBugfixes: