feat: Return feerate from transaction builder#380
feat: Return feerate from transaction builder#380gyanranjanpanda wants to merge 2 commits intobitcoindevkit:masterfrom
Conversation
Implements issue bitcoindevkit#187 by introducing BuilderResult struct that wraps both the PSBT and the FeeRate used during transaction construction. Changes: - Add BuilderResult struct with psbt and fee_rate fields - Update finish() and finish_with_aux_rand() to return BuilderResult - Modify create_tx() to capture and return the feerate - Update tests and examples to use new API (WIP) The core implementation is complete. Some test files still need manual updates to properly access the .psbt field from BuilderResult. Fixes bitcoindevkit#187 Signed-off-by: Gyan Ranjan Panda <gyanranjanpanda@gmail.com>
|
@gyanranjanpanda are you planning to fix the compile errors on this PR? if so please change it to Draft status until you're done. If not we'll close it. |
|
Thanks for the feedback — I’ll fix the compile errors and update the PR shortly. |
725510d to
9deb2d5
Compare
|
hi @notmandatory , could u review this wating for your feedback |
|
Just want to point out that the In terms of this issue, the |
|
Ah got it thanks for pointing that out. I see what you mean. |
Implements functionality to return feerate from transaction builder finish() methods.
Fixes #187.
Changes:
This allows callers to know the exact feerate used for the constructed transaction, which is useful for fee estimation and user display.