Fix KeychainTxOutIndex recovery logic when spk-cache is enabled
#288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should ensure we populate the cache (from the changeset) before doing any other operation on `KeychainTxOutIndex` (i.e. inserting descriptors). Otherwise we will end up deriving spks which have already been cached. The test is also corrected to check that we don't duplicate deriving spks. A helper function `check_cache_cs` is added to make the tests more thorough and easier to read.
evanlinjin
requested review from
ValuedMammal and
notmandatory
and removed request for
ValuedMammal
ValuedMammal
reviewed
Aug 4, 2025
ValuedMammal
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We should ensure we populate the cache (from the changeset) before doing any other operation on
KeychainTxOutIndex(i.e. inserting descriptors).Otherwise we will end up re-deriving spks which have already been cached.
The test is also corrected to check that we don't duplicate deriving spks. A helper function
check_cache_csis added to make the tests more thorough and easier to read.Changelog notice
Fixed: * Recovering from spk-cache now works properly.Checklists
All Submissions:
just pbefore pushingBugfixes: