Skip to content

ci: automated update to rustc 1.87.0 #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 16, 2025
Merged

ci: automated update to rustc 1.87.0 #242

merged 2 commits into from
Jun 16, 2025

Conversation

@create-pr-actions
Copy link

@create-pr-actions create-pr-actions bot commented May 25, 2025

Automated update to Github CI workflow cont_integration.yml by create-pull-request GitHub action

@coveralls

This comment was marked as off-topic.

Sign in to view
@notmandatory notmandatory mentioned this pull request May 25, 2025
Closed
@notmandatory notmandatory self-assigned this May 25, 2025
@notmandatory notmandatory added the chore Non-coding related work label May 25, 2025
@notmandatory notmandatory moved this to In Progress in BDK Wallet May 25, 2025
@notmandatory notmandatory added this to the Wallet 2.0.0 milestone May 25, 2025
@notmandatory
Copy link
Member

notmandatory commented May 26, 2025 •
edited
Loading

The main clippy error I had to fix was: result_large_err

Because I had to change the error enums to box large types I believe this becomes an API breaking change. Should we loosen the allowed enum size and fix the result_large_error clippy errors in the 3.0 milestone or fix this now?

I also added a Justfile to help run cargo clippy and cargo test with and without the MSRV.

The required CI tasks will also need to be updated from 1.85.0 to 1.87.0 before any version of this PR can be merged.

@notmandatory notmandatory added the api A breaking API change label May 26, 2025
@notmandatory notmandatory force-pushed the create-pull-request/update-rust-version branch from 5dbf554 to a2377f3 Compare May 27, 2025 02:13
@notmandatory notmandatory mentioned this pull request May 27, 2025
Open
@notmandatory
Copy link
Member

notmandatory commented May 27, 2025

I updated the clippy.toml config to allow the larger enum and error types for now and created #245 for the larger fix.

@notmandatory notmandatory moved this from In Progress to Needs Review in BDK Wallet May 27, 2025
oleonardolima
oleonardolima reviewed May 27, 2025
View reviewed changes
Copy link
Contributor

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK a2377f3

oleonardolima
oleonardolima approved these changes May 28, 2025
View reviewed changes
Copy link
Contributor

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a2377f3

ValuedMammal
ValuedMammal approved these changes Jun 11, 2025
View reviewed changes
Copy link
Collaborator

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a2377f3

@create-pr-actions create-pr-actions bot force-pushed the create-pull-request/update-rust-version branch from a2377f3 to b8f331d Compare June 15, 2025 01:12
@ValuedMammal
Copy link
Collaborator

ValuedMammal commented Jun 16, 2025

We'll need an update again to change the clippy config if we want this to go in before doing the necessary API changes.

@ValuedMammal ValuedMammal self-assigned this Jun 16, 2025
@notmandatory notmandatory force-pushed the create-pull-request/update-rust-version branch from 197db7f to da3e42c Compare June 16, 2025 21:02
@notmandatory
ci(clippy): allow larger enum variant size and errors for rustc 1.87
1c1b1cd 
Set to current largest size enum and error sizes.
@notmandatory notmandatory force-pushed the create-pull-request/update-rust-version branch from da3e42c to 1c1b1cd Compare June 16, 2025 21:10
@notmandatory
Copy link
Member

notmandatory commented Jun 16, 2025

Updated clippy.toml again to be exactly the max required to pass clippy tests for current code.

@notmandatory notmandatory merged commit edbc127 into master Jun 16, 2025
39 checks passed
@github-project-automation github-project-automation bot moved this from Needs Review to Done in BDK Wallet Jun 16, 2025
@notmandatory notmandatory removed the api A breaking API change label Jun 16, 2025
@notmandatory
Copy link
Member

notmandatory commented Jun 16, 2025

I updated the master branch protection rules to require tests for rust 1.87, all open PRs will need to be rebased.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@notmandatory notmandatory notmandatory left review comments

@oleonardolima oleonardolima oleonardolima approved these changes

@ValuedMammal ValuedMammal ValuedMammal approved these changes

Assignees

@notmandatory notmandatory

@ValuedMammal ValuedMammal

Labels

chore Non-coding related work

Projects

BDK Wallet
Archived in project

Milestone

Wallet 2.1.0

Development

Successfully merging this pull request may close these issues.

5 participants

@coveralls @notmandatory @ValuedMammal @oleonardolima