fix(wallet): fix into_descriptor_key for DescriptorPublicKey
#241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
..by including the missing match arm for `DescriptorPublicKey::MultiXPub` when initializing `networks`. Test that `into_wallet_descriptor` correctly parses a multipath descriptor and fails if passed a network that is invalid for the descriptor. Note that rust-miniscript doesn't support parsing a multipath descriptor containing extended private keys.
Collaborator
Author
|
I reopened this from the original PR bitcoindevkit/bdk#1902. |
Pull Request Test Coverage Report for Build 15238566419Details
💛 - Coveralls |
oleonardolima
approved these changes
May 28, 2025
Contributor
oleonardolima
left a comment
oleonardolima
left a comment
There was a problem hiding this comment.
ACK 469cfd0
I'd just make sure to word that this fix only parsing in the release notes, in order to not mislead users into thinking that bdk_wallet works with multipath descriptors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
into_descriptor_keyforDescriptorPublicKeyby including the missing match arm forDescriptorPublicKey::MultiXPubwhen initializingnetworks.Test that
into_wallet_descriptorcorrectly parses a multipath descriptor and fails if passed a network that is invalid for the descriptor.Note that rust-miniscript doesn't support parsing a multipath descriptor containing extended private keys.
fixes #10
Checklists
All Submissions:
cargo +nightly fmtandcargo clippybefore committingNew Features:
Bugfixes: