Clean up dependency structure

[ValuedMammal]

Can we switch the file store and testenv crates to depend on bdk_core now instead of bdk_chain to help organize and reduce complexity of the overall dependency graph?

[oleonardolima]

I think it'll be hard to do it, as we'll mostly already depend on bdk_testenv which already depends on bdk_chain (just wondering about it for now 🤔)

[evanlinjin]

@ValuedMammal how would this result in cyclic dependencies? One can't depend on a crate's tests?

[notmandatory]

I suggested this issue since it seems weird that bdk_core has even a test dependency on bdk_chain. It looks like the only reason for the dependency is that the bdk_core doc examples depend on bdk_chain. Is there any reason not to re-write the doc examples or move them to the chain crate?

[oleonardolima]

I suggested this issue since it seems weird that bdk_core has even a test dependency on bdk_chain. It looks like the only reason for the dependency is that the bdk_core doc examples depend on bdk_chain. Is there any reason not to re-write the doc examples or move them to the chain crate?

The test usage in block_id! is being moved to bdk_testenv at bitcoindevkit/bdk#1612, so it won't be an issue anymore. Also, it's weird it depends on bdk_chain::BlockId instead of crate::BlockId 🤔.

I think it's fine to either rewrite the doc examples or move to bdk_chain.

[ValuedMammal]

I'll repurpose this issue into a general discussion of what the structure of the repo's inter-crate dependencies should look like.

[ValuedMammal]

I also noticed that bdk_esplora's "std" feature still enables bdk_chain/std even though the idea of bitcoindevkit/bdk#1155 was to drop the dependency on bdk_chain from the chain source crates.

https://github.com/bitcoindevkit/bdk/blob/2cf46a2a9e513d3f2612b7c363446fb1acf958ae/crates/esplora/Cargo.toml#L29-L31

[notmandatory]

Should we also bump major versions from 0.x to 1.x for bdk crates:
bdk_core
bdk_chain
bdk_electrum
bdk_esplora

I'm not sure these are ready to be 1.x and can stay as 0.x:
bdk_bitcoind_rpc
bdk_file_store
bdk_testenv

[ValuedMammal]

bitcoindevkit/bdk@master...ValuedMammal:bdk:build/try-decouple-chain

This was a recent attempt to use version dependencies for chain and file_store

[ValuedMammal]

Fixed by #2