Verify network consistency between chain genesis and descriptors

[notmandatory]

"Consistency between descriptor network and chain genesis hash isn't checked in load_with_params nor in create_with_params."

[oleonardolima]

I'll give this one a try.

[oleonardolima]

Am I missing something or it's actually being verified?

At least as of initial research on create_with_params, it initially uses the Network from CreateParams, gets the genesis_hash, and then uses it on DescriptorToExtract and into_wallet_descriptor.

Later on into_wallet_descriptor implementation, it checks the given network with the parsed descriptor here.

I think I got what I was missing, it's indeed not checking the given genesis_hash in CreateParams with the given Network, when it's a None it'll default to the used one from Network, but the problem relies on the explicitly passed as parameter 🤔.

[oleonardolima]

I'll try to write a test to assert and make sure of the expected behavior.

[oleonardolima]

Alright, we'd probably need a new (e.g. NetworkMistach) error variant, but on DescriptorError, as we need to catch this on both wallet creation and loading. We do have a LoadMismatch::Network but it's only when loading from persisted, and checks the network field.

I'll center the further discussion on PR :)