Skip to content

Use T: AsRef<Path> as param to SqliteDatabase::new #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2022
Merged

Use T: AsRef<Path> as param to SqliteDatabase::new #675

merged 1 commit into from
Jul 30, 2022

Conversation

@vladimirfomene
Copy link
Contributor

@vladimirfomene vladimirfomene commented Jul 20, 2022

This PR fixes #674

Description

Currently SqliteDatabase::new takes a String as path,
with this change, it now accepts any type that implements
AsRef.

Notes to the reviewers

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature
  • I've updated CHANGELOG.md

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@vladimirfomene vladimirfomene force-pushed the change-database-path-type branch from 2a370aa to 4f04341 Compare July 20, 2022 16:33
@danielabrozzoni
Copy link
Member

danielabrozzoni commented Jul 27, 2022

Code review ACK 4f04341

afilini
afilini approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@afilini afilini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 4f04341

@afilini
Copy link
Member

afilini commented Jul 28, 2022

Can you rebase on the latest master to fix the conflicts?

@vladimirfomene
Use T: AsRef<Path> as param to SqliteDatabase::new
558e37a 
Currently SqliteDatabase::new takes a String as path,
with this change, it now accepts any type that implements
AsRef<Path>.
@vladimirfomene vladimirfomene force-pushed the change-database-path-type branch from 4f04341 to 558e37a Compare July 29, 2022 14:43
@vladimirfomene
Copy link
Contributor Author

vladimirfomene commented Jul 29, 2022

Done @afilini !

@danielabrozzoni
Copy link
Member

danielabrozzoni commented Jul 29, 2022

utACK 558e37a

@danielabrozzoni danielabrozzoni merged commit a147740 into bitcoindevkit:master Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afilini afilini afilini approved these changes

Assignees

@vladimirfomene vladimirfomene

Labels

None yet

Projects

None yet

Milestone

Release 0.21.0 Feature Freeze

Development

Successfully merging this pull request may close these issues.

SqliteDatabase::new should take a Path

3 participants

@vladimirfomene @danielabrozzoni @afilini