Bump MSRV to 1.56 #596
Merged
Bump MSRV to 1.56 #596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afilini
force-pushed
the
bump-msrv-1.56
branch
7 times, most recently
from
ee6df80 to
a4c4246
Compare
notmandatory
reviewed
May 3, 2022
notmandatory
approved these changes
May 4, 2022
Member
notmandatory
left a comment
notmandatory
left a comment
There was a problem hiding this comment.
ACK cca6948
I agree we need to update MSRV to support frequent changes in Blockchain (and Database) dependencies and once core bdk is in it's own crate we can work on supporting lower MSRVs there.
This was referenced May 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following the discussion in #331, bump the MSRV to
1.56. We already have other PRs bumping it to at least1.51(#593), but I'm felling like we are always lagging behind and our CI breaks regularly. As @LLFourn suggested, this PR makes a relatively large bump, hoping this buys us enough time to finish splitting up BDK, which will allow us to have a lower MSRV for the "core" crate.Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
CHANGELOG.md