Pin tokio version to ~1.14 #550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notmandatory
force-pushed
the
pin_tokio_114
branch
from
a250653 to
b04bb59
Compare
Member
Author
|
I think we can use this as a short term fix while we discuss #331 to determine what our MSRV should be. |
3 tasks
Collaborator
|
ACK b04bb59 I agree this is the right thing to do for now. |
LLFourn
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
tokioproject recently changed their MSRV to1.49.0. This PR will pin thetokiodependency version to~1.14which is prior to their MSRV increase.Notes to the reviewers
The LDK team took this approach for their
tokiodev-dependency, see lightningdevkit/rust-lightning#1315.As long as
tokiobackports bug fixes to1.14.xreleases this should be safe. If we need any new features we can revisit this decision.Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
CHANGELOG.md