Skip to content

Conversation

@luisschwab
Copy link
Member

@luisschwab luisschwab commented Mar 5, 2025

Description

This PR makes Regtest the default network on wallet_example_rpc and updates the README accordingly.

Notes to the reviewers

It had Testnet as the default network, 8332 as the default port and 481824 as the starting height; now everything is Regtest.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

Copy link
Contributor

@oleonardolima oleonardolima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK 710b9cc

I personally prefer to use regtest on the examples too, let's see what others think about it.

Also, you'd need a rebase to make sure that CI is running properly.

@luisschwab luisschwab force-pushed the fix/regtest-as-default-example-wallet-rpc branch from 710b9cc to 8ed817e Compare March 6, 2025 14:29
@luisschwab luisschwab changed the title fix: make regtest default on wallet_example_rpc fix(examples): make regtest default on wallet_example_rpc Mar 6, 2025
@notmandatory notmandatory moved this to Needs Review in BDK Wallet Mar 6, 2025
@notmandatory notmandatory added the documentation Improvements or additions to documentation label Mar 6, 2025
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8ed817e

I agree, especially for the RPC client default network should be Regtest so user doesn't need to wait for testnet or mainnet IBD.

Copy link
Collaborator

@ValuedMammal ValuedMammal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8ed817e

@ValuedMammal ValuedMammal merged commit b2049a7 into bitcoindevkit:master Mar 7, 2025
23 checks passed
@github-project-automation github-project-automation bot moved this from Needs Review to Done in BDK Wallet Mar 7, 2025
@luisschwab luisschwab deleted the fix/regtest-as-default-example-wallet-rpc branch March 10, 2025 21:22
@ValuedMammal ValuedMammal mentioned this pull request Apr 3, 2025
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants