chore(examples): make change descriptor optional on example_wallet_rpc #1865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
CI failures are unrelated. Not sure about doing the same for the other examples as they require no interaction and have both descriptors hard-coded. |
luisschwab
force-pushed
the
chore/optional-change-descriptor-on-example
branch
from
ea55d4c to
e81e048
Compare
luisschwab
changed the title
luisschwab
force-pushed
the
chore/optional-change-descriptor-on-example
branch
from
e81e048 to
449576b
Compare
ValuedMammal
reviewed
Mar 7, 2025
Collaborator
|
Sorry @luisschwab, wasn't expecting to get blocked again by CI. |
luisschwab
force-pushed
the
chore/optional-change-descriptor-on-example
branch
from
449576b to
f7e49e6
Compare
Member
Author
|
I guess this will have to wait until we bump to 1.75.0 |
Member
|
@luisschwab CI should be fixed |
luisschwab
force-pushed
the
chore/optional-change-descriptor-on-example
branch
from
f7e49e6 to
78ca4b0
Compare
Member
Author
|
@ValuedMammal CI is passing again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes passing a
CHANGE_DESCRIPTORoptional onexample_wallet_rpc, as per #1533.Notes to the reviewers
Before instantiating a
Walletit checks ifargs.change_descriptoris Some. If true callsWallet::create, else callsWallet::create_single.All Submissions:
cargo fmtandcargo clippybefore committing