chore[chain,wallet]: fix build warnings

[notmandatory]

Description

fixed #1773

Notes to the reviewers

I noticed these warnings while publishing beta.6 and would like to get them fixed before the final bdk_wallet 1.0.0. With default features we should have any build warnings. To reproduce:

cargo build -p bdk_chain
cargo build -p bdk_wallet

Checklists

All Submissions:

• I've signed all my commits
• I followed the contribution guidelines
• I ran cargo fmt and cargo clippy before committing

[oleonardolima]

tACK

It looks good to me. However the only warning I was able to reproduce locally (prior to this fix) was the one in bdk_wallet. Also you might want to update the commit message to use chore(chain,wallet): instead of [...].

[notmandatory]

It looks good to me. However the only warning I was able to reproduce locally (prior to this fix) was the one in bdk_wallet. Also you might want to update the commit message to use chore(chain,wallet): instead of [...].

@oleonardolima what version of rust are you using? I'm on 1.83.0, maybe it's a new warning? I can repro with the above commands in the description on master branch. Thanks for catching the weird commit message, I don't know why I did that! haha.

[oleonardolima]

It looks good to me. However the only warning I was able to reproduce locally (prior to this fix) was the one in bdk_wallet. Also you might want to update the commit message to use chore(chain,wallet): instead of [...].

@oleonardolima what version of rust are you using? I'm on 1.83.0, maybe it's a new warning? I can repro with the above commands in the description on master branch. Thanks for catching the weird commit message, I don't know why I did that! haha.

Yes, that was the issue. I've tested with 1.83.0 and was able to reproduce the issue (I had the 1.80.1 before.

[ValuedMammal]

ACK 479117c

[ValuedMammal]

Thank you @notmandatory