feat(chain,core)!: move Merge to bdk_core
#1625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleonardolima
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
ACK a4cf905
I tested it with the examples, and they worked fine. It's valid to notice that they still use it from bdk_chain, as it's reexporting it from bdk_core.
|
ACK a4cf905 |
8 tasks
3 tasks
ValuedMammal
added a commit
that referenced
this pull request
Oct 1, 2024
…iniscript/no-std 0e80824 ci: fix build-test job with --no-default-features, add miniscript/no-std (Steve Myers) Pull request description: ### Description Fixes the CI `build-test` job with `--no-default-features` by also adding `--features miniscript/no-std`. Until `rust-miniscript` removes the `no-std` feature we need to enable it when `--no-default-features` is used to build `bdk_wallet` or the whole workspace. See also the `check-no-std` job which does the same plus enables the `bdk_chain/hashbrown` feature which is also needed to build `bdk_wallet` with `--no-default-features` but is already enabled when building the whole workspace. ### Notes to the reviewers I think we didn't catch this on #1625 because the CI job names changed and I didn't update the branch merge requirements. Another possibility is it was passing because of cached build artifacts which I removed last night when I was trying to troubleshoot something else. I've updated the required CI jobs that need to pass before allowing a PR to be merged to `master` to include the ones with `--no-default-features --features bdk_chain/hashbrown` in the name. ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [ ] I ran `cargo fmt` and `cargo clippy` before committing ACKs for top commit: ValuedMammal: ACK 0e80824 Tree-SHA512: 5da486b7fd988575b6f9c06eb108a183b47c74d58fd451453d77b53ad26f58890ee605f4a154922688dc348bc5a3c413dcd9128fd4831d8923c64a33aa4a951c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1624
Description
Moving
Mergeintobdk_core(frombdk_chain) allows persist crates to only depend onbdk_core.Changelog notice
Mergeintobdk_core.bdk_chaindependency frombdk_file_store.Checklists
All Submissions:
cargo fmtandcargo clippybefore committing