Better Gradle build files#41
Conversation
thunderbiscuit
force-pushed
the
post-release
branch
from
0edd064 to
296268c
Compare
thunderbiscuit
left a comment
thunderbiscuit
left a comment
There was a problem hiding this comment.
Some comments for reviewers.
|
|
||
| plugins { | ||
| id("org.jetbrains.kotlin.jvm") version "2.1.10" | ||
| id("application") |
There was a problem hiding this comment.
This was an unused plugin.
|
|
||
| dependencies { | ||
| implementation(project(":lib")) | ||
| testImplementation(kotlin("test")) |
There was a problem hiding this comment.
There were no tests in this module.
|
|
||
| plugins { | ||
| id("org.jetbrains.kotlin.jvm") | ||
| id("org.gradle.java-library") |
There was a problem hiding this comment.
This was an unused plugin.
| id("org.gradle.java-library") | ||
| id("org.gradle.maven-publish") | ||
| id("org.gradle.signing") | ||
| id("com.vanniktech.maven.publish") |
There was a problem hiding this comment.
These two are replaced by the vannitech plugin.
There was a problem hiding this comment.
Its great how vanniktech clears out all the "plumbing" work
| id("org.jetbrains.dokka-javadoc") | ||
| } | ||
|
|
||
| group = "org.bitcoindevkit" |
There was a problem hiding this comment.
We had those in other files initially because of the super old plugin we used for publishing, which we don't use anymore anyway. Bringing those here cleans up the weird locations for the versions.
| java { | ||
| sourceCompatibility = JavaVersion.VERSION_11 | ||
| targetCompatibility = JavaVersion.VERSION_11 | ||
| withSourcesJar() |
There was a problem hiding this comment.
These two lines are now handled by the vannitech plugin.
| tasks.withType<org.jetbrains.kotlin.gradle.tasks.KotlinCompile> { | ||
| kotlinOptions { | ||
| jvmTarget = "11" | ||
| tasks.withType<KotlinCompile> { |
There was a problem hiding this comment.
This is the new way to declare compiler options.
| } | ||
| } | ||
|
|
||
| testing { |
There was a problem hiding this comment.
Was never needed.
| } | ||
| } | ||
|
|
||
| signing { |
There was a problem hiding this comment.
Not needed anymore, as if you publish to your local maven the vanniteck plugin doesn't require signature in the first place if your keys are not set.
| id("org.gradle.java-library") | ||
| id("org.gradle.maven-publish") | ||
| id("org.gradle.signing") | ||
| id("com.vanniktech.maven.publish") |
There was a problem hiding this comment.
Its great how vanniktech clears out all the "plumbing" work
thunderbiscuit
force-pushed
the
post-release
branch
from
296268c to
57942f2
Compare
2 participants
This PR does a few things: