-
Notifications
You must be signed in to change notification settings - Fork 63
Update bdk dependency to 0.22 #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bdk dependency to 0.22 #193
Conversation
|
Because As is, the I tried just for fun to add to the UDL file but unfortunatly it throws this error: error[E0432]: unresolved import `bdk::FfiConverterTypeBalance`
--> /Users/user/repos/bdk-ffi/target/release/build/bdk-ffi-28f1e274c858a20d/out/bdk.uniffi.rs:2621:5
|
2621 | use bdk::FfiConverterTypeBalance;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `FfiConverterTypeBalance` in the root
For more information about this error, try `rustc --explain E0432`.
error: could not compile `bdk-ffi` due to previous error |
|
@thunderbiscuit I think we should make a bdk-ffi version of the |
f71c4c9 to
5d1d7ba
Compare
|
ACK a6af35c. Ready for merging when the new BDK version comes out. |
5d1d7ba to
a6af35c
Compare
a6af35c to
ca63591
Compare
|
I rebased and updated the CHANGELOG. I also updated the PR title and changed this to a draft, once bdk 0.22 is published this PR can then be updated to replace the bdk 0.22.0-rc.1 version with the final 0.22 version. |
ca63591 to
df8ddd1
Compare
df8ddd1 to
3c6075a
Compare
|
Updated PR branch with final bdk release version 0.22. This should be ready to merge. |
notmandatory
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 3c6075a
The bindings do not build when attempting this upgrade because
get_balance()now returns aBalancestruct (this was merged in bitcoindevkit/bdk#640)When we upgrade to
0.22.0we could decide to add theBalancestruct to the bindings, or simply return the total by callingget_total(), which returns au64(same as we have now).