Swift compiler warning

[thunderbiscuit]

I'm not sure yet what to make of this, and it's probably something we'd need to bring up at the uniffi level, but this is a new warning I get when compiling the Swift library:

bdk-ffi/bdk-swift/Tests/BitcoinDevKitTests/LiveMemoryWalletTests.swift:80:7: warning: non-final class 'FullScriptInspector' cannot conform to 'Sendable'; use '@unchecked Sendable'; this is an error in the Swift 6 language mode
78 | }
79 |
80 | class FullScriptInspector: FullScanScriptInspector {
   |       `- warning: non-final class 'FullScriptInspector' cannot conform to 'Sendable'; use '@unchecked Sendable'; this is an error in the Swift 6 language mode

[rubensmachion]

Hello @thunderbiscuit. I think this PR resolve this issue

#735

[reez]

The Sendable warnings are surfacing due to Swift 6's new stricter concurrency checks.

This warning above was scoped to just a single swift test and is fixed now (PR #735) by @rubensmachion , i tested live tests locally.

We have a few warnings in the iOS example app similar to this, but are app-level integration things related to new Swift 6 concurrency checks.

But I do think its good for us to keep tabs on how uniffi is handling this stuff, and how it may/may-not affect bdk-ffi. bdk-ffi itself might not have widespread internal warnings now, but since it depends on uniffi which still has open issues regarding generating fully Swift 6/Sendable-compliant code, we need to keep an eye on things like https://github.com/mozilla/uniffi-rs/issues?q=is%3Aissue%20state%3Aopen%20sendable https://github.com/mozilla/uniffi-rs/issues?q=is%3Aissue%20state%3Aopen%20swift%206, but I dont see an immediate action item for us.

So I'll close this for now, but we can use it as reference and keep tabs on uniffi handling Swift 6 ongoing