Skip to content

fix(example): always dispose ElectrumClient in sync example #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reez merged 1 commit into from
Feb 6, 2026
Merged

fix(example): always dispose ElectrumClient in sync example #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions example/main.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,10 @@ void main() {
stdout.writeln('Persisted staged wallet changes: $persisted');

// 5. Try a quick Electrum sync to fetch history/balances.
ElectrumClient? client;
try {
stdout.writeln('\nSyncing via Electrum (blockstream.info)…');
final client = ElectrumClient(
'ssl://electrum.blockstream.info:60002',
null,
);
client = ElectrumClient('ssl://electrum.blockstream.info:60002', null);
final syncRequest = wallet.startSyncWithRevealedSpks().build();
final update = client.sync_(syncRequest, 100, true);

Expand All @@ -66,13 +64,13 @@ void main() {
final balance = wallet.balance();
stdout.writeln('Confirmed balance: ${balance.confirmed.toSat()} sats');
stdout.writeln('Total balance: ${balance.total.toSat()} sats');

client.dispose();
} catch (error) {
stdout.writeln(
'Electrum sync failed: $error\n'
'Ensure TLS-enabled Electrum access is available, or skip this step.',
);
} finally {
client?.dispose();
}

// 6. Clean up FFI handles explicitly so long-lived examples don’t leak.
Expand Down