-
Notifications
You must be signed in to change notification settings - Fork 87
Add experimental silent payment transaction creation support #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nymius
wants to merge
10
commits into
bitcoindevkit:master
Choose a base branch
from
nymius:feat/sp-psbt-send
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
88e02dd
feat(silentpayments): add CreateSpTx command for silent payment trans…
nymius 6d2b508
refactor(silentpayments): use full import path for XOnlyPublicKey in …
nymius 157250a
feat(silentpayments): handle bdk_wallet::tx_builder::AddUtxoError::Un…
nymius 38abbdd
feat(silentpayments): add error handling in data carrier logic
nymius 795e707
feat(create-tx): handle bdk_wallet::tx_builder::AddUtxoError::Unknown…
nymius e8f2e48
feat(create-tx): add error handling in data carrier logic
nymius 4154a33
feat(silentpayments): add BDKCliError::SilentPaymentParseError variant
nymius d0873d1
refactor(silentpayments): use BDKCliError in parse_sp_code_value_pair…
nymius 84f8750
feat(silentpayments): add SilentPaymentCode command
nymius 8d15df7
doc(silentpayments): add README section for new silent payment commands
nymius File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -21,6 +21,9 @@ pub enum BDKCliError { | |||||||
| #[error("Create transaction error: {0}")] | ||||||||
| CreateTx(#[from] bdk_wallet::error::CreateTxError), | ||||||||
|
|
||||||||
| #[error("Silent payment address decoding error: {0}")] | ||||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
| SilentPaymentParseError(#[from] bdk_sp::encoding::ParseError), | ||||||||
|
|
||||||||
| #[error("Descriptor error: {0}")] | ||||||||
| DescriptorError(#[from] bdk_wallet::descriptor::error::Error), | ||||||||
|
|
||||||||
|
|
||||||||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.