Skip to content

Fix compilation error when using memory database #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2022
Merged

Fix compilation error when using memory database #114

merged 1 commit into from
Aug 28, 2022

Conversation

@danielabrozzoni
Copy link
Member

@danielabrozzoni danielabrozzoni commented Aug 24, 2022 •
edited
Loading

This commit also adds the testing for memory database and key value
database in CI

Description

Notes to the reviewers

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@danielabrozzoni danielabrozzoni force-pushed the fix/open_db_memory branch 2 times, most recently from 16fa398 to d8759af Compare August 24, 2022 21:47
afilini
afilini approved these changes Aug 27, 2022
View reviewed changes
Copy link
Member

@afilini afilini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d8759af

notmandatory
notmandatory requested changes Aug 27, 2022
View reviewed changes
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a little typo to fix.

@danielabrozzoni
Fix compilation error when using memory database
faa461d 
This commit also adds the testing for memory database and key value
database in CI
@danielabrozzoni danielabrozzoni mentioned this pull request Aug 28, 2022
Merged
6 tasks
notmandatory
notmandatory approved these changes Aug 28, 2022
View reviewed changes
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK faa461d

@notmandatory notmandatory merged commit be36eeb into bitcoindevkit:master Aug 28, 2022
@notmandatory notmandatory added this to the Release 0.6.0 milestone Aug 28, 2022
@notmandatory notmandatory mentioned this pull request Aug 29, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afilini afilini afilini approved these changes

@notmandatory notmandatory notmandatory approved these changes

Assignees

@danielabrozzoni danielabrozzoni

Labels

None yet

Projects

BDK-CLI
Archived in project

Milestone

Release 0.6.0

Development

Successfully merging this pull request may close these issues.

3 participants

@danielabrozzoni @afilini @notmandatory