Skip to content

Conversation

@rajarshimaitra
Copy link
Contributor

Description

Currently the way ExternalReserves functionality is written, it can only be used with electrum feature. The tests should fail if the implementation behavior is enforced.. Disabling the tests in CI.

Also removing the regtest-esplora features from the tests, because they won't work when #92 lands.

Notes to the reviewers

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@rajarshimaitra rajarshimaitra mentioned this pull request Jun 15, 2022
6 tasks
@rajarshimaitra
Copy link
Contributor Author

@notmandatory we need to get this one merged before we can make the CI pass for #99 and #102 ..

Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 5b20283.

I adjusted the github actions branch rules to match changes in this PR also.

@notmandatory notmandatory merged commit 14866e2 into bitcoindevkit:master Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants