Do not execute controller if the response is already sent

bitcoin333 · May 26, 2016 · 872dc79 · 872dc79
1 parent 74a84a2
commit 872dc79
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 2 deletions.
diff --git a/app/Core/Controller/Runner.php b/app/Core/Controller/Runner.php
@@ -26,7 +26,10 @@ public function execute()
     {
         try {
             $this->executeMiddleware();
-            $this->executeController();
+
+            if (!$this->response->isResponseAlreadySent()) {
+                $this->executeController();
+            }
         } catch (PageNotFoundException $e) {
             $controllerObject = new AppController($this->container);
             $controllerObject->notFound($e->hasLayout());

diff --git a/app/Core/Http/Response.php b/app/Core/Http/Response.php
@@ -16,6 +16,18 @@ class Response extends Base
     private $httpStatusCode = 200;
     private $httpHeaders = array();
     private $httpBody = '';
+    private $responseSent = false;
+
+    /**
+     * Return true if the response have been sent to the user agent
+     *
+     * @access public
+     * @return bool
+     */
+    public function isResponseAlreadySent()
+    {
+        return $this->responseSent;
+    }
 
     /**
      * Set HTTP status code
@@ -187,6 +199,8 @@ public function withFileDownload($filename)
      */
     public function send()
     {
+        $this->responseSent = true;
+
         if ($this->httpStatusCode !== 200) {
             header('Status: '.$this->httpStatusCode);
             header($this->request->getServerVariable('SERVER_PROTOCOL').' '.$this->httpStatusCode);

diff --git a/app/Middleware/BootstrapMiddleware.php b/app/Middleware/BootstrapMiddleware.php
@@ -33,7 +33,7 @@ private function sendHeaders()
         $this->response->withContentSecurityPolicy($this->container['cspRules']);
         $this->response->withSecurityHeaders();
 
-        if (ENABLE_XFRAME && $this->router->getAction() !== 'readonly') {
+        if (ENABLE_XFRAME) {
             $this->response->withXframe();
         }