build: Prevent system header fallback and include path pollution by hebasto · Pull Request #34143 · bitcoin/bitcoin

hebasto · 2025-12-23T22:17:29Z

Currently, header-only dependencies in the depends subsystem are installed into the standard include/ subdirectory. This inadvertently exposes their headers to the compiler via -I flags brought in by other dependencies (e.g., libevent or sqlite). This "include path pollution" masks missing dependencies in the build configuration. While the build might succeed by accident due to this overlap, it creates a fragile state. If the overlapping library is removed, the build will break, or, worse, the compiler may silently fall back to the host system's default paths (e.g., /usr/include).

This PR improves build system security and hygiene by enforcing strict, distinguished include paths for header-only dependencies. The missing dependencies revealed by this change (Boost::headers, USDT::headers) have been fixed in separate commits.

DrahtBot · 2025-12-23T22:17:35Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/34143.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	theuni, fanquake
Concept ACK	willcl-ark

If your review is incorrectly listed, please copy-paste  into the comment that the bot should ignore.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#34411 ([POC] Full Libevent removal by fanquake)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

DrahtBot · 2025-12-26T14:33:31Z

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

File	commit `d861c38` (master)	commit `fc47676` (pull/34143/merge)
*-aarch64-linux-gnu-debug.tar.gz	`f9d3466be61a6744...`	`aa205a142b3e0679...`
*-aarch64-linux-gnu.tar.gz	`eeba55f49bb0cea8...`	`1f63f2ac82a3a9d6...`
*-arm-linux-gnueabihf-debug.tar.gz	`377cb91a664d226d...`	`7382c420ee6d9afa...`
*-arm-linux-gnueabihf.tar.gz	`e9439c9e75940962...`	`f1d7d1df4e0b27e1...`
*-arm64-apple-darwin-codesigning.tar.gz	`e24ade4558599abc...`	`36db4b587b2a1f80...`
*-arm64-apple-darwin-unsigned.tar.gz	`139e5c93b62e6bd9...`	`8a2c8c8c4ddecd97...`
*-arm64-apple-darwin-unsigned.zip	`7938b4588c399d57...`	`7601a21a0eb3b5ea...`
*-powerpc64-linux-gnu-debug.tar.gz	`c673cfd562f48b6b...`	`c5cf337561643c15...`
*-powerpc64-linux-gnu.tar.gz	`6089f3e1aeaff9f2...`	`f0e69970d9148f61...`
*-riscv64-linux-gnu-debug.tar.gz	`81def88068aa605d...`	`e0bcdda86d024735...`
*-riscv64-linux-gnu.tar.gz	`ca77e2eeff5a7997...`	`1b276f8d8b508587...`
*-x86_64-apple-darwin-codesigning.tar.gz	`0c79942deef08bb4...`	`4445c35eabc5a5c0...`
*-x86_64-apple-darwin-unsigned.tar.gz	`6f6a22f4292aa086...`	`7e9725da2a01d31e...`
*-x86_64-apple-darwin-unsigned.zip	`9bd50bc5b804299f...`	`cd302fca0fe6acf5...`
*-x86_64-linux-gnu-debug.tar.gz	`a6f0a158b31947a7...`	`8832ff496bdef1c0...`
*-x86_64-linux-gnu.tar.gz	`152bfb79e73d6c5c...`	`c314349c64f3b42f...`
*.tar.gz	`11c03cf932f54c54...`	`42bd5bfa5f3c093d...`
SHA256SUMS.part	`1d1e22a8c246fe3b...`	`5d7796eab94e93f7...`
guix_build.log	`ec31c8f59d97cbaa...`	`97ab9e864bd8a123...`
guix_build.log.diff		`08e07a75cde5ff16...`

janb84 · 2025-12-28T15:21:42Z

my Guix Build Output

Host architecture: aarch64
Commit: 2a6901529c73

5eb1bd5a15708f4270eebbbb8f9e7f7f431da2c8d69603826f47ac18e58b31fd  guix-build-2a6901529c73/output/aarch64-linux-gnu/SHA256SUMS.part
b46120b21bacb54cb999a7ee34906203b74a82a7a797adfaf5160ffe39df179f  guix-build-2a6901529c73/output/aarch64-linux-gnu/bitcoin-2a6901529c73-aarch64-linux-gnu-debug.tar.gz
8d0ab4938c9b3dab75d0a3c75b97aca6ed35644fcdd42eedd95b5b6152892285  guix-build-2a6901529c73/output/aarch64-linux-gnu/bitcoin-2a6901529c73-aarch64-linux-gnu.tar.gz
d61e0f3bdb67fb09bd95f9457f2e4fa5949b88045a21ec5519291ee6bea77051  guix-build-2a6901529c73/output/arm-linux-gnueabihf/SHA256SUMS.part
b0b1ded64d6f62e4e42fd24e8429a616d372b3d1302a041f73737b2593588558  guix-build-2a6901529c73/output/arm-linux-gnueabihf/bitcoin-2a6901529c73-arm-linux-gnueabihf-debug.tar.gz
004b14d5513ce82262cc9510401714a97af37522eff3481a0d70db581f06cd3c  guix-build-2a6901529c73/output/arm-linux-gnueabihf/bitcoin-2a6901529c73-arm-linux-gnueabihf.tar.gz
9dad3b1374d23171fa400dc286551ee61ac188bec14d576a038ed6de1820fd1a  guix-build-2a6901529c73/output/arm64-apple-darwin/SHA256SUMS.part
e101af1b0fd333d5e498da19278b00d844e44f14e46678804577124bd1d9eaef  guix-build-2a6901529c73/output/arm64-apple-darwin/bitcoin-2a6901529c73-arm64-apple-darwin-codesigning.tar.gz
b21d7e342bf3e3dbf4a30b547d0eab4c5482e6c48cafc7e52ed6ce84f274f771  guix-build-2a6901529c73/output/arm64-apple-darwin/bitcoin-2a6901529c73-arm64-apple-darwin-unsigned.tar.gz
57fe0760877802005946963d87c3a6b5849f3d03fd7ad412b2c55f345d0af163  guix-build-2a6901529c73/output/arm64-apple-darwin/bitcoin-2a6901529c73-arm64-apple-darwin-unsigned.zip
7f074c95551f7bbf9f23a85f0ad46aebf9a6069f17e3c89230257ae96b107338  guix-build-2a6901529c73/output/dist-archive/bitcoin-2a6901529c73.tar.gz
920dc7d726be94004b3003b7d0d1e7ac59ce1fe64275cc42712bb1fa63737e8d  guix-build-2a6901529c73/output/powerpc64-linux-gnu/SHA256SUMS.part
d3f6f76cc2df64b263612224efdbc5cda29960d939ed7fef56fdb2547618f23e  guix-build-2a6901529c73/output/powerpc64-linux-gnu/bitcoin-2a6901529c73-powerpc64-linux-gnu-debug.tar.gz
0970e286347486e9fef88f15e2409911d09fbbf2cf1d52e8a06a4cc247923e48  guix-build-2a6901529c73/output/powerpc64-linux-gnu/bitcoin-2a6901529c73-powerpc64-linux-gnu.tar.gz
1a9b469909c685d46aeea0668dff6f532570154e4f8abe7224d94c92ef28d1c5  guix-build-2a6901529c73/output/riscv64-linux-gnu/SHA256SUMS.part
c5a49c68ae6346d1510b497c483e25b04c1aac22f4b9580a15efb80c5590a3cb  guix-build-2a6901529c73/output/riscv64-linux-gnu/bitcoin-2a6901529c73-riscv64-linux-gnu-debug.tar.gz
2bd07c73dc5a13ee33d27db52d903a7f4a71fac45db7b636c37b02c6d3fb4b5f  guix-build-2a6901529c73/output/riscv64-linux-gnu/bitcoin-2a6901529c73-riscv64-linux-gnu.tar.gz
55b3a2b6258cb645547eb01c3ef46fcd97d4cb27ca8dd84c9c9a91ea1314cf81  guix-build-2a6901529c73/output/x86_64-apple-darwin/SHA256SUMS.part
8e52dc444786c392ac6010b6bb2c8d2536d8da4731a4ef87f211af548bf9dced  guix-build-2a6901529c73/output/x86_64-apple-darwin/bitcoin-2a6901529c73-x86_64-apple-darwin-codesigning.tar.gz
373ceed73edcc41a343d2bce9b3f6d36634ca873b5d53959464f89435417f585  guix-build-2a6901529c73/output/x86_64-apple-darwin/bitcoin-2a6901529c73-x86_64-apple-darwin-unsigned.tar.gz
80e3980143fd4d5d8728e660ff01d029c1a8aab69f9718decd0b2149e287d88d  guix-build-2a6901529c73/output/x86_64-apple-darwin/bitcoin-2a6901529c73-x86_64-apple-darwin-unsigned.zip
392c4d7911daf946bbf913ee27975bfda37693a992ca61794018e39c2fbad68f  guix-build-2a6901529c73/output/x86_64-linux-gnu/SHA256SUMS.part
6bc8ce0727114c65006e98392795d255ed74e2f7a2ebf9ea7518c369fe577fe3  guix-build-2a6901529c73/output/x86_64-linux-gnu/bitcoin-2a6901529c73-x86_64-linux-gnu-debug.tar.gz
95207f982880b179ec329efd8f0c8cee89868874953d7c8125c2fde44c1edf0f  guix-build-2a6901529c73/output/x86_64-linux-gnu/bitcoin-2a6901529c73-x86_64-linux-gnu.tar.gz
e269e1eae037b5c76f168945566c44d0695398f287ca6b131f789591ec88462c  guix-build-2a6901529c73/output/x86_64-w64-mingw32/SHA256SUMS.part
65961e3ab4f98f24db751802a58e1bb1640d956f3b0ae5ee081cef4a8fe897f4  guix-build-2a6901529c73/output/x86_64-w64-mingw32/bitcoin-2a6901529c73-win64-codesigning.tar.gz
928be5ef461640e856bb9ded3e40a2e8ef131beb8423aa930f43cec34a50a973  guix-build-2a6901529c73/output/x86_64-w64-mingw32/bitcoin-2a6901529c73-win64-debug.zip
5521ed52afad02466930117496741114e7c62792bac25fc707869711c4a115c8  guix-build-2a6901529c73/output/x86_64-w64-mingw32/bitcoin-2a6901529c73-win64-setup-unsigned.exe
adc5553e1a162662ef668093dba297874a075ddb04992c9f15b58e4fe2131e43  guix-build-2a6901529c73/output/x86_64-w64-mingw32/bitcoin-2a6901529c73-win64-unsigned.zip

theuni · 2026-01-20T18:03:23Z

Nice. Concept ACK to moving, but I'd like to explore something else before making this boost-specific.

Ideally, all packages would be installed to their own prefix so that no two include dirs are the same. As-is, we could (using your example) run into the same conflict between libevent and sqlite.

The reason depends uses a common prefix by default is that some depends packages depend on other depends packages (the qt/x11 ones, for example).

Since those are the exception rather than the rule, perhaps in the future it would be worth switching to per-package prefixes, and requiring the deps to specify dependent package prefixes where necessary.

For CMake packages, which is most these days (including boost), I wonder if we could do something like this instead:

diff --git a/depends/funcs.mk b/depends/funcs.mk
index 60e7889a4ec..921464b37ba 100644
--- a/depends/funcs.mk
+++ b/depends/funcs.mk
@@ -223,6 +223,7 @@ $(1)_cmake=env CC="$$($(1)_cc)" \
                -DCMAKE_NM=`which $$($(1)_nm)` \
                -DCMAKE_RANLIB=`which $$($(1)_ranlib)` \
                -DCMAKE_INSTALL_LIBDIR=lib/ \
+               -DCMAKE_INSTALL_INCLUDEDIR=$(1)/include \
                -DCMAKE_POSITION_INDEPENDENT_CODE=ON \
                -DCMAKE_VERBOSE_MAKEFILE:BOOL=$(V) \
                -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY:BOOL=TRUE \

That way the package is still found in the depends root prefix, but each cmake dep gets its own include path.

A quick test shows that this works for boost but it's broken for zmq (doesn't find the includedir), libevent (doesn't install to the includedir), and libmultiprocess (not sure what the problem is there). Am I missing something, or are all of those really misbehaving?

hebasto · 2026-01-21T12:29:48Z

For CMake packages, which is most these days (including boost), I wonder if we could do something like this instead:
diff --git a/depends/funcs.mk b/depends/funcs.mk
index 60e7889a4ec..921464b37ba 100644
--- a/depends/funcs.mk
+++ b/depends/funcs.mk
@@ -223,6 +223,7 @@ $(1)_cmake=env CC="$$($(1)_cc)" \
                -DCMAKE_NM=`which $$($(1)_nm)` \
                -DCMAKE_RANLIB=`which $$($(1)_ranlib)` \
                -DCMAKE_INSTALL_LIBDIR=lib/ \
+               -DCMAKE_INSTALL_INCLUDEDIR=$(1)/include \
                -DCMAKE_POSITION_INDEPENDENT_CODE=ON \
                -DCMAKE_VERBOSE_MAKEFILE:BOOL=$(V) \
                -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY:BOOL=TRUE \
That way the package is still found in the depends root prefix, but each cmake dep gets its own include path.

A quick test shows that this works for boost but it's broken for zmq (doesn't find the includedir), libevent (doesn't install to the includedir), and libmultiprocess (not sure what the problem is there). Am I missing something, or are all of those really misbehaving?

This approach seems fragile to me, as CMAKE_INSTALL_INCLUDEDIR is defined in the GNUInstallDirs module, which might not be used by every package. For instance, it was introduced to libevent only in libevent/libevent#1397.

Regarding libzmq, a fix for the bug has been proposed in zeromq/libzmq#4832.

theuni · 2026-01-21T17:09:48Z

Ok, thanks for confirming.

FWIW, this does seem like the right thing for us to be doing, but apparently with CMake it's unlikely that a custom CMAKE_INSTALL_INCLUDEDIR will be respected for a majority of dependencies, so I agree that it's probably not worth the hassle of setting it for all packages.

As an alternative, according to their docs, Boost explicitly supports building with CMAKE_INSTALL_INCLUDEDIR. Specifying that would be more explicit about what's happening here, as opposed to using the versioned layout which just happens to do what we want. Any reason not to use that for the boost build and set it to a depends-specific subdir instead?

Either way, please add a comment about why we're setting the var.

theuni · 2026-01-21T17:10:13Z

Also, nice work on the fix for zmq :)

hebasto · 2026-01-21T22:39:36Z

@theuni

Thank you for the review! Your feedback has been addressed.

Additionally, I applied the same approach to the systemtap package and fixed the related missing dependency.

The PR description has been updated.

theuni · 2026-01-22T16:02:24Z

Grr, the systemtap issue kinda reinforces my point about using CMAKE_INSTALL_INCLUDEDIR. Thinking about it more, it'd be nice to set that, fix (and upstream) the packages where it's broken, and ignore the ones where it's non-functional.

What do you think about:

Carrying the zmq patch
Fixing libmultiprocess/capnp (it's not clear to me where the issue lies)
Setting CMAKE_INSTALL_INCLUDEDIR globally?

Seems to me: worst case (like our libevent version) it's simply ignored, some cases it's broken so we fix and upstream, best case it actually catches things. Assuming carrying any necessary patches is trivial enough, I don't really see any downside?

theuni · 2026-01-22T21:23:00Z

Ugh, there are actually several libmultiprocess issues.

First, capnproto needs a fix:

diff --git a/c++/src/capnp/CMakeLists.txt b/c++/src/capnp/CMakeLists.txt
index 9980fde6..8b93617e 100644
--- a/c++/src/capnp/CMakeLists.txt
+++ b/c++/src/capnp/CMakeLists.txt
@@ -71,3 +71,3 @@ target_include_directories(capnp INTERFACE
   $<BUILD_INTERFACE:${PARENT_DIR}>
-  $<INSTALL_INTERFACE:include>
+  $<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>
 )
diff --git a/c++/src/kj/CMakeLists.txt b/c++/src/kj/CMakeLists.txt
index 48c49b74..bf30b00b 100644
--- a/c++/src/kj/CMakeLists.txt
+++ b/c++/src/kj/CMakeLists.txt
@@ -91,3 +91,3 @@ target_include_directories(kj PUBLIC
   $<BUILD_INTERFACE:${PARENT_DIR}>
-  $<INSTALL_INTERFACE:include>
+  $<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>
 )

Then, for some reason (I suspect I'm missing something else in capnproto), libmultiprocess still needs help finding them..

diff --git a/src/ipc/libmultiprocess/CMakeLists.txt b/src/ipc/libmultiprocess/CMakeLists.txt
index a36023b1810..89351deaecd 100644
--- a/src/ipc/libmultiprocess/CMakeLists.txt
+++ b/src/ipc/libmultiprocess/CMakeLists.txt
@@ -144,3 +144,4 @@ target_include_directories(mputil PRIVATE
   $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
-  $<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}/include>)
+  $<BUILD_INTERFACE:${CMAKE_CURRENT_BINARY_DIR}/include>
+  $<BUILD_INTERFACE:${CAPNP_INCLUDE_DIRECTORY}>)
 target_link_libraries(mputil PUBLIC CapnProto::kj)
@@ -184,2 +185,3 @@ target_include_directories(multiprocess PUBLIC
   $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>
+  $<BUILD_INTERFACE:${CAPNP_INCLUDE_DIRECTORY}>
   $<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>)

THEN, there's the issue of mpgen hard-coding capnproto include paths and not respecting CAPNP_EXECUTABLE/CAPNPC_CXX_EXECUTABLE.

I do think those things are worth fixing, but there's no need for that to get in the way of the other fixes.

theuni

utACK 2921491

hebasto · 2026-01-22T22:50:12Z

Ugh, there are actually several libmultiprocess issues.

cc @ryanofsky

hebasto · 2026-01-25T15:35:06Z

My Guix build:

$ uname -m && find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
x86_64
00edb8bb6e51e78b33fb11fdcdf9b2f45c4c14fa8f7ffa1268a5bf4053fa07a5  guix-build-29214919fa03/output/aarch64-linux-gnu/SHA256SUMS.part
0a552b9e4c7ba85ecdf25f078e3fa6ba8dd6329ba9d8e14986ca172e39da3c5d  guix-build-29214919fa03/output/aarch64-linux-gnu/bitcoin-29214919fa03-aarch64-linux-gnu-debug.tar.gz
2b95b3f8d096a61a0d8aca91ceb23f215ff19b18d69402806dfe856ac66ae20d  guix-build-29214919fa03/output/aarch64-linux-gnu/bitcoin-29214919fa03-aarch64-linux-gnu.tar.gz
efd64763669cc57e7e28a9c101ac2b87f9dff9b3d527985870672c142ffb72ef  guix-build-29214919fa03/output/arm-linux-gnueabihf/SHA256SUMS.part
52adf5c3a7b121f940af71609c3934b2b458538ac9ce4f467aca01222463861f  guix-build-29214919fa03/output/arm-linux-gnueabihf/bitcoin-29214919fa03-arm-linux-gnueabihf-debug.tar.gz
f01545f641da70335d648a451aff49ca20743ba0ab9c90dc071bb268517cc494  guix-build-29214919fa03/output/arm-linux-gnueabihf/bitcoin-29214919fa03-arm-linux-gnueabihf.tar.gz
8d0c103124e1de45a20ab9bccb5f6e472cf66b75754f693f1d7048b09badc9ef  guix-build-29214919fa03/output/arm64-apple-darwin/SHA256SUMS.part
0905f370b495568ac12aad2b23aabbaa066aa0cf21db1f2ba8ec5d4604e57370  guix-build-29214919fa03/output/arm64-apple-darwin/bitcoin-29214919fa03-arm64-apple-darwin-codesigning.tar.gz
014e516279b4f44115b050ea8e680fadf998e0e7f17996300df2739e6e005524  guix-build-29214919fa03/output/arm64-apple-darwin/bitcoin-29214919fa03-arm64-apple-darwin-unsigned.tar.gz
7b0b8960049861848e6c6d3e047c3b16aa9f8746b58a24286db94c5732cb28c6  guix-build-29214919fa03/output/arm64-apple-darwin/bitcoin-29214919fa03-arm64-apple-darwin-unsigned.zip
e6f09db4402fd396e1247006d7e1e3eb014f32f8d7ea92ae7dfa6e656b64e2c8  guix-build-29214919fa03/output/dist-archive/bitcoin-29214919fa03.tar.gz
1247c558e878d061674289fe64ce5f6caa5104b4c7076493895ac8217a198ef5  guix-build-29214919fa03/output/powerpc64-linux-gnu/SHA256SUMS.part
879a4bb92073c1b379fd68e84811cb3d8eed75b393a5d34b090ea317fa1a1b44  guix-build-29214919fa03/output/powerpc64-linux-gnu/bitcoin-29214919fa03-powerpc64-linux-gnu-debug.tar.gz
174545a07eb9abecb6d86e2acc5547d52cc6ae1561300536ee9f0d88b092bf4e  guix-build-29214919fa03/output/powerpc64-linux-gnu/bitcoin-29214919fa03-powerpc64-linux-gnu.tar.gz
fed409926b48e18f0b430dcdf92e908c69210deccc1f9502c7f0228eb369223d  guix-build-29214919fa03/output/riscv64-linux-gnu/SHA256SUMS.part
592ea33e41adc0d28600703b911e05135c3dd22512f0c0f2f4703d0a060b13cd  guix-build-29214919fa03/output/riscv64-linux-gnu/bitcoin-29214919fa03-riscv64-linux-gnu-debug.tar.gz
43b0d5a08957fa2c7bc7190ce4720b8b228a4104d9adddc30aa34f8de12ffe2f  guix-build-29214919fa03/output/riscv64-linux-gnu/bitcoin-29214919fa03-riscv64-linux-gnu.tar.gz
1cd29f87eb9233e19a67f65f8d1025f897b7b8a0c9a9d2972e5903b66a8aec3d  guix-build-29214919fa03/output/x86_64-apple-darwin/SHA256SUMS.part
515e4a37184426d9f1bc4b47f714a73e7b276fc61813d93bd1c787925704735d  guix-build-29214919fa03/output/x86_64-apple-darwin/bitcoin-29214919fa03-x86_64-apple-darwin-codesigning.tar.gz
b42186929bcbe6fa178cae8205902aa880b7e96b92e1b7f5c28466e998e666f3  guix-build-29214919fa03/output/x86_64-apple-darwin/bitcoin-29214919fa03-x86_64-apple-darwin-unsigned.tar.gz
dea2dad5d055fd9b827b4aa37f7d9eb7d19993331967fe0d0024acee86bd77f2  guix-build-29214919fa03/output/x86_64-apple-darwin/bitcoin-29214919fa03-x86_64-apple-darwin-unsigned.zip
74d5847668219c17618805416dcf28cf3200388f9e91b08d30de3670e9f3dd23  guix-build-29214919fa03/output/x86_64-linux-gnu/SHA256SUMS.part
ac0d537d45aa5459ab6ca5ba6583da1540f87b8d38a0b5bf68e055316b41aef7  guix-build-29214919fa03/output/x86_64-linux-gnu/bitcoin-29214919fa03-x86_64-linux-gnu-debug.tar.gz
734d88f2cb29f0cc54cc6ccd8ee6246d5ec9030eee0f5cfaa5b715fe5c2c064e  guix-build-29214919fa03/output/x86_64-linux-gnu/bitcoin-29214919fa03-x86_64-linux-gnu.tar.gz
e2340ccd2838455955ff4396ac2b63738727d6354a75b31bab3f115cf4ffb748  guix-build-29214919fa03/output/x86_64-w64-mingw32/SHA256SUMS.part
6bb522e50ddf922cc2ae457fa683189a5c86e212fd541df4f830cd7ca3a49cc5  guix-build-29214919fa03/output/x86_64-w64-mingw32/bitcoin-29214919fa03-win64-codesigning.tar.gz
a6b12c9d9a1e548ce4c8532e30644b4a4fa43c9d97457af8ad26aedd34c718e2  guix-build-29214919fa03/output/x86_64-w64-mingw32/bitcoin-29214919fa03-win64-debug.zip
122eb2f3debb9bed5ff9b14ec3c02a8f4394a45351735f85555822d0d9c79aeb  guix-build-29214919fa03/output/x86_64-w64-mingw32/bitcoin-29214919fa03-win64-setup-unsigned.exe
fca881a9d2a4b60e8467c17b15d030ce02497698db43ecb0204cbd5f4814be0d  guix-build-29214919fa03/output/x86_64-w64-mingw32/bitcoin-29214919fa03-win64-unsigned.zip

a50d0b6 build: don't pass on boost dependency to kernel consumers (Cory Fields) Pull request description: This is unnecessary now that the kernel now exports a (boost-less) API. Noticed while slimming down boost dependencies in #34495. ACKs for top commit: stickies-v: ACK a50d0b6 hebasto: ACK a50d0b6, I have reviewed the code and it looks OK. I tested it by applying the Boost-specifc commits from #34143 and building with depends. Tree-SHA512: e2d12356f41dd51dd729362121a33bd4f395821d53dd9a0bb0d5d6a53aba2ca2064e0709d9799dc6751b3d61ea576d2efc0e28296fdba26f2809dbcb0feabe44

hebasto · 2026-02-05T13:47:01Z

Rebased.

hebasto · 2026-02-05T15:29:25Z

My Guix build:

$ uname -m && find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
aarch64
d763a6657762eb0c77192c722c48bdd57473f5aa9cd12c3ac4e88fe509fbf130  guix-build-65134c7e5f99/output/aarch64-linux-gnu/SHA256SUMS.part
cebab577dd7a29ed13e20c6f3996062fd51caa9af33b15170094b1708318e770  guix-build-65134c7e5f99/output/aarch64-linux-gnu/bitcoin-65134c7e5f99-aarch64-linux-gnu-debug.tar.gz
ac0bbeeba7cfcc3618fc8e0f745747cace8505d1d7d23568d5707bdd5911897e  guix-build-65134c7e5f99/output/aarch64-linux-gnu/bitcoin-65134c7e5f99-aarch64-linux-gnu.tar.gz
553a97634cae34da03f4c2d4173b38cad8a40fc2562b777faffbfbb624dbe245  guix-build-65134c7e5f99/output/arm-linux-gnueabihf/SHA256SUMS.part
ea8826e63a9d8ecaf71249019a33932ab58497dd1b3c11a936cf94ee55727d51  guix-build-65134c7e5f99/output/arm-linux-gnueabihf/bitcoin-65134c7e5f99-arm-linux-gnueabihf-debug.tar.gz
689235f63a2d80642225963d70cb5b902664a80066e2d61131d9345d5cd83ab2  guix-build-65134c7e5f99/output/arm-linux-gnueabihf/bitcoin-65134c7e5f99-arm-linux-gnueabihf.tar.gz
037fb650bf5f5c727e9577e0ff5072e32bd2b448fac2fdc23dba34fbc539e6f0  guix-build-65134c7e5f99/output/arm64-apple-darwin/SHA256SUMS.part
eb29f6eb0f738a9a53d76811e2fb66b90c4fa8df4cb661c30c25527157106d7e  guix-build-65134c7e5f99/output/arm64-apple-darwin/bitcoin-65134c7e5f99-arm64-apple-darwin-codesigning.tar.gz
b8ea38b5ebd7a115eb7b08ea1343dc936e45ff29db0b14aacdc8a9d38a5d0eb8  guix-build-65134c7e5f99/output/arm64-apple-darwin/bitcoin-65134c7e5f99-arm64-apple-darwin-unsigned.tar.gz
4bee904bebcc0cf5a02081497563661b6c3927219e60e010694a9f4b2abf9e38  guix-build-65134c7e5f99/output/arm64-apple-darwin/bitcoin-65134c7e5f99-arm64-apple-darwin-unsigned.zip
e051ec06ccde1de606888e5a4d13764ccdd2aa1e7d9441d68e114ea3592195fe  guix-build-65134c7e5f99/output/dist-archive/bitcoin-65134c7e5f99.tar.gz
5b09df6197915666a387b68bf3a7755d0ec6e9472fc4cdd03405e44395d32d94  guix-build-65134c7e5f99/output/powerpc64-linux-gnu/SHA256SUMS.part
3a0febf69d84c2bbe3309f0fb5de5d03edbad06d02432e36efc9bda8a9b6b1ce  guix-build-65134c7e5f99/output/powerpc64-linux-gnu/bitcoin-65134c7e5f99-powerpc64-linux-gnu-debug.tar.gz
8ebe707831982e17fa27a06af9347c0673c3e8d1e6e677a770cf899533270123  guix-build-65134c7e5f99/output/powerpc64-linux-gnu/bitcoin-65134c7e5f99-powerpc64-linux-gnu.tar.gz
53127892268ff5d9f477de376d8b571bab2cdb7bb36c5f164c243775fb79c349  guix-build-65134c7e5f99/output/riscv64-linux-gnu/SHA256SUMS.part
bbbb8912ebcdf3c1212757d1e45920e25f589cfc9063483cf304c6ee5c32782e  guix-build-65134c7e5f99/output/riscv64-linux-gnu/bitcoin-65134c7e5f99-riscv64-linux-gnu-debug.tar.gz
2b243d05774a7ea5f25fe3b836062c0554756cbd35ce451dede48b547782f5a1  guix-build-65134c7e5f99/output/riscv64-linux-gnu/bitcoin-65134c7e5f99-riscv64-linux-gnu.tar.gz
66afccee5ff0632c287af0e1db159d444a46e46d4d95166c68c5926afb468179  guix-build-65134c7e5f99/output/x86_64-apple-darwin/SHA256SUMS.part
6e1e4adff095097df241a493bbdc4a590fd83a6157791ae39fb57d99f7479f15  guix-build-65134c7e5f99/output/x86_64-apple-darwin/bitcoin-65134c7e5f99-x86_64-apple-darwin-codesigning.tar.gz
c87beeb30256230c02569aa65c4623b6931b481e9b8a51adca89be6f2ea9e964  guix-build-65134c7e5f99/output/x86_64-apple-darwin/bitcoin-65134c7e5f99-x86_64-apple-darwin-unsigned.tar.gz
150b416cf9112afee5c8d8b8c399b3074f2c126a0f4d55d12df032ecf05db23e  guix-build-65134c7e5f99/output/x86_64-apple-darwin/bitcoin-65134c7e5f99-x86_64-apple-darwin-unsigned.zip
2795f17576ffac773fa094e3a610663583080629cc2043e8a40a2c4cf7c83bec  guix-build-65134c7e5f99/output/x86_64-linux-gnu/SHA256SUMS.part
2a9ef15547c143b4be2781e398f469a0a1c04822312e3d252bf5ced4a15e5a3d  guix-build-65134c7e5f99/output/x86_64-linux-gnu/bitcoin-65134c7e5f99-x86_64-linux-gnu-debug.tar.gz
9e95a377d89ac10733678dd9482e230aba88fcff162f160f3f1da46dcb177f54  guix-build-65134c7e5f99/output/x86_64-linux-gnu/bitcoin-65134c7e5f99-x86_64-linux-gnu.tar.gz
e5b9f32aa1589cb56672d2e0ae20d8e396ab2bc54dcfe3fea3bb2ab2faf3b768  guix-build-65134c7e5f99/output/x86_64-w64-mingw32/SHA256SUMS.part
1eed3bf1fb9053b1a5fee4447fcbb5e999992d6f29ea7c518581cddc15c06e1f  guix-build-65134c7e5f99/output/x86_64-w64-mingw32/bitcoin-65134c7e5f99-win64-codesigning.tar.gz
658b17a936192ac454bc0bba5c3de25b3d8aea335a8b810a19d661c7545e0ef4  guix-build-65134c7e5f99/output/x86_64-w64-mingw32/bitcoin-65134c7e5f99-win64-debug.zip
f0aa03aa664b3198092a7ff908dd326233daebc13ec1f74741e386aa8fba9c6a  guix-build-65134c7e5f99/output/x86_64-w64-mingw32/bitcoin-65134c7e5f99-win64-setup-unsigned.exe
21e9d4a1e5528d0d0cdc34b0aabb54d887f4b3d3d2f092d5b0c516de0f4c5f9a  guix-build-65134c7e5f99/output/x86_64-w64-mingw32/bitcoin-65134c7e5f99-win64-unsigned.zip

fanquake · 2026-02-09T13:24:38Z

Guix Build (x86_64):

d763a6657762eb0c77192c722c48bdd57473f5aa9cd12c3ac4e88fe509fbf130  guix-build-65134c7e5f99/output/aarch64-linux-gnu/SHA256SUMS.part
cebab577dd7a29ed13e20c6f3996062fd51caa9af33b15170094b1708318e770  guix-build-65134c7e5f99/output/aarch64-linux-gnu/bitcoin-65134c7e5f99-aarch64-linux-gnu-debug.tar.gz
ac0bbeeba7cfcc3618fc8e0f745747cace8505d1d7d23568d5707bdd5911897e  guix-build-65134c7e5f99/output/aarch64-linux-gnu/bitcoin-65134c7e5f99-aarch64-linux-gnu.tar.gz
553a97634cae34da03f4c2d4173b38cad8a40fc2562b777faffbfbb624dbe245  guix-build-65134c7e5f99/output/arm-linux-gnueabihf/SHA256SUMS.part
ea8826e63a9d8ecaf71249019a33932ab58497dd1b3c11a936cf94ee55727d51  guix-build-65134c7e5f99/output/arm-linux-gnueabihf/bitcoin-65134c7e5f99-arm-linux-gnueabihf-debug.tar.gz
689235f63a2d80642225963d70cb5b902664a80066e2d61131d9345d5cd83ab2  guix-build-65134c7e5f99/output/arm-linux-gnueabihf/bitcoin-65134c7e5f99-arm-linux-gnueabihf.tar.gz
037fb650bf5f5c727e9577e0ff5072e32bd2b448fac2fdc23dba34fbc539e6f0  guix-build-65134c7e5f99/output/arm64-apple-darwin/SHA256SUMS.part
eb29f6eb0f738a9a53d76811e2fb66b90c4fa8df4cb661c30c25527157106d7e  guix-build-65134c7e5f99/output/arm64-apple-darwin/bitcoin-65134c7e5f99-arm64-apple-darwin-codesigning.tar.gz
b8ea38b5ebd7a115eb7b08ea1343dc936e45ff29db0b14aacdc8a9d38a5d0eb8  guix-build-65134c7e5f99/output/arm64-apple-darwin/bitcoin-65134c7e5f99-arm64-apple-darwin-unsigned.tar.gz
4bee904bebcc0cf5a02081497563661b6c3927219e60e010694a9f4b2abf9e38  guix-build-65134c7e5f99/output/arm64-apple-darwin/bitcoin-65134c7e5f99-arm64-apple-darwin-unsigned.zip
e051ec06ccde1de606888e5a4d13764ccdd2aa1e7d9441d68e114ea3592195fe  guix-build-65134c7e5f99/output/dist-archive/bitcoin-65134c7e5f99.tar.gz
5b09df6197915666a387b68bf3a7755d0ec6e9472fc4cdd03405e44395d32d94  guix-build-65134c7e5f99/output/powerpc64-linux-gnu/SHA256SUMS.part
3a0febf69d84c2bbe3309f0fb5de5d03edbad06d02432e36efc9bda8a9b6b1ce  guix-build-65134c7e5f99/output/powerpc64-linux-gnu/bitcoin-65134c7e5f99-powerpc64-linux-gnu-debug.tar.gz
8ebe707831982e17fa27a06af9347c0673c3e8d1e6e677a770cf899533270123  guix-build-65134c7e5f99/output/powerpc64-linux-gnu/bitcoin-65134c7e5f99-powerpc64-linux-gnu.tar.gz
53127892268ff5d9f477de376d8b571bab2cdb7bb36c5f164c243775fb79c349  guix-build-65134c7e5f99/output/riscv64-linux-gnu/SHA256SUMS.part
bbbb8912ebcdf3c1212757d1e45920e25f589cfc9063483cf304c6ee5c32782e  guix-build-65134c7e5f99/output/riscv64-linux-gnu/bitcoin-65134c7e5f99-riscv64-linux-gnu-debug.tar.gz
2b243d05774a7ea5f25fe3b836062c0554756cbd35ce451dede48b547782f5a1  guix-build-65134c7e5f99/output/riscv64-linux-gnu/bitcoin-65134c7e5f99-riscv64-linux-gnu.tar.gz
66afccee5ff0632c287af0e1db159d444a46e46d4d95166c68c5926afb468179  guix-build-65134c7e5f99/output/x86_64-apple-darwin/SHA256SUMS.part
6e1e4adff095097df241a493bbdc4a590fd83a6157791ae39fb57d99f7479f15  guix-build-65134c7e5f99/output/x86_64-apple-darwin/bitcoin-65134c7e5f99-x86_64-apple-darwin-codesigning.tar.gz
c87beeb30256230c02569aa65c4623b6931b481e9b8a51adca89be6f2ea9e964  guix-build-65134c7e5f99/output/x86_64-apple-darwin/bitcoin-65134c7e5f99-x86_64-apple-darwin-unsigned.tar.gz
150b416cf9112afee5c8d8b8c399b3074f2c126a0f4d55d12df032ecf05db23e  guix-build-65134c7e5f99/output/x86_64-apple-darwin/bitcoin-65134c7e5f99-x86_64-apple-darwin-unsigned.zip
2795f17576ffac773fa094e3a610663583080629cc2043e8a40a2c4cf7c83bec  guix-build-65134c7e5f99/output/x86_64-linux-gnu/SHA256SUMS.part
2a9ef15547c143b4be2781e398f469a0a1c04822312e3d252bf5ced4a15e5a3d  guix-build-65134c7e5f99/output/x86_64-linux-gnu/bitcoin-65134c7e5f99-x86_64-linux-gnu-debug.tar.gz
9e95a377d89ac10733678dd9482e230aba88fcff162f160f3f1da46dcb177f54  guix-build-65134c7e5f99/output/x86_64-linux-gnu/bitcoin-65134c7e5f99-x86_64-linux-gnu.tar.gz
e5b9f32aa1589cb56672d2e0ae20d8e396ab2bc54dcfe3fea3bb2ab2faf3b768  guix-build-65134c7e5f99/output/x86_64-w64-mingw32/SHA256SUMS.part
1eed3bf1fb9053b1a5fee4447fcbb5e999992d6f29ea7c518581cddc15c06e1f  guix-build-65134c7e5f99/output/x86_64-w64-mingw32/bitcoin-65134c7e5f99-win64-codesigning.tar.gz
658b17a936192ac454bc0bba5c3de25b3d8aea335a8b810a19d661c7545e0ef4  guix-build-65134c7e5f99/output/x86_64-w64-mingw32/bitcoin-65134c7e5f99-win64-debug.zip
f0aa03aa664b3198092a7ff908dd326233daebc13ec1f74741e386aa8fba9c6a  guix-build-65134c7e5f99/output/x86_64-w64-mingw32/bitcoin-65134c7e5f99-win64-setup-unsigned.exe
21e9d4a1e5528d0d0cdc34b0aabb54d887f4b3d3d2f092d5b0c516de0f4c5f9a  guix-build-65134c7e5f99/output/x86_64-w64-mingw32/bitcoin-65134c7e5f99-win64-unsigned.zip

theuni · 2026-02-10T17:33:16Z

re-ACK 65134c7

This was necessary to properly test #34495 and #34496.

willcl-ark · 2026-02-11T15:30:01Z

Concept ACK.

Just bumped into Boost::headers missing for bitcoin_ipc yesterday when testing switching out brew installs in the macos CI jobs in this branch. Seems like as brew include dir is in the default compiler search path this slipped by unnoticed.

janb84 · 2026-02-11T15:51:58Z

my guix build on nixos 25.11 aarch64 crashes for: riscv64-linux-gnu

Details

g++  -fno-PIE -c  -DIN_GCC_FRONTEND -g -O2     -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE   -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Wconditionally-supported -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings   -DHAVE_CONFIG_H -fno-PIE -I. -I. -I../../gcc-14.3.0/gcc -I../../gcc-14.3.0/gcc/. -I../../gcc-14.3.0/gcc/../include  -I../../gcc-14.3.0/gcc/../libcpp/include -I../../gcc-14.3.0/gcc/../libcody  -I../../gcc-14.3.0/gcc/../libdecnumber -I../../gcc-14.3.0/gcc/../libdecnumber/dpd -I../libdecnumber -I../../gcc-14.3.0/gcc/../libbacktrace   -o cc1plus-checksum.o -MT cc1plus-checksum.o -MMD -MP -MF ./.deps/cc1plus-checksum.TPo cc1plus-checksum.cc
g++ -no-pie -Wl,-z,now   -g -O2     -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE   -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute -Wconditionally-supported -Woverloaded-virtual -pedantic -Wno-long-long -Wno-variadic-macros -Wno-overlength-strings   -DHAVE_CONFIG_H -no-pie -Wl,-z,now -static-libstdc++ -static-libgcc  -o cc1plus \
      cp/cp-lang.o c-family/stub-objc.o cp/call.o cp/class.o cp/constexpr.o cp/constraint.o cp/coroutines.o cp/cp-gimplify.o cp/cp-objcp-common.o cp/cp-ubsan.o cp/cvt.o cp/contracts.o cp/cxx-pretty-print.o cp/decl.o cp/decl2.o cp/dump.o cp/error.o cp/except.o cp/expr.o cp/friend.o cp/init.o cp/lambda.o cp/lex.o cp/logic.o cp/mangle.o cp/mapper-client.o cp/mapper-resolver.o cp/method.o cp/module.o cp/name-lookup.o cp/optimize.o cp/parser.o cp/pt.o cp/ptree.o cp/rtti.o cp/search.o cp/semantics.o cp/tree.o cp/typeck.o cp/typeck2.o cp/vtable-class-hierarchy.o attribs.o c-family/c-common.o c-family/c-cppbuiltin.o c-family/c-dump.o c-family/c-format.o c-family/c-gimplify.o c-family/c-indentation.o c-family/c-lex.o c-family/c-omp.o c-family/c-opts.o c-family/c-pch.o c-family/c-ppoutput.o c-family/c-pragma.o c-family/c-pretty-print.o c-family/c-semantics.o c-family/c-ada-spec.o c-family/c-ubsan.o c-family/known-headers.o c-family/c-attribs.o c-family/c-warn.o c-family/c-spellcheck.o glibc-c.o cc1plus-checksum.o libbackend.a main.o libcommon-target.a libcommon.a ../libcpp/libcpp.a ../libdecnumber/libdecnumber.a ../libcody/libcody.a  \
	libcommon.a ../libcpp/libcpp.a   ../libbacktrace/.libs/libbacktrace.a ../libiberty/libiberty.a ../libdecnumber/libdecnumber.a  -lisl -lmpc -lmpfr -lgmp -rdynamic  -lz 
collect2: fatal error: ld terminated with signal 9 [Killed]
compilation terminated.
make[2]: *** [../../gcc-14.3.0/gcc/cp/Make-lang.in:145: cc1plus] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/tmp/guix-build-gcc-cross-riscv64-linux-gnu-14.3.0.drv-0/build/gcc'
make[1]: *** [Makefile:4695: all-gcc] Error 2
make[1]: Leaving directory '/tmp/guix-build-gcc-cross-riscv64-linux-gnu-14.3.0.drv-0/build'
make: *** [Makefile:1059: all] Error 2
error: in phase 'build': uncaught exception:
%exception #<&invoke-error program: "make" arguments: ("-j" "9" "FLAGS_FOR_TARGET=-B/gnu/store/rhqlqkgrvfkmhgp593yqyq3q8sdkp6id-glibc-cross-riscv64-linux-gnu-2.31/lib" "CFLAGS=-g0 -O2") exit-status: 2 term-signal: #f stop-signal: #f> 
phase `build' failed after 364.4 seconds
command "make" "-j" "9" "FLAGS_FOR_TARGET=-B/gnu/store/rhqlqkgrvfkmhgp593yqyq3q8sdkp6id-glibc-cross-riscv64-linux-gnu-2.31/lib" "CFLAGS=-g0 -O2" failed with status 2
build process 11 exited with status 256

tried this 3 times, 2 clean starts (restore vm) and 1 restart of the build. On this PR 3 other hosts builded before crash. This nixos instance builds other PR's fine.

fanquake · 2026-02-11T15:55:30Z

my guix build on nixos 25.11 aarch64 crashes for:

This very much looks like resource exhaustion/OOM. Note that it's dying while compiling gcc-cross-riscv64-linux-gnu-14.3.0, so any changes in this PR, shouldn't be related.

janb84 · 2026-02-11T16:41:09Z

my guix build on nixos 25.11 aarch64 crashes for:

This very much looks like resource exhaustion/OOM. Note that it's dying while compiling gcc-cross-riscv64-linux-gnu-14.3.0, so any changes in this PR, shouldn't be related.

Retested with increased available memory to ~16GB (+5GB) and it builds successful. Thanks

fanquake · 2026-02-11T17:41:28Z

ACK 65134c7

hebasto · 2026-02-12T10:34:37Z

depends/packages/boost.mk

  $(package)_config_opts += -DBUILD_TESTING=OFF
  $(package)_config_opts += -DCMAKE_DISABLE_FIND_PACKAGE_ICU=ON
+  # Install to a unique path to prevent accidental inclusion via other dependencies' -I flags.
+  $(package)_config_opts += -DCMAKE_INSTALL_INCLUDEDIR=$(package)/include


Apparently, this breaks builds on NetBSD due to a hack introduced in 5a5ddbd.

79c934b cmake: Fix NetBSD-specific workaround for Boost (Hennadii Stepanov) Pull request description: The recently merged #34143 broke builds with depends on NetBSD due to a workaround introduced in 5a5ddbd. The upstream [bug](https://gnats.netbsd.org/59856) has been fixed, and the entire workaround can be removed once the fixed Boost package becomes generally available. However, it seems prudent to amend the workaround now to have it workable in the 31.0 release. Here are CI runs: - broken: https://github.com/hebasto/bitcoin-core-nightly/actions/runs/21933683654 - fixed: https://github.com/hebasto/bitcoin-core-nightly/actions/runs/21933683654 ACKs for top commit: fanquake: ACK 79c934b Tree-SHA512: 360e4943fbedc7692fa2eba48f3375fc927d3aaef178dec6c0fafd3addfad0c89db9d1fe88e214313ebd285584bf8dc7d7b0a3a41d905c7f3d28293aa743405a

…9c7364ac567 d9c7364ac567 Merge bitcoin/bitcoin#34141: miniscript: Use Func and Expr when parsing keys, hashes, and locktimes 6c8d628b74aa Merge bitcoin-core/gui#931: Release: Update `src/qt/locale/bitcoin_en.xlf` after string freeze fa194fca8e7b Merge bitcoin/bitcoin#34622: test: assert_debug_log timeouts follow-up d907d65acd13 Merge bitcoin/bitcoin#29770: index: Check all necessary block data is available before starting to sync ce6898f9a803 Merge bitcoin/bitcoin#34605: build: define CMAKE_COMPILE_WARNING_AS_ERROR as a cache option a2fd558760ab Merge bitcoin/bitcoin#34572: cmake: Fix NetBSD-specific workaround for Boost ef987683dc51 qt: Update src/qt/locale/bitcoin_en.xlf after string freeze cb3473a6804f Merge bitcoin/bitcoin#34568: mining: Break compatibility with existing IPC mining clients 641a1954f7ae Merge bitcoin/bitcoin#34633: Revert "ci: Treat SHA1 LLVM signing key as warning" 3574905cecec Revert "ci: Treat SHA1 LLVM signing key as warning" 1a54886b639a Merge bitcoin/bitcoin#24539: Add a "tx output spender" index fa4424fd98b6 test: Fixup assert_debug_log timeouts in feature_config_args.py faed837f274a test: Add missing syncwithvalidationinterfacequeue ee2065fdeaca Merge bitcoin/bitcoin#34165: coins: don't mutate main cache when connecting block 96bec216ec34 Merge bitcoin/bitcoin#34549: net: reduce log level for PCP/NAT-PMP NOT_AUTHORIZED failures 76de2f8e55f3 Merge bitcoin/bitcoin#34571: test: Fix intermittent issues in feature_assumevalid.py c808dfbbdcea Merge bitcoin/bitcoin#34329: rpc,net: Add private broadcast RPCs 739f75c0980e Merge bitcoin/bitcoin#33512: coins: use dirty entry count for flush warnings and disk space checks 02c83fef8431 Merge bitcoin/bitcoin#34577: http: fix submission during shutdown race 0b96b9c600e0 Minimize mempool lock, sync txo spender index only when and if needed d0998cbe348e Merge bitcoin/bitcoin#33199: fees: enable `CBlockPolicyEstimator` return sub 1 sat/vb fee rate estimates 37e449dcc72c Merge bitcoin/bitcoin#34512: rpc: add coinbase_tx field to getblock 097c18239b58 Merge bitcoin/bitcoin#34385: subprocess: Fix `-Wunused-private-field` when building with clang-cl on Windows 910bd1c964b6 Merge bitcoin/bitcoin#34582: rpc: Properly parse -rpcworkqueue/-rpcthreads e0463b4e8c25 rpc: add coinbase_tx field to getblock 5a8a427610ed Merge bitcoin/bitcoin#32745: scripted-diff: Update DeriveType enum values to mention ranged derivations 3d82ec5bdd01 Add a "tx output spender" index 8ee24d764a28 Merge bitcoin/bitcoin#34604: guix: remove double export of `TZ` 4933d1fbbada Merge bitcoin/bitcoin#28792: build: Embedded ASMap [3/3]: Build binary dump header file 6d482b22de15 Merge bitcoin/bitcoin#32138: wallet, rpc: remove settxfee and paytxfee 726b3663cc8e http: properly respond to HTTP request during shutdown 241ad5853bca Merge bitcoin-core/gui#929: Use plurals where necessary a849b7e1ff35 Merge bitcoin-core/gui#928: Replace three dots with ellipsis 9e4567b17a28 Merge bitcoin/bitcoin#34581: test: Set assert_debug_log timeout to 0 655b9d12ee17 Merge bitcoin/bitcoin#32950: validation: remove BLOCK_FAILED_CHILD 2706758dc38c Merge bitcoin/bitcoin#34349: util: Remove brittle and confusing sp::Popen(std::string) 59e10a5463dc Merge bitcoin/bitcoin#34023: Optimized SFL cluster linearization 59d24bd5dd2a threadpool: make Submit return Expected instead of throwing fb3e1bf9c977 test: check LoadBlockIndex correctly recomputes invalidity flags 29740c06ac53 validation: remove BLOCK_FAILED_MASK b5b2956bda32 validation: reset BLOCK_FAILED_CHILD to BLOCK_FAILED_VALID when loading from disk 37bc20785278 validation: stop using BLOCK_FAILED_CHILD 120c631e1689 refactor: use clearer variables in InvalidateBlock() fa4cb96bdec2 test: Set assert_debug_log timeout to 0 c2fcf2506973 clusterlin: inline GetReachable into Deactivate (optimization) d90f98ab4aaa clusterlin: inline UpdateChunk into (De)Activate (optimization) b684f954bbfc clusterlin: unidirectional MakeTopological initially (optimization) 1daa600c1ca8 clusterlin: track suboptimal chunks (optimization) 63b06d5523f1 clusterlin: keep track of active children (optimization) ae16485aa94d clusterlin: special-case self-merges (optimization) 3221f1a074e7 clusterlin: make MergeSequence take SetIdx (simplification) 7194de3f7c53 clusterlin: precompute reachable sets (optimization) 6f898dbb8bfa clusterlin: simplify PickMergeCandidate (optimization) dcf458ffb99c clusterlin: split up OptimizeStep (refactor) cbd684a4713d clusterlin: abstract out functions from MergeStep (refactor) b75574a6531e clusterlin: improve TxData::dep_top_idx type (optimization) 73cbd15d4572 clusterlin: get rid of DepData (optimization) 7c6f63a8a9dc clusterlin: pool SetInfos (preparation) 20e2f3e96df3 scripted-diff: rename _rep -> _idx in SFL 268fcb6a53ec clusterlin: add more Assumes and sanity checks (tests) d69c9f56ea96 clusterlin: count chunk deps without loop (optimization) f66fa69ce008 clusterlin: split tx/chunk dep counting (preparation) 900e45977889 clusterlin: avoid depgraph argument in SanityCheck (cleanup) 666b37970f15 clusterlin: fix type to count dependencies a7c29df0e5ac Merge bitcoin/bitcoin#34552: fees: refactor: separate feerate format from fee estimate mode 231dd04b8dcb build: define CMAKE_COMPILE_WARNING_AS_ERROR as a cache option fa48d421636c test: Stricter unit test fa626bd14341 util: Remove brittle and confusing sp::Popen(std::string) fd06157d1465 test: Add coverage for restarted node without any block sync 3d7ab7ecb7df rpc, test: Address feedback from #29668 312919c9dd5d test: Indices can not start based on block data without undo data a9a3b29dd687 index: Check availability of undo data for indices c8c9c1e61759 Merge bitcoin/bitcoin#34383: ci: remove commit count limit from `test-each-commit` and fail fast 62e378584e77 guix: don't export TZ twice badcf1c68dbf guix: fix typo in guix-codesign 8a050b9cb68a Merge bitcoin/bitcoin#34575: test: Avoid empty errmsg in JSONRPCException 746d8cddc191 qt: Use plurals where necessary fa5672dcafa1 refactor: [gui] Use SettingTo<int64_t> over deprecated SettingToInt 35e6444fdc40 Merge bitcoin/bitcoin#34570: doc: update Windows MSVC build guide to utilize winget to install build requirements d159b103987f doc: update Windows MSVC build guide to utilize WinGet to install apps afea2af13913 net: reduce log level for PCP/NAT-PMP NOT_AUTHORIZED failures fac3ecaf69d6 rpc: Properly parse -rpcworkqueue/-rpcthreads faee36f63b5f util: Add SettingTo<Int>() and GetArg<Int>() 6df4a045f797 qt: Replace three dots with ellipsis 211111b8048d test: Avoid empty errmsg in JSONRPCException b65ff0e5a1fd Merge bitcoin/bitcoin#34548: ci: Add and use ci-windows-cross.py helper 03e5f063b5c0 Merge bitcoin/bitcoin#34559: ci: split vcpkg tools cache into restore/save 84e826ddc1cf Merge bitcoin/bitcoin#34511: test: fully reset the state of CConnman in tests 309c51d89dfc Merge bitcoin/bitcoin#34546: kernel: Avoid duplicating symbols in the kernel library 24f93c9af7f6 release note 331a5279d277 wallet, rpc:remove settxfee and paytxfee eafd530d2032 kernel: avoid potential duplicate object in shared library/binary 24c3b4701003 build: add kernel-specific warnings cae6d895f8a8 fuzz: add target for CoinsViewOverlay 86eda88c8e48 fuzz: move backend mutating block to end of coins_view 89824fb27b22 fuzz: pass coins_view_cache to TestCoinsView in coins_view 73e99a596655 coins: don't mutate main cache when connecting block 67c0d1798e61 coins: introduce CoinsViewOverlay 69b01af0eb90 coins: add PeekCoin() f700609e8ada doc: Release notes for mining IPC interface bump 79c934b51cdc cmake: Fix NetBSD-specific workaround for Boost fa90d44a2283 test: Fix intermittent issues in feature_assumevalid.py 07b924775e4f Merge bitcoin/bitcoin#34427: lint: Flatten lint image entry points 9453c153612a ipc mining: break compatibility with existing clients (version bump) 70de5cc2d205 ipc mining: pass missing context to BlockTemplate methods (incompatible schema change) 2278f017afad ipc mining: remove deprecated methods (incompatible schema change) c6638fa7c5e9 ipc mining: provide default option values (incompatible schema change) a4603ac77412 ipc mining: declare constants for default field values ff995b50cf9e ipc test: add workaround to block_reserved_weight exception test b970cdf20fce test framework: expand expected_stderr, expected_ret_code options df53a3e5ec87 rpc refactor: stop using deprecated getCoinbaseCommitment method 0b4cd08fcd22 Merge bitcoin/bitcoin#33965: mining: fix -blockreservedweight shadows IPC option 2a1d0db7994e doc: Mention private broadcast RPCs in release notes c3378be10b0a test: Cover abortprivatebroadcast in p2p_private_broadcast 557260ca14ac rpc: Add abortprivatebroadcast 15dff452eb61 test: Cover getprivatebroadcastinfo in p2p_private_broadcast 996f20c18af0 rpc: Add getprivatebroadcastinfo 5e64982541f3 net: Add PrivateBroadcast::GetBroadcastInfo 55c49ff8f4b1 Merge bitcoin/bitcoin#34143: build: Prevent system header fallback and include path pollution c134b1a4bc35 Merge bitcoin/bitcoin#34257: txgraph: deterministic optimal transaction order 4a05825a3f39 Merge bitcoin/bitcoin#33689: http: replace WorkQueue and single threads handling for ThreadPool c1355493e2c2 refactor: fees: split fee rate format from fee estimate mode c413cf12c5c6 ci: Split vcpkg tools cache into restore/save 337fef9f2f68 Merge bitcoin/bitcoin#34554: build: avoid exporting secp256k1 symbols 922ebf96ed66 refactor: move-only: move `FeeEstimateMode` enum to `util/fees.h` cb1798000c25 Merge bitcoin/bitcoin#33861: build: Bump VS minimum supported version to 18.3 7640863a0fbe Merge bitcoin/bitcoin#34555: doc: archive release notes for v29.3 d29bc5e6dd71 doc: archive release notes for v29.3 fd625d84ae9e Merge bitcoin/bitcoin#34539: test: Fixup TODO comment in feature_dbcrash.py; remove unnecessary sleep 6777314310bc Merge bitcoin/bitcoin#34551: ci: Extend diff context for clang-format 452c743951fa refactor: Remove workaround for resolved MSVC bug 7164a0cab650 build: Bump VS minimum supported version to 18.3 2ccfdb582b64 build: avoid exporting secp256k1 symbols fa8c89511d83 Fixup TODO comment in feature_dbcrash.py; remove unnecessary sleep f8d2f30bf37d ci: Extend diff context for clang-format 91a8e9b549e9 Merge bitcoin-core/gui#807: refactor: interfaces, make 'createTransaction' less error-prone 573bb542be80 net: Store recipient node address in private broadcast fa13b13239e5 ci: [refactor] Use pathlib over os.path fa2719ab1ba2 ci: [refactor] Move run_unit_tests to ci-windows-cross.py fa99ba5f14d4 ci: Set PREVIOUS_RELEASES_DIR env var in ci-windows-cross.py fa4a1cab6c17 ci: Move run_functional_tests into ci-windows-cross.py 1111108685ec ci: [refactor] Move pyzmq install and get_previous_releases into ci-windows-cross.py fac9c7bd6635 ci: [refactor] Move config.ini rewrite to ci-windows-cross.py faf738946668 ci: Move check_manifests step to ci-windows-cross.py fa674d55df57 ci: [refactor] Move print_version step into ci-windows-cross.py helper 6f113cb1847c txgraph: use fallback order to sort chunks (feature) 0a3351947e73 txgraph: use fallback order when linearizing (feature) fba004a3df02 txgraph: pass fallback_order to TxGraph (preparation) 941c432a4637 txgraph test: subclass TxGraph::Ref like mempool does (preparation) 39d0052cbf47 clusterlin: make optimal linearizations deterministic (feature) 8bfbba32077c txgraph: sort distinct-cluster chunks by equal-feerate-prefix size (feature) e0bc73ba9270 clusterlin: sort tx in chunk by feerate and size (feature) 6c1bcb2c7c1a txgraph: clear cluster's chunk index in ~Ref (preparation) 7427c7d09830 txgraph: update chunk index on Compact (preparation) 3ddafceb9afd txgraph: initialize Ref in AddTransaction (preparation) 64294c89094d Merge bitcoin/bitcoin#34500: ci: Print verbose Windows CI build failure 5f6bfa3649c3 Merge bitcoin/bitcoin#34057: test: add tests for cluster chunks 6ca7782db9b4 Merge bitcoin/bitcoin#34523: doc: Clarify why performance-move-const-arg.CheckTriviallyCopyableMove=false 44afed4cd970 Merge bitcoin/bitcoin#34524: refactor: [rpc] Remove confusing and brittle integral casts (take 2) 3764746404a8 Merge bitcoin/bitcoin#34241: test: Check that interrupt results in EXIT_SUCCESS 18f11695c755 validation: don't update BLOCK_FAILED_VALID to BLOCK_FAILED_CHILD in InvalidateBlock acefdce08311 Merge bitcoin/bitcoin#34469: consensus/test/doc: cover errors in `CheckTxInputs` with unit tests 7e5e0b20ea3e Merge bitcoin/bitcoin#32773: cmake: Create subdirectories in build tree in advance fa90277d22e1 ci: Use ubuntu-slim for [meta] runners fa9627af9f89 ci: Rely on cmake --preset toolchain file fa3f89acaa7a ci: Add check_manifests to ci-windows.py 1111079a16b9 ci: Add run_tests step to ci-windows.py 6d625af2831b Merge bitcoin/bitcoin#32621: contrib: utxo_to_sqlite.py: add option to store txid/spk as BLOBs afb1bc120ecc validation: Use dirty entry count in flush warnings and disk space checks b413491a1cdd coins: Keep track of number of dirty entries in `CCoinsViewCache` 7e52b1b945c4 fuzz: call `EmplaceCoinInternalDANGER` as well in `SimulationTest` 8f0e1f6540be Merge bitcoin/bitcoin#34465: refactor: separate log generation from log handling b2805eec35ce Merge bitcoin/bitcoin#34528: test: Fix intermittent failure in `feature_assumevalid.py` by ensuring invalid block was processed before checking debug.log 72030efd4b83 Merge bitcoin/bitcoin#34525: Release: Prepare "Open Transifex translations for v31.0" step fe0b1513a7c5 test: add a test for txgraph staging ef253a9d3d16 test: add block builder tests for txgraph 4a1ac31e97c2 test: add a chunk test for txgraph b623fab1ba87 mining: enforce minimum reserved weight for IPC d3e49528d479 mining: fix -blockreservedweight shadows IPC option 418b7995ddfb test: have mining template helpers return None 54bd49c7e3c7 Merge bitcoin/bitcoin#34452: test: split interface_ipc.py 3b39a8aeb4c6 Merge bitcoin/bitcoin#34483: refactor: Use SpanReader over DataStream 6f68e0c8b760 Merge bitcoin/bitcoin#34181: refactor: [p2p] Make ProcessMessage private again, Use references when non-null 4c0d4f6f93f3 refactor: interfaces, make 'createTransaction' less error-prone e2c3ec9bf412 refactor: move CreatedTransactionResult to types.h 45372175c35b gui: remove AmountWithFeeExceedsBalance error special case d88997b809db Merge bitcoin/bitcoin#34299: wallet: remove PreSelectedInputs and re-activate "AmountWithFeeExceedsBalance" error b73a62f667d0 test: Ensure invalid block was processed before checking debug.log 633d1831199a test: misc interface_ipc_mining.py improvements 52ccd9215e67 test: split interface_ipc_mining.py into subtests 4e49fa2a6884 test: add interface_ipc_mining.py 01a1ae889e5a test: move IPC helpers to ipc_util.py 28160c1e3dc1 Merge bitcoin/bitcoin#34421: ci: add Chimera Linux LTO config 576f89202798 qt: Update the `src/qt/locale/bitcoin_en.xlf` translation source file 4b9f5beafe9e Update Transifex slug for 31.x 46e1288df2b4 Merge bitcoin/bitcoin#34498: iwyu: Fix patch to prefer `<cstdint>` fa6801366d76 refactor: [rpc] Remove confusing and brittle integral casts (take 2) d79249d2799e ci: add chimera Linux LTO CI job 48161f6a0503 wallet: introduce "tx amount exceeds balance when fees are included" error b7fa609ed175 wallet: remove PreSelectedInputs 7819da2c1643 walllet: use CoinsResult instead of PreSelectedInputs 0cd309c75e58 Merge bitcoin/bitcoin#34492: ci: Drop valgrind fuzz from GHA matrix fa561682ce40 ci: [refactor] Add .github/ci-windows.py prepare_tests step fa3e607c6dfb ci: Print verbose Windows CI build failure 4444808dd3a7 ci: [refactor] Add .github/ci-windows.py build step fabdd4e82342 ci: Refactor Windows CI into script fa88ac3f4f9b doc: Clarify why performance-move-const-arg.CheckTriviallyCopyableMove=false fa0677d13119 refactor: Use SpanReader over DataStream e5474079f179 wallet: introduce GetAppropriateTotal() in CoinsResult d8ea921d0140 wallet: correctly reserve in CoinsResult::All() 7072d825e39d wallet: ensure COutput added in set are unique fefa3be782ea wallet: fix, make 'total_effective_amount' optional actually optional 9ec1ae0e98c0 Merge bitcoin/bitcoin#34437: rpc: `uptime` should begin on application start d692e0722813 Merge bitcoin/bitcoin#32894: FUZZ: Test that BnB finds best solution 28d860788286 Merge bitcoin/bitcoin#34504: build: replace `WERROR` with `CMAKE_COMPILE_WARNING_AS_ERROR` ad1940a006b6 Merge bitcoin/bitcoin#34517: drop my key from trusted-keys 322c4ec4422a build: replace WERROR with CMAKE_COMPILE_WARNING_AS_ERROR 65134c7e5f99 depends: Prefix include path for headers-only `systemtap` package 94a692b6aa09 cmake: Add missed `USDT::headers` b5375c44ed16 depends: Prefix include path for headers-only `boost` package d73378ffcca2 cmake: Add missed `Boost::headers` eb97250421d3 Merge bitcoin/bitcoin#34496: build: don't pass on boost dependency to kernel consumers 9d7694729481 Merge bitcoin/bitcoin#34464: Change BlockRequestAllowed() to take ref (minor refactor) 8966352df3fc doc: add release notes 704a09fe7187 test: ensure fee estimator provide fee rate estimate < 1 s/vb 243e48cf4933 fees: delete unused dummy field fc4fbda42af1 fees: bump fees file version b54dedcc8563 fees: reduce `MIN_BUCKET_FEERATE` to 100 2cb7e99deee1 test: also reset CConnman::m_private_broadcast in tests 41b9b76cce6a Merge bitcoin/bitcoin#34510: doc: fix broken bpftrace installation link 91b7c874e2b1 test: add ConnmanTestMsg convenience method Reset() 42ee31e80c99 doc: fix broken bpftrace installation link 54d039305823 FUZZ: Test that BnB finds best solution eb510f8678ba ci: fail fast in test-each-commit script 04c4d710087b ci: remove commit count limit from `test-each-commit` 4ae00e9a7183 Merge bitcoin/bitcoin#32636: Split `CWallet::Create()` into `CreateNew` and `LoadExisting` d4bc620ad8cf Merge bitcoin/bitcoin#34488: refactor: Small style and test fixups for bitcoinkernel eb3dbbaf30fc Merge bitcoin/bitcoin#34493: contrib: Remove valgrind suppression for bug 472219 1e64aeaaecc2 Merge bitcoin/bitcoin#34295: test: Improve STRICTENC/DERSIG unit tests b65a3d80093b iwyu: Fix patch to prefer `<cstdint>` a50d0b6720f3 build: don't pass on boost dependency to kernel consumers 3532e242134e Merge bitcoin/bitcoin#32748: fees: fix noisy flushing log fad9dd1a8891 test: kernel test fixups fabb58d42dc2 test: Use clang-tidy named args for create_chainman fa51594c5c0f refactor: Small style fixups in src/kernel/bitcoinkernel.cpp fa33acec89f0 Revert "valgrind: add suppression for bug 472219" 24699fec8422 doc: Add initial asmap data documentation bab085d282b1 ci: Use without embedded asmap build option in one ci job e53934422a29 doc: Expand documentation on asmap feature and tooling 6244212a5532 init, net: Implement usage of binary-embedded asmap data 6202b50fb900 build: Generate ip_asn.dat.h during build process 634cd60dc8f6 build: Add embedded asmap data faa4ab113cc9 ci: Drop valgrind fuzz from GHA matrix 02b5f6078d65 fees: make flushes log debug only b58eebf1520f Merge bitcoin/bitcoin#34470: Bump leveldb subtree and remove UB workaround in CI 8bb277c12373 Merge bitcoin/bitcoin#34481: Update secp256k1 subtree to latest master a4941132d311 Merge bitcoin/bitcoin#34461: ci: Print verbose build error message in test-each-commit fad7d86d8d17 ci: Remove unused workaround after leveldb subtree bump fabced56f650 Bump leveldb subtree be35408c5ad7 Merge bitcoin/bitcoin#34474: ci: update ccache to improve hitrate 2f2952c5f2e3 Squashed 'src/leveldb/' changes from cad64b151d..ab6c84e6f3 7528d18796a2 ci: show more verbose ccache stats 47c9297172b0 Merge bitcoin/bitcoin#32420: mining, ipc: omit dummy extraNonce from coinbase 4b53cbd69220 test: Test for musig() in various miniscript expressions ec0f47b15cb3 miniscript: Using Func and Expr when parsing keys, hashes, and locktimes 6fd780d4fbc4 descriptors: Increment key_exp_index in ParsePubkey(Inner) b12281bd86e2 miniscript: Use a reference to key_exp_index in KeyParser ce4c66eb7c5e test: Test that key expression indexes match key count 8c03318387f6 consensus/doc: explain `GetValueOut()` precondition 82ef92c8d006 consensus/doc: explain unreachable `bad-txns-fee-outofrange` check fad3eb395645 refactor: Use SpanReader over DataStream fa06e26764bb refactor: [qt] Use SpanReader to avoid two vector copies fabd4d2e2e3c refactor: Avoid UB in SpanReader::ignore 37cc2a2d953c logging: use util/log.h where possible 8799eb74406e Merge bitcoin/bitcoin#33878: refactor, docs: Embedded ASMap [2/3]: Refactor asmap internals and add documentation bb8e9e7c4c8d logging: Move message formatting to util/log.h 001f0a428e3a move-only: Move logging macros to util/log.h 94c0adf4e857 move-onlyish: Move logging levels to util/log.h 56d113cab034 move-only: move logging categories to logging/categories.h f5233f7e9827 move-only: Move SourceLocation to util/log.h fa20bc2ec275 refactor: Use empty() over eof() in the streams interface fa879db73528 test: Read debug log for self-checking comment d405713197f8 ci: use Alpine 3.23 1cee0e4cd3af ci: detect apk usage generally 1ed3de5a6d97 Update secp256k1 subtree to latest master 9d4c9b00356e Squashed 'src/secp256k1/' changes from 14e56970cb..57315a6985 9f8764c814ea Merge bitcoin/bitcoin#34475: ci: Treat SHA1 LLVM signing key as warning 3c8f5e48f710 ci: Treat SHA1 LLVM signing key as warning 5cb4cf9b428e Merge bitcoin/bitcoin#34036: contrib: update macOS SDK to Xcode-26.1.1-17B100 41034a032f0f Merge bitcoin/bitcoin#34396: fuzz: pull the latest FuzzedDataProvider.h from upstream 580e9eefe39f ci: bump CCACHE_MAXSIZE to 2G ff095839285d Merge bitcoin/bitcoin#34432: test: Turn ElapseSteady into SteadyClockContext 81e67d9aa134 Merge bitcoin/bitcoin#34179: refactor: Enable transparent lookup for setBlockIndexCandidates to remove const_cast ec70bead5e1e Merge bitcoin/bitcoin#34433: script: remove unused `SCRIPT_ERR_LAST` 08547ee1b06d Merge bitcoin/bitcoin#34443: validation: follow-up nits for lock-free `IsInitialBlockDownload()` 881ab4fc82fe support multiple block status checks in CheckBlockDataAvailability 232a2bce90a9 consensus/test: add out-of-range output unit tests for `CTransaction::GetValueOut` aa87aae14f9e consensus/test: add `MoneyRange` unit tests for `CheckTxInputs` 8bb77f348ef3 Merge bitcoin/bitcoin#34455: ci, iwyu: Fix warnings in `src/univalue` and treat them as errors 1bf384222323 ci, iwyu: Fix warnings in `src/univalue` and treat them as errors 3d180d3c7f1f Merge bitcoin/bitcoin#34462: util: Drop *BSD headers in `batchpriority.cpp` 1eed88a3ec65 Merge bitcoin/bitcoin#34460: iwyu: Update mappings 101daa41636a Merge bitcoin/bitcoin#34338: ci, iwyu: Fix warnings in `src/zmq` and treat them as errors dfb93646093f fuzz: pull latest FuzzedDataProvider.h from upstream 705705e5b195 Merge bitcoin/bitcoin#33701: test: add case where `TOTAL_TRIES` is exceeded yet solution remains 88f802983571 Merge bitcoin/bitcoin#34100: doc: Use multipath descriptors in descriptors.md and linked test 5ad94cf6b7eb Merge bitcoin/bitcoin#34381: script: return proper error for `CScriptNum` errors 4f85b05131bf Merge bitcoin/bitcoin#31713: miniscript refactor: Remove unique_ptr-indirection 1f8f7d477ae0 Change BlockRequestAllowed() to take ref 5d2707307e27 Merge bitcoin/bitcoin#34454: wallet: Rename `RecordType::DELETE` to `RecordType::DELETE_FLAG` 38fd85c676a0 http: replace WorkQueue and threads handling for ThreadPool c323f882ed38 fuzz: add test case for threadpool c528dd5f8ccc util: introduce general purpose thread pool 07af50f7896a util: Drop *BSD headers in `batchpriority.cpp` 4dfb6eef70d7 test: Add DERSIG tests to script_tests 884978f3894a test: Fix a STRICTENC test in script_tests 527e8ca7b545 test: Remove outdated comment in script_tests 516be10bb56d wallet: Rename `RecordType::DELETE` to `RecordType::DELETE_FLAG` bbbb78a4f28f ci: Print verbose build error message in test-each-commit 2222dadabbbd ci: [refactor] Allow overwriting check option in run helper 9c839aa9e3db iwyu: Document mappings for libc symbols 91824646c58a iwyu: Add temporary mapping to work around upstream bug 37de7d19107c iwyu: Drop backported mapping 01651324f4e5 Merge bitcoin/bitcoin#34434: miniscript: correct and_v() properties c7cf2b8f3aae Merge bitcoin/bitcoin#34445: fuzz: Use `__AFL_SHM_ID` for naming test directories 0d1d393877a7 Merge bitcoin/bitcoin#34429: test: Check that redundant verack message is ignored 23a2e3354edf Merge bitcoin/bitcoin#34453: ci: Always print low ccache hit rate notice 5401e673d561 Merge bitcoin/bitcoin#33604: p2p: Allow block downloads from peers without snapshot block after assumeutxo validation 6750744eb32d Merge bitcoin/bitcoin#34164: validation: add reusable coins view for ConnectBlock 4e4fa0199ee2 Merge bitcoin/bitcoin#33680: validation: do not wipe utxo cache for stats/scans/snapshots fad2876ec330 ci: Always print low ccache hit rate notice e67a676df9af fix: uptime RPC returns 0 on first call a89e1618dd8c contrib: update macOS SDK to Xcode-26.1.1-17B100 57a778ed2526 depends: use -Xclang -fno-cxx-modules in macOS cross build 3e0fd0e4ddd8 refactor: rename will_reuse_cache to reallocate_cache 44b4ee194d3b validation: reuse same CCoinsViewCache for every ConnectBlock call 8fb6043231ea coins: introduce CCoinsViewCache::ResetGuard 041758f5eda5 coins: use hashBlock setter internally for CCoinsViewCache methods 8dd9200fc9b0 coins: add Reset on CCoinsViewCache efcbf794484e ci, iwyu: Fix warnings in `src/zmq` and treat them as errors d3e681bc0675 fuzz: Use `__AFL_SHM_ID` for naming test directories f7e0c3d3d370 Merge bitcoin/bitcoin#34346: test: use IP_PORTRANGE_HIGH on FreeBSD for dynamic port allocation eeb4d2814803 validation: follow-up nits for lock-free `IsInitialBlockDownload()` 1c2f164d3486 Merge bitcoin/bitcoin#34253: validation: cache tip recency for lock-free `IsInitialBlockDownload()` 8cdf1dcca0ce Merge bitcoin/bitcoin#34373: refactor: Remove remaining std::bind, check via clang-tidy facb2aab26df test: Turn ElapseSteady into SteadyClockContext 6354b4fd7fe8 tests: log node JSON-RPC errors during test setup 45930a79412d http-server: guard against crashes from unhandled exceptions a6cdc3ec9b56 Merge bitcoin/bitcoin#34303: test: addrman: test self-announcement time penalty handling 75ec9001ced9 Merge bitcoin/bitcoin#34207: coins/refactor: enforce `GetCoin()` returns only unspent coins 4fab35cf88c0 miniscript: correct and_v() properties 51abf7d15b1d script: remove unused SCRIPT_ERR_LAST f2b8acc0edb6 remove glozow from trusted keys cd1af852fa5d Merge bitcoin/bitcoin#34358: wallet: fix removeprunedfunds bug with conflicting transactions 2dd5e7bb38da Merge bitcoin/bitcoin#34409: test: use `ModuleNotFoundError` in `interface_ipc.py` d3e8c459e776 Merge bitcoin/bitcoin#34417: log: Print warning about privacy-sensitive log info unconditionally d9851f9a7c1c Merge bitcoin/bitcoin#33472: guix: documented shasum gathering command a7460b992884 Merge bitcoin/bitcoin#34098: test: [move-only] Move lint functions into modules 8f9ad534a5a5 Merge bitcoin/bitcoin#34352: ci, iwyu: Fix warnings in `src/primitives` and treat them as errors faba426b3b66 lint: Flatten lint image entry points 1111fff91c76 lint: Add missing --platform=linux to docker build command feb74a9372be Merge bitcoin/bitcoin#34430: ci: mount git directory as writable in linter fad042235bd6 refactor: Remove remaining std::bind, check via clang-tidy c8abac994122 ci: mount .git dir rw d9e651f9954f Merge bitcoin/bitcoin#33622: docs: add doc comment for SRD selection algorithm cb128bcedb58 Merge bitcoin/bitcoin#34408: ci: remove gnu-getopt usage 6ae96ed60745 Merge bitcoin/bitcoin#34276: Remove empty caption from user interface (noui, gui) fafdae46ff0b test: Check that redundant verack message is ignored 289d60f5ab76 Merge bitcoin/bitcoin#34161: refactor: avoid possible UB from `std::distance` for `nullptr` args 1d3243806da6 Merge bitcoin/bitcoin#34391: lint: upgrade lint scripts for worktrees d931b54d138f Merge bitcoin/bitcoin#34412: Update secp256k1 subtree to latest master 3400db80401d doc: add missing param description to SRD c0e6556e4f51 Merge bitcoin/bitcoin#34413: doc: Remove outdated -fdebug-prefix-map section in dev notes 9260b20ef175 Merge bitcoin/bitcoin#33962: refactor: replace manual promise with SyncWithValidationInterfaceQueue ddae1b4efa56 ci: remove gnu-getopt usage fa43897c1d14 doc: Fix LLM nits in net_processing.cpp bbbba0fd4b87 scripted-diff: Use references when nullptr is not possible fac541546604 refactor: Separate peer/maybe_peer in ProcessMessages and SendMessages fac529188e0d refactor: Pass Peer& to ProcessMessage fa376095a01c refactor: Pass CNode& to ProcessMessages and SendMessages fada8380148c refactor: Make ProcessMessage private again fa80cd3ceed4 test: [refactor] Avoid calling private ProcessMessage() function d511adb664ed [miner] omit dummy extraNonce via IPC bf3b5d6d069a test: clarify getCoinbaseRawTx() comparison 78df9003d634 [doc] Update comments on dummy extraNonces in tests e770392084aa test: addrman: test self-announcement time penalty handling 27aeeff63014 Merge bitcoin/bitcoin#34328: rpc: make `uptime` monotonic across NTP jumps 5aeaa71c77ac lint: pass args from lint.py to cargo run in container c17a2adb8dc0 lint: upgrade lint scripts for worktrees fa9c92d7b639 log: Print warning about privacy-sensitive log info unconditionally f970cb39fb64 Merge bitcoin/bitcoin#34267: net: avoid unconditional `privatebroadcast` logging (+ warn for debug logs) 8593d965191e Merge bitcoin/bitcoin#33067: test: refactor ValidWitnessMalleatedTx class to helper function 2fccbea3c8a0 Squashed 'src/secp256k1/' changes from d543c0d917..14e56970cb 26fbe10873e7 Update secp256k1 subtree to latest master 34a5ecadd720 Merge bitcoin/bitcoin#34397: doc: fix arg name hints so bugprone can validate them fa2e1b85dd6b build: Remove outdated comment about -ffile-prefix-map fa06cd4ba730 doc: Remove outdated -fdebug-prefix-map section in dev notes ab649ce45945 guix: documented shasum gathering command 1cc58d3a0c65 Merge bitcoin/bitcoin#34281: build: Temporarily remove confusing and brittle `-fdebug-prefix-map` 905dfdee86d6 test: use ModuleNotFoundError in interface_ipc.py 2778eb46647a Merge bitcoin/bitcoin#34337: fuzz: Return chrono point from ConsumeTime(), Add ConsumeDuration() d70fb8a5754f Merge bitcoin/bitcoin#34351: util: Remove `FilterHeaderHasher` 6472ba06c36a Merge bitcoin/bitcoin#34388: doc: Explain that low-effort pull requests may be closed 1f60ca360eb8 wallet: fix removeprunedfunds bug with conflicting transactions 5f66fca633c8 Merge bitcoin-core/gui#920: Set peer version and subversion to N/A when not available or detecting 02240a7698e3 Merge bitcoin/bitcoin#34390: test: allow overriding `tar` in `get_previous_releases.py` 7d9e1a810239 test: Verify peer usage after assumeutxo validation completes 3bd98b45084d refactor: use transparent comparator for setBlockIndexCandidates lookups a73a3ec5532d doc: fix invalid arg name hints for bugprone validation eeee3755f8c4 fuzz: Return chrono point from ConsumeTime(), Add ConsumeDuration() 1b36bf0c5d71 subprocess: Fix `-Wunused-private-field` for `Child` class on Windows 9f2b338bc018 subprocess: Fix `-Wunused-private-field` for `Popen` class on Windows fa15a8d2d03b doc: Explain that low-effort pull requests may be closed be2b48b9f3e5 test: allow overriding tar in get_previous_releases db2effaca4cf scripted-diff: refactor: CWallet::Create() -> CreateNew() 27e021ebc0dd wallet: Correctly log stats for encrypted messages. d8bec61be233 wallet: remove loading logic from CWallet::Create f35acc893fb3 refactor: wallet: Factor out `WriteVersion()` from `PopulateWalletFromDB()` e12ff8aca049 test: wallet: Split create and load 70dbc79b09ac wallet: Use CWallet::LoadExisting() for loading existing wallets. ae66e0116462 wallet: Create separate function for wallet load bc69070416c6 refactor: Wallet stats logging in its own function a9d64cd49c69 wallet: Remove redundant birth time update b4a49cc7275e wallet: Move argument parsing to before DB load b15a94a618c5 refactor: Split out wallet argument loading 6f7b4323cb46 test: remove UNKNOWN_ERROR from script_tests bd31a92d6716 script: use SCRIPT_ERR_SCRIPTNUM for CScriptNum errors 0ca4dcd78665 script: add SCRIPT_ERR_SCRIPTNUM error 2845f10a2be0 test: extend FreeBSD ephemeral port range fix to P2P listeners 3f5211cba8e7 test: remove child_one/child_two (w)txid variables 7cfe790820cf test: replace ValidWitnessMalleatedTx class with function 4fec726c4d35 refactor: Simplify Interpret asmap function 79e97d45c16f doc: Add more extensive docs to asmap implementation cf4943fdcdd1 refactor: Use span instead of vector for data in util/asmap 385c34a05261 refactor: Unify asmap version calculation and naming fa41fc6a1a7d refactor: Operate on bytes instead of bits in Asmap code 964c44cdcd6b test(miniscript): Prove avoidance of stack overflow 198bbaee4959 refactor(miniscript): Destroy nodes one full subs-vector at a time 50cab8570e8f refactor(miniscript): Remove NodeRef & MakeNodeRef() 15fb34de41cb refactor(miniscript): Remove superfluous unique_ptr-indirection e55b23c170eb refactor(miniscript): Remove Node::subs mutability c6f798b22247 refactor(miniscript): Make fields non-const & private 22e4115312b9 doc(miniscript): Remove mention of shared pointers 34bed0ed8c44 test: use IP_PORTRANGE_HIGH on FreeBSD for dynamic port allocation ccf9172ab3bb util: Remove `FilterHeaderHasher` fdc9fe2da6a8 ci, iwyu: Fix warnings in `src/primitives` and treat them as errors 477c5504e05f coins: replace `std::distance` with unambiguous pointer subtraction 81675a781f3a test: use pre-generated chain 14f99cfe53f0 rpc: make `uptime` monotonic across NTP jumps a9440b1595be util: add `TicksSeconds` a02c4a82d88a refactor: Move -walletbroadcast setting init 411caf72815b wallet: refactor: PopulateWalletFromDB use switch statement. a48e23f566cc refactor: wallet: move error handling to PopulateWalletFromDB() faa5a9ebad15 fuzz: Use min option in ConsumeTime 0972785fd723 wallet: Delete unnecessary PopulateWalletFromDB() calls f0a046094e4c scripted-diff: refactor: CWallet::LoadWallet->PopulateWalletFromDB fad7bd9ba3ee noui: Remove always empty caption while formatting fa8ebeb33232 refactor: [gui] Document that the title is always empty for node message fafe71b743a0 refactor: Remove empty caption from ThreadSafeMessageBox fa8d0088e76d refactor: Remove empty caption from ThreadSafeQuestion fa37928536e0 build: Temporarily remove confusing and brittle -fdebug-prefix-map b39291f4cde0 doc: fix `-logips` description to clarify that non-debug logs can also contain IP addresses c7028d3368e9 init: log that additional logs may contain privacy-sensitive information 31b771a9425d net: move `privatebroadcast` logs to debug category fa16b275fa94 test: Check that interrupt results in EXIT_SUCCESS fab7c7f56c1d test: Split large init_stress_test into two smaller functions fa0195499ca6 refactor: [gui] Use lambdas over std::bind eeee1e341fa5 refactor: Remove trailing semicolon after ADD_SIGNALS_DECL_WRAPPER 557b41a38ccf validation: make `IsInitialBlockDownload()` lock-free b9c0ab3b75a1 chain: add `CChain::IsTipRecent` helper 8d531c6210eb validation: invert `m_cached_finished_ibd` to `m_cached_is_ibd` 8be54e3b1967 test: cover IBD exit conditions 2ee7f9b25905 coins: assume `GetCoin` only returns unspent coins eec551aaf1df fuzz: keep `coinscache_sim` backend free of spent coins 3e4155fcefe0 test: do not return spent coins from `CCoinsViewTest::GetCoin` ee1e40f58000 txdb: assert `CCoinsViewDB::GetCoin` only returns unspent coins fa578d9434fd lint: [move-only] Move python related lints to lint_py.rs fa392c31e7b9 lint: [move-only] Move repo related lints to lint_repo_hygiene.rs fab0cfa987c9 lint: [move-only] Move cpp related lints to lint_cpp.rs fa3e48e3fd4d lint: [move-only] Move docs related lints to lint_docs.rs fad09e77dbe5 lint: [move-only] Move text related lints to text_format.rs faf40c2f848d lint: [move-only] Move util functions to util.rs c6ca2b85a3e6 validation: do not wipe utxo cache for stats/scans/snapshots 7099e93d0a80 refactor: rename `FlushStateMode::ALWAYS` to `FORCE_FLUSH` b261100e7169 [qt] Set peer version and subversion to N/A when not available or detecting 552bc82b1796 doc: Use multipath descriptors in descriptors.md and linked test 0067abe15329 p2p: Allow block downloads from peers without snapshot block after assumeutxo validation e71c4df16851 refactor: replace manual promise with SyncWithValidationInterfaceQueue b189a3455744 test: add case where `TOTAL_TRIES` is exceeded yet solution remains 76dae5d6911b cmake: Replace recursive globbing with explicit globbing in folders a099655f2e1b scripted-diff: Update `DeriveType` enum values to mention ranged derivations 88d909257104 cmake: Create subdirectories in build tree in advance 7378f27b4fb5 test: run utxo-to-sqlite script test with spk/txid format option combinations b30fca7498c9 contrib: utxo_to_sqlite.py: add options to store txid/spk as BLOBs git-subtree-dir: libbitcoinkernel-sys/bitcoin git-subtree-split: d9c7364ac56781a16c7224b2c7a6db9db97f17d8

hebasto added Bug Build system labels Dec 23, 2025

hebasto mentioned this pull request Dec 23, 2025

cmake: Add missed Boost::headers #34103

Closed

maflcko added the DrahtBot Guix build requested label Dec 24, 2025

DrahtBot removed the DrahtBot Guix build requested label Dec 26, 2025

hebasto changed the title ~~build: Switch to "versioned" install layout for boost package and add missed Boost::headers~~ build: Prevent system header fallback and include path pollution Jan 21, 2026

hebasto force-pushed the 251223-boost-layout branch from 2a69015 to 2921491 Compare January 21, 2026 22:40

theuni approved these changes Jan 22, 2026

View reviewed changes

DrahtBot mentioned this pull request Jan 27, 2026

[POC] Full Libevent removal #34411

Draft

hebasto mentioned this pull request Feb 5, 2026

build: don't pass on boost dependency to kernel consumers #34496

Merged

hebasto added 4 commits February 5, 2026 13:46

cmake: Add missed Boost::headers

d73378f

depends: Prefix include path for headers-only boost package

b5375c4

cmake: Add missed USDT::headers

94a692b

depends: Prefix include path for headers-only systemtap package

65134c7

hebasto force-pushed the 251223-boost-layout branch from 2921491 to 65134c7 Compare February 5, 2026 13:46

fanquake added this to the 31.0 milestone Feb 10, 2026

DrahtBot requested a review from willcl-ark February 11, 2026 17:41

fanquake merged commit 55c49ff into bitcoin:master Feb 11, 2026
27 checks passed

hebasto deleted the 251223-boost-layout branch February 11, 2026 17:44

hebasto commented Feb 12, 2026

View reviewed changes

fanquake mentioned this pull request Feb 12, 2026

ci: add (atleast one) *BSD job to the CI #33438

Open

hebasto mentioned this pull request Feb 12, 2026

cmake: Fix NetBSD-specific workaround for Boost #34572

Merged

Conversation

hebasto commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DrahtBot commented Dec 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage & Benchmarks

Reviews

Conflicts

Uh oh!

DrahtBot commented Dec 26, 2025

Guix builds (on x86_64) [untrusted test-only build, possibly unsafe, not for production use]

Uh oh!

janb84 commented Dec 28, 2025

Uh oh!

theuni commented Jan 20, 2026

Uh oh!

hebasto commented Jan 21, 2026

Uh oh!

theuni commented Jan 21, 2026

Uh oh!

theuni commented Jan 21, 2026

Uh oh!

hebasto commented Jan 21, 2026

Uh oh!

theuni commented Jan 22, 2026

Uh oh!

theuni commented Jan 22, 2026

Uh oh!

theuni left a comment

Choose a reason for hiding this comment

Uh oh!

hebasto commented Jan 22, 2026

Uh oh!

hebasto commented Jan 25, 2026

Uh oh!

hebasto commented Feb 5, 2026

Uh oh!

hebasto commented Feb 5, 2026

Uh oh!

fanquake commented Feb 9, 2026

Uh oh!

theuni commented Feb 10, 2026

Uh oh!

willcl-ark commented Feb 11, 2026

Uh oh!

janb84 commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fanquake commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

janb84 commented Feb 11, 2026

Uh oh!

fanquake commented Feb 11, 2026

Uh oh!

Uh oh!

hebasto Feb 12, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

hebasto commented Dec 23, 2025 •

edited

Loading

DrahtBot commented Dec 23, 2025 •

edited

Loading

janb84 commented Feb 11, 2026 •

edited

Loading

fanquake commented Feb 11, 2026 •

edited

Loading