test: make assumeUTXO test capture the expected fatal error

[furszy]

The test is exercising the error, so it can capture it before the
test framework displays it on the console as an unforeseen
fatal error.

It is odd to observe a fatal error after executing the complete
test suite and seeing it pass successfully.

Reproduction Steps:
Run the unit test suite. A long AssumeUTXO fatal error will be
printed even when all tests pass successfully.

[DrahtBot]

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	theStack, MarcoFalke, TheCharlatan

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

[furszy]

Updated per feedback, thanks @MarcoFalke.

• Moved DebugLogHelper usage to ASSERT_DEBUG_LOG.
• Added reproduction steps to the PR description.

[theStack]

Tested ACK 3e8bf2e

[maflcko]

Also it may be good to name the commit that introduced the bug. Otherwise it will be harder for reviewers to see if there was a bug in that commit or if the change was intentional. Also, reviewers will be missing context.

[furszy]

Also it may be good to name the commit that introduced the bug. Otherwise it will be harder for reviewers to see if there was a bug in that commit or if the change was intentional. Also, reviewers will be missing context.

Ok. It was introduced with the test 87a1108.
Still, this isn't as serious as you imagine. It is just an extra print. 100% sure that wasn't intended.

The test is exercising a specific fatal error (checking that is being triggered), and doing so it makes the node call AbortNode. Which calls InitError which is connected to the noui signals interface, which is listened by the test framework base class, which prints the error to the console.

[maflcko]

Are you sure, because locally I don't see it in 25.0:

$ ./bitcoin-25.0/bin/test_bitcoin  -t validation_chainstatemanager_tests/chainstatemanager_snapshot_completion_hash_mismatch 
Running 1 test case...

*** No errors detected

[furszy]

Are you sure, because locally I don't see it in 25.0:

$ ./bitcoin-25.0/bin/test_bitcoin  -t validation_chainstatemanager_tests/chainstatemanager_snapshot_completion_hash_mismatch 
Running 1 test case...

*** No errors detected

Ok good, found the commit. 6eb33bd introduced it. It removed the mock_shutdown function from the test (which was the one swalling the error).

[furszy]

cc @TheCharlatan then. Thanks @MarcoFalke.

[maflcko]

lgtm ACK 3e8bf2e

[sedited]

ACK 3e8bf2e

Thank you for fixing this.