Skip to content

Conversation

@hebasto
Copy link
Member

@hebasto hebasto commented Apr 1, 2023

A follow-up for #23724.

This also removes a stray </dd> from the NO_NATPMP docs.

@DrahtBot
Copy link
Contributor

DrahtBot commented Apr 1, 2023

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK 0xB10C

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@hebasto
Copy link
Member Author

hebasto commented Apr 1, 2023

cc @0xB10C

@0xB10C
Copy link
Contributor

0xB10C commented Apr 1, 2023

ACK c9aace2

This also removes a stray </dd> from the NO_NATPMP docs. Maybe worth mentioning in the OP?

Change looks good to me. I did not run a depends build with NO_USDT set to test it.

@hebasto
Copy link
Member Author

hebasto commented Apr 1, 2023

This also removes a stray </dd> from the NO_NATPMP docs. Maybe worth mentioning in the OP?

Done.

Change looks good to me. I did not run a depends build with NO_USDT set to test it.

FWIW, we use NO_USDT in our other docs:

$ git grep -l NO_USDT -- doc
doc/build-freebsd.md
doc/build-openbsd.md
doc/build-unix.md

@fanquake fanquake merged commit a864998 into bitcoin:master Apr 2, 2023
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Apr 2, 2023
c9aace2 depends, doc: Document `NO_USDT` option (Hennadii Stepanov)

Pull request description:

  A follow-up for bitcoin#23724.

  This also removes a stray `</dd>` from the `NO_NATPMP` docs.

ACKs for top commit:
  0xB10C:
    ACK c9aace2

Tree-SHA512: 44426f5b2bf9eaa3b8a6c54020d23c97ab04f3d75bfa93469c2c5d3bd512fc214d82652e4558d9ad33e2b2e3605991cdbf7779ba47b10a50385d4c962a598b60
@bitcoin bitcoin locked and limited conversation to collaborators Apr 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants