Skip to content

Conversation

@hebasto
Copy link
Member

@hebasto hebasto commented Aug 25, 2022

The recent update of the ccache package from 4.6.1 to 4.6.2 broke our MSVC CI build.

This PR forces the working version 4.6.1.

@fanquake
Copy link
Member

What about the point update actually broke things? Has it been reported upstream?

@hebasto
Copy link
Member Author

hebasto commented Aug 25, 2022

What about the point update actually broke things? Has it been reported upstream?

Checking the https://github.com/ccache/ccache repository...

cc @sipsorcery

@sipsorcery
Copy link
Contributor

ACK 905f614.

@hebasto
Copy link
Member Author

hebasto commented Aug 25, 2022

What about the point update actually broke things? Has it been reported upstream?

Checking the https://github.com/ccache/ccache repository...

git log --oneline v4.6.1..v4.6.2 shows nothing suspicious...

@hebasto
Copy link
Member Author

hebasto commented Aug 25, 2022

@MarcoFalke

As all caches (Qt, vcpkg tools, vcpkg binary, ccache) have been invalidated, a couple of minutes lacks to finish a build before timeout.

Do you mind increasing CPU number:

--- a/.cirrus.yml
+++ b/.cirrus.yml
@@ -97,8 +97,8 @@ task:
   name: "Win64 native [vs2022]"
   << : *FILTER_TEMPLATE
   windows_container:
-    cpu: 4
-    memory: 8G
+    cpu: 6
+    memory: 12G
     image: cirrusci/windowsservercore:visualstudio2022
   timeout_in: 120m
   env:

?

Required to fit timeout when all build caches are invalidated.
@maflcko maflcko merged commit 6057e7e into bitcoin:master Aug 25, 2022
@hebasto hebasto deleted the 220825-msvc branch August 25, 2022 11:26
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Aug 25, 2022
@hebasto
Copy link
Member Author

hebasto commented Aug 28, 2022

What about the point update actually broke things? Has it been reported upstream?

It has been fixed in v4.6.3 (tested in my Cirrus account).

This PR forces the working version 4.6.1.

Nevertheless, I'd prefer to stick to well-known v4.6.1 for now.

fanquake added a commit to bitcoin-core/gui that referenced this pull request Oct 14, 2022
…l tests in "Win64 native" task

6fbd173 ci: Use all available CPUs for functional tests in "Win64 native" task (Hennadii Stepanov)

Pull request description:

  On the [master](https://cirrus-ci.com/task/5422842484359168) branch:
  ![Screenshot from 2022-10-12 09-45-58](https://user-images.githubusercontent.com/32963518/195296883-3852ea09-7345-4166-b855-7704dcd87202.png)

  This [PR](https://cirrus-ci.com/task/6392972617973760) branch:
  ![Screenshot from 2022-10-12 11-11-15](https://user-images.githubusercontent.com/32963518/195315902-f667874a-8aeb-4f2f-bdc3-5ba432ae9353.png)

  Also consider "CPU Usage" charts provided by CI.

  Overlooked in cda6265 (bitcoin/bitcoin#25929).

ACKs for top commit:
  hebasto:
    Indeed. Reverted back to 6fbd173 ([pr26297.01](https://github.com/hebasto/bitcoin/commits/pr26297.01)), which was already [ACKed](bitcoin/bitcoin#26297 (review)) by @aureleoules.
  aureleoules:
    ACK 6fbd173
  jarolrod:
    ACK 6fbd173
  shaavan:
    ACK 6fbd173

Tree-SHA512: ddd4b41af95bd735f881a3b2c64ee308de2725381f770e313e66555f929d88c8848c98cc5fcd15dfa6845b5dd84ca6c8764ef5d01602b0a62041820856af2b98
@bitcoin bitcoin locked and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants