Skip to content

Conversation

@bitcoinhodler
Copy link
Contributor

The line about "(Anywhere a ' suffix is permitted to denote hardened derivation, the suffix h can be used instead.)" belongs with the section on KEY expressions, not following the unrelated TREE section.

Before 7cedafc added the TREE
section, this line appeared right after the KEY section.

It doesn't really fit in its former location since it's the KEY
section that discusses derivation path syntax, not the TREE section.
@fanquake fanquake added the Docs label Feb 7, 2022
Copy link
Contributor

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK bac30e8

Copy link
Contributor

@meshcollider meshcollider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK bac30e8

@fanquake fanquake merged commit 8afcc89 into bitcoin:master Feb 8, 2022
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Feb 9, 2022
…oser to KEY section

bac30e8 docs: Move explanation of hardened key syntax closer to KEY section (Bitcoin Hodler)

Pull request description:

  The line about "(Anywhere a `'` suffix is permitted to denote hardened derivation, the suffix `h` can be used instead.)" belongs with the section on KEY expressions, not following the unrelated TREE section.

ACKs for top commit:
  prusnak:
    ACK bac30e8
  meshcollider:
    ACK bac30e8

Tree-SHA512: 56fe97b89c02e67e94cab33b01e56f17f9b501b97036c5b35939dc4000a9d5e9afe4333869ba97bbe81372c538b7b2021a7d2520aba731400d8d0e62714d52b4
@bitcoinhodler bitcoinhodler deleted the doc-fix-hardened-descriptors branch February 9, 2022 07:32
@bitcoin bitcoin locked and limited conversation to collaborators Feb 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants