doc: Remove Reference Links #19582 #19639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
RobertHosking
changed the title
-BEGIN VERIFY SCRIPT- sed -i '/https:\/\/bitcoin.org\/en\/developer-reference/d' ./src/protocol.h -END VERIFY SCRIPT-
RobertHosking
force-pushed
the
remove-reference-links
branch
from
f988cec to
334de75
Compare
Contributor
Author
|
Force pushed to amend the commit message to include a newline before the scripted diff. Not having this newline was causing travis-ci linter to fail. Now the travis build is failing and I'm not sure why. |
Member
|
Looks good to me. Checked that |
Member
|
ACK 334de75 |
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jun 27, 2021
334de75 scripted-diff: Remove Reference Links (Robert) Pull request description: Removed all reference links. Found this issue from bitcoin#19582. The decision to remove links instead of update them was made in bitcoin#19584 The author of that PR was slow to resolve his commit to use scripted diff so I made this PR instead. ACKs for top commit: laanwj: ACK 334de75 MarcoFalke: ACK 334de75 Tree-SHA512: a337116379912b27974867bd86ec7799a1d41d67b51771885467fbe1be003b415cb37ce8e521568bf3eae190ab2f6af0d6e29fd3ea25f2689b8fb31def8fec96
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jun 28, 2021
334de75 scripted-diff: Remove Reference Links (Robert) Pull request description: Removed all reference links. Found this issue from bitcoin#19582. The decision to remove links instead of update them was made in bitcoin#19584 The author of that PR was slow to resolve his commit to use scripted diff so I made this PR instead. ACKs for top commit: laanwj: ACK 334de75 MarcoFalke: ACK 334de75 Tree-SHA512: a337116379912b27974867bd86ec7799a1d41d67b51771885467fbe1be003b415cb37ce8e521568bf3eae190ab2f6af0d6e29fd3ea25f2689b8fb31def8fec96
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jun 29, 2021
334de75 scripted-diff: Remove Reference Links (Robert) Pull request description: Removed all reference links. Found this issue from bitcoin#19582. The decision to remove links instead of update them was made in bitcoin#19584 The author of that PR was slow to resolve his commit to use scripted diff so I made this PR instead. ACKs for top commit: laanwj: ACK 334de75 MarcoFalke: ACK 334de75 Tree-SHA512: a337116379912b27974867bd86ec7799a1d41d67b51771885467fbe1be003b415cb37ce8e521568bf3eae190ab2f6af0d6e29fd3ea25f2689b8fb31def8fec96
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 1, 2021
334de75 scripted-diff: Remove Reference Links (Robert) Pull request description: Removed all reference links. Found this issue from bitcoin#19582. The decision to remove links instead of update them was made in bitcoin#19584 The author of that PR was slow to resolve his commit to use scripted diff so I made this PR instead. ACKs for top commit: laanwj: ACK 334de75 MarcoFalke: ACK 334de75 Tree-SHA512: a337116379912b27974867bd86ec7799a1d41d67b51771885467fbe1be003b415cb37ce8e521568bf3eae190ab2f6af0d6e29fd3ea25f2689b8fb31def8fec96
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 1, 2021
334de75 scripted-diff: Remove Reference Links (Robert) Pull request description: Removed all reference links. Found this issue from bitcoin#19582. The decision to remove links instead of update them was made in bitcoin#19584 The author of that PR was slow to resolve his commit to use scripted diff so I made this PR instead. ACKs for top commit: laanwj: ACK 334de75 MarcoFalke: ACK 334de75 Tree-SHA512: a337116379912b27974867bd86ec7799a1d41d67b51771885467fbe1be003b415cb37ce8e521568bf3eae190ab2f6af0d6e29fd3ea25f2689b8fb31def8fec96
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 15, 2021
334de75 scripted-diff: Remove Reference Links (Robert) Pull request description: Removed all reference links. Found this issue from bitcoin#19582. The decision to remove links instead of update them was made in bitcoin#19584 The author of that PR was slow to resolve his commit to use scripted diff so I made this PR instead. ACKs for top commit: laanwj: ACK 334de75 MarcoFalke: ACK 334de75 Tree-SHA512: a337116379912b27974867bd86ec7799a1d41d67b51771885467fbe1be003b415cb37ce8e521568bf3eae190ab2f6af0d6e29fd3ea25f2689b8fb31def8fec96
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 16, 2021
334de75 scripted-diff: Remove Reference Links (Robert) Pull request description: Removed all reference links. Found this issue from bitcoin#19582. The decision to remove links instead of update them was made in bitcoin#19584 The author of that PR was slow to resolve his commit to use scripted diff so I made this PR instead. ACKs for top commit: laanwj: ACK 334de75 MarcoFalke: ACK 334de75 Tree-SHA512: a337116379912b27974867bd86ec7799a1d41d67b51771885467fbe1be003b415cb37ce8e521568bf3eae190ab2f6af0d6e29fd3ea25f2689b8fb31def8fec96
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Sep 6, 2021
Summary: The links are no longer good, and Core decided to remove them rather than update them. > -BEGIN VERIFY SCRIPT- > sed -i '/https:\/\/bitcoin.org\/en\/developer-reference/d' ./src/protocol.h > -END VERIFY SCRIPT- This is a backport of [[bitcoin/bitcoin#19639 | core#19639]] Test Plan: self-review (low risk of accidental change, as there was no conflict and no linter action) Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Differential Revision: https://reviews.bitcoinabc.org/D10052
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed all reference links.
Found this issue from #19582.
The decision to remove links instead of update them was made in #19584
The author of that PR was slow to resolve his commit to use scripted diff so I made this PR instead.