build: ignore macOS make deploy artefacts & add them to clean-local #16371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Concept ACK, the file is produced in the makefile (though, not by any umbrella rule), so it should be ignored also code review ACK 290c5c6 |
maflcko
changed the title
fanquake
force-pushed
the
ignore_osx_volname
branch
from
290c5c6 to
57fb62e
Compare
fanquake
changed the title
Member
|
Concept ACK |
Contributor
|
utACK 57fb62e |
| *.plist | ||
|
|
||
| osx_volname | ||
| dist/ |
Contributor
There was a problem hiding this comment.
Do you have any other files than the already ignored Bitcoin-Qt.app in here?
Contributor
|
ACK 57fb62e |
Member
|
@fanquake |
Member
Author
|
@hebasto The artefacts occur when building for a macOS HOST on a Linux machine. |
hebasto
reviewed
Aug 13, 2019
Member
|
Tested master branch on Linux Mint 19.2: Artefacts:
|
fanquake
force-pushed
the
ignore_osx_volname
branch
from
57fb62e to
c84ff23
Compare
Member
Author
|
@hebasto Thanks for testing. I've fixed your nit.
You should see it if you run |
Member
|
ACK c84ff23, tested on Linux Mint 19.2:
|
Contributor
|
Gitian builds for commit a7aa809 (master):
Gitian builds for commit 5b4a866 (master and this pull):
|
Contributor
|
ACK c84ff23 |
fanquake
added a commit
that referenced
this pull request
Aug 21, 2019
… clean-local c84ff23 build: ignore macOS make deploy artefacts & add them to clean-local (fanquake) Pull request description: ACKs for top commit: hebasto: ACK c84ff23, tested on Linux Mint 19.2: dongcarl: ACK c84ff23 Tree-SHA512: 5a6525a5e433a7279807cc02d3f47bb7f4bd5da8142a945b21d3bfa71938cac823569b34b071e21525a817a187fb02a562bb1c5a9761e2019a2b0900a51a8315
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Aug 22, 2019
…them to clean-local c84ff23 build: ignore macOS make deploy artefacts & add them to clean-local (fanquake) Pull request description: ACKs for top commit: hebasto: ACK c84ff23, tested on Linux Mint 19.2: dongcarl: ACK c84ff23 Tree-SHA512: 5a6525a5e433a7279807cc02d3f47bb7f4bd5da8142a945b21d3bfa71938cac823569b34b071e21525a817a187fb02a562bb1c5a9761e2019a2b0900a51a8315
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Nov 3, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Nov 4, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Nov 11, 2021
pravblockc
pushed a commit
to pravblockc/dash
that referenced
this pull request
Nov 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.