[rpc] remove deprecated generate method #15492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sjors
force-pushed
the
2019/02/rpc-generate-remove
branch
3 times, most recently
from
63477e5 to
5e0d4fb
Compare
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Member
|
Nice cleanup. utACK. |
jnewbery
reviewed
Feb 27, 2019
| """Test deprecation of RPC calls.""" | ||
| from test_framework.test_framework import BitcoinTestFramework | ||
| from test_framework.util import assert_raises_rpc_error | ||
| # from test_framework.util import assert_raises_rpc_error |
Contributor
There was a problem hiding this comment.
Rather than change this file around, can you just revert it to how it was pre-commit c9f0295.
Member
Author
There was a problem hiding this comment.
Main reason for changing this file around is improving documentation; generate allows a much simpler example than createmultisig.
Update: removed the skip_test_if_missing_module bit, since that's wallet specific.
Sjors
force-pushed
the
2019/02/rpc-generate-remove
branch
from
5e0d4fb to
8bb3e4c
Compare
Member
Author
|
Why WIP? That seems more appropriate for more experimental code. This PR is already tagged 0.19 so that should be clear enough. |
Contributor
|
Tagging 0.19 is fine. Just as long as the maintainers are aware that this shouldn't be merged prior to the branch split. |
Contributor
|
This PR seems reasonable, but I would like to remove:
from the PR description. I don't think this is true in any significant sense. If there really is a need to relate this PR to #15288, you could say:
I think there is some confusion in the #15288 discussion that |
Member
Author
|
@ryanofsky I removed that comment |
Contributor
|
I suggest getting rid of it! :-) |
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Mar 2, 2019
07cae52 [wallet] remove unused GetScriptForMining (Sjors Provoost) 8bb3e4c [rpc] remove deprecated generate method (Sjors Provoost) Pull request description: As announced in v0.18, the wallet generate rpc method is deprecated and will be fully removed in v0.19. Clients should transition to using the node rpc method `generatetoaddress`. Tree-SHA512: 9e5e913b59f3e18440b2b7b356124c7b87ad19f81a1ab6ada06a6c396b84e734895465f569296f1ba8c12abf74863bab5fd77765c9e806c239713aa83a59485f
Member
|
ACK |
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jun 30, 2020
Summary: [rpc] remove deprecated generate method bitcoin/bitcoin@8bb3e4c [wallet] remove unused GetScriptForMining bitcoin/bitcoin@07cae52 --- Update: considering this is a testing only RPC and it is blocking a bunch of current stuff (and part of a PR going back to D6269), discussion has been mostly in favor of shipping this a bit over a month ahead of the normal deprecation schedule. Backport of Core [[bitcoin/bitcoin#15492 | PR15492]] Test Plan: ninja check-all Reviewers: #bitcoin_abc, Fabien, deadalnix Reviewed By: #bitcoin_abc, Fabien, deadalnix Subscribers: deadalnix, Fabien Differential Revision: https://reviews.bitcoinabc.org/D6710
Munkybooty
pushed a commit
to Munkybooty/dash
that referenced
this pull request
Sep 8, 2021
07cae52 [wallet] remove unused GetScriptForMining (Sjors Provoost) 8bb3e4c [rpc] remove deprecated generate method (Sjors Provoost) Pull request description: As announced in v0.18, the wallet generate rpc method is deprecated and will be fully removed in v0.19. Clients should transition to using the node rpc method `generatetoaddress`. Tree-SHA512: 9e5e913b59f3e18440b2b7b356124c7b87ad19f81a1ab6ada06a6c396b84e734895465f569296f1ba8c12abf74863bab5fd77765c9e806c239713aa83a59485f
vijaydasmp
pushed a commit
to vijaydasmp/dash
that referenced
this pull request
Nov 13, 2021
07cae52 [wallet] remove unused GetScriptForMining (Sjors Provoost) 8bb3e4c [rpc] remove deprecated generate method (Sjors Provoost) Pull request description: As announced in v0.18, the wallet generate rpc method is deprecated and will be fully removed in v0.19. Clients should transition to using the node rpc method `generatetoaddress`. Tree-SHA512: 9e5e913b59f3e18440b2b7b356124c7b87ad19f81a1ab6ada06a6c396b84e734895465f569296f1ba8c12abf74863bab5fd77765c9e806c239713aa83a59485f
vijaydasmp
pushed a commit
to vijaydasmp/dash
that referenced
this pull request
Nov 13, 2021
07cae52 [wallet] remove unused GetScriptForMining (Sjors Provoost) 8bb3e4c [rpc] remove deprecated generate method (Sjors Provoost) Pull request description: As announced in v0.18, the wallet generate rpc method is deprecated and will be fully removed in v0.19. Clients should transition to using the node rpc method `generatetoaddress`. Tree-SHA512: 9e5e913b59f3e18440b2b7b356124c7b87ad19f81a1ab6ada06a6c396b84e734895465f569296f1ba8c12abf74863bab5fd77765c9e806c239713aa83a59485f
vijaydasmp
pushed a commit
to vijaydasmp/dash
that referenced
this pull request
Nov 13, 2021
07cae52 [wallet] remove unused GetScriptForMining (Sjors Provoost) 8bb3e4c [rpc] remove deprecated generate method (Sjors Provoost) Pull request description: As announced in v0.18, the wallet generate rpc method is deprecated and will be fully removed in v0.19. Clients should transition to using the node rpc method `generatetoaddress`. Tree-SHA512: 9e5e913b59f3e18440b2b7b356124c7b87ad19f81a1ab6ada06a6c396b84e734895465f569296f1ba8c12abf74863bab5fd77765c9e806c239713aa83a59485f
vijaydasmp
pushed a commit
to vijaydasmp/dash
that referenced
this pull request
Nov 15, 2021
07cae52 [wallet] remove unused GetScriptForMining (Sjors Provoost) 8bb3e4c [rpc] remove deprecated generate method (Sjors Provoost) Pull request description: As announced in v0.18, the wallet generate rpc method is deprecated and will be fully removed in v0.19. Clients should transition to using the node rpc method `generatetoaddress`. Tree-SHA512: 9e5e913b59f3e18440b2b7b356124c7b87ad19f81a1ab6ada06a6c396b84e734895465f569296f1ba8c12abf74863bab5fd77765c9e806c239713aa83a59485f
vijaydasmp
pushed a commit
to vijaydasmp/dash
that referenced
this pull request
Nov 15, 2021
07cae52 [wallet] remove unused GetScriptForMining (Sjors Provoost) 8bb3e4c [rpc] remove deprecated generate method (Sjors Provoost) Pull request description: As announced in v0.18, the wallet generate rpc method is deprecated and will be fully removed in v0.19. Clients should transition to using the node rpc method `generatetoaddress`. Tree-SHA512: 9e5e913b59f3e18440b2b7b356124c7b87ad19f81a1ab6ada06a6c396b84e734895465f569296f1ba8c12abf74863bab5fd77765c9e806c239713aa83a59485f
vijaydasmp
pushed a commit
to vijaydasmp/dash
that referenced
this pull request
Nov 16, 2021
07cae52 [wallet] remove unused GetScriptForMining (Sjors Provoost) 8bb3e4c [rpc] remove deprecated generate method (Sjors Provoost) Pull request description: As announced in v0.18, the wallet generate rpc method is deprecated and will be fully removed in v0.19. Clients should transition to using the node rpc method `generatetoaddress`. Tree-SHA512: 9e5e913b59f3e18440b2b7b356124c7b87ad19f81a1ab6ada06a6c396b84e734895465f569296f1ba8c12abf74863bab5fd77765c9e806c239713aa83a59485f
vijaydasmp
pushed a commit
to vijaydasmp/dash
that referenced
this pull request
Nov 22, 2021
07cae52 [wallet] remove unused GetScriptForMining (Sjors Provoost) 8bb3e4c [rpc] remove deprecated generate method (Sjors Provoost) Pull request description: As announced in v0.18, the wallet generate rpc method is deprecated and will be fully removed in v0.19. Clients should transition to using the node rpc method `generatetoaddress`. Tree-SHA512: 9e5e913b59f3e18440b2b7b356124c7b87ad19f81a1ab6ada06a6c396b84e734895465f569296f1ba8c12abf74863bab5fd77765c9e806c239713aa83a59485f
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As announced in v0.18, the wallet generate rpc method is deprecated and will be fully removed in v0.19.
Clients should transition to using the node rpc method
generatetoaddress.