[build] Add temp_bitcoin_locale_qrc to CLEAN_QT to fix make distcheck#11621
[build] Add temp_bitcoin_locale_qrc to CLEAN_QT to fix make distcheck#11621laanwj merged 1 commit intobitcoin:masterfrom
Conversation
|
utACK c52c0cd. |
|
@fanquake This should be removed as soon as it's created: https://github.com/fanquake/bitcoin/blob/c52c0cdc8964d506e083d7cbc4fe6514f7398175/src/Makefile.qt.include#L430 Any idea what's keeping it around for you? |
|
I don't think it hurts to add it to CLEANFILES just in case, but yes that is weird. |
|
Sure, adding it as a backup is fine. It'd just be helpful to know why it's sticking around, as I'm not sure how that could happen. @fanquake Mind changing this to CLEAN_QT in Makefile.qt.include instead? utACK after that. |
c52c0cd to
a7c949f
Compare
|
@theuni Rebased and updated to use CLEAN_QT Still not sure what is making it hang around. Maybe permissions related? |
|
@fanquake ah yes, that must be it. distcheck makes all files read-only, I guess the parent dir ends up with a umask set. There's a cleaner way to handle this using the |
…make distcheck a7c949f [build] Add temp_bitcoin_locale_qrc to CLEAN_QT to fix make distcheck (fanquake) Pull request description: Fixes #11302 Tested on OS X 10.12.6 with 0e70791 Was failing like: ``` make distclean .... rm -f config.status config.cache config.log configure.lineno config.status.lineno rm -f Makefile ERROR: files left in build directory after distclean: ./src/qt/temp_bitcoin_locale.qrc make[1]: *** [distcleancheck] Error 1 make: *** [distcheck] Error 1 ``` Tree-SHA512: 291c786f20a82e648fdee2bcbc654d93d9abeb7d996ae7706d304697d4952709a0ec5d3aa88d1214f22cfe81ced88f10c187929904eecd60f2165b696727dd88
…to fix make distcheck a7c949f [build] Add temp_bitcoin_locale_qrc to CLEAN_QT to fix make distcheck (fanquake) Pull request description: Fixes bitcoin#11302 Tested on OS X 10.12.6 with 0e70791 Was failing like: ``` make distclean .... rm -f config.status config.cache config.log configure.lineno config.status.lineno rm -f Makefile ERROR: files left in build directory after distclean: ./src/qt/temp_bitcoin_locale.qrc make[1]: *** [distcleancheck] Error 1 make: *** [distcheck] Error 1 ``` Tree-SHA512: 291c786f20a82e648fdee2bcbc654d93d9abeb7d996ae7706d304697d4952709a0ec5d3aa88d1214f22cfe81ced88f10c187929904eecd60f2165b696727dd88
Fixes #11302
Tested on OS X 10.12.6 with 0e70791
Was failing like: