Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build] Add temp_bitcoin_locale_qrc to CLEAN_QT to fix make distcheck #11621

Merged
merged 1 commit into from
Nov 17, 2017
Merged

[build] Add temp_bitcoin_locale_qrc to CLEAN_QT to fix make distcheck #11621

merged 1 commit into from
Nov 17, 2017

Conversation

fanquake
Copy link
Member

@fanquake fanquake commented Nov 6, 2017 •
edited
Loading

Fixes #11302

Tested on OS X 10.12.6 with 0e70791

Was failing like:

make distclean
....
rm -f config.status config.cache config.log configure.lineno config.status.lineno
rm -f Makefile
ERROR: files left in build directory after distclean:
./src/qt/temp_bitcoin_locale.qrc
make[1]: *** [distcleancheck] Error 1
make: *** [distcheck] Error 1

@fanquake fanquake requested a review from theuni November 6, 2017 14:34
@promag
Copy link
Contributor

promag commented Nov 7, 2017

utACK c52c0cd.

@theuni
Copy link
Member

theuni commented Nov 7, 2017

@fanquake This should be removed as soon as it's created: https://github.com/fanquake/bitcoin/blob/c52c0cdc8964d506e083d7cbc4fe6514f7398175/src/Makefile.qt.include#L430

Any idea what's keeping it around for you?

@laanwj
Copy link
Member

laanwj commented Nov 13, 2017

I don't think it hurts to add it to CLEANFILES just in case, but yes that is weird.

@theuni
Copy link
Member

theuni commented Nov 14, 2017

Sure, adding it as a backup is fine. It'd just be helpful to know why it's sticking around, as I'm not sure how that could happen.

@fanquake Mind changing this to CLEAN_QT in Makefile.qt.include instead? utACK after that.

@fanquake
Copy link
Member Author

@theuni Rebased and updated to use CLEAN_QT

Still not sure what is making it hang around. Maybe permissions related?

  GEN      qt/qrc_bitcoin_locale.cpp
override r--r--r--  xxx/staff for qt/temp_bitcoin_locale.qrc? 
``

@fanquake fanquake changed the title [build] Add temp_bitcoin_locale_qrc to CLEANFILES to fix make distcheck [build] Add temp_bitcoin_locale_qrc to CLEAN_QT to fix make distcheck Nov 15, 2017
@theuni
Copy link
Member

theuni commented Nov 15, 2017

@fanquake ah yes, that must be it. distcheck makes all files read-only, I guess the parent dir ends up with a umask set.

There's a cleaner way to handle this using the .INTERMEDIATE target, but it's not really worth the effort here.

theuni
theuni approved these changes Nov 15, 2017
View reviewed changes
Copy link
Member

@theuni theuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK a7c949f

@laanwj laanwj merged commit a7c949f into bitcoin:master Nov 17, 2017
laanwj added a commit that referenced this pull request Nov 17, 2017
@laanwj
Merge #11621: [build] Add temp_bitcoin_locale_qrc to CLEAN_QT to fix …
1f7695b 
…make distcheck

a7c949f [build] Add temp_bitcoin_locale_qrc to CLEAN_QT to fix make distcheck (fanquake)

Pull request description:

  Fixes #11302

  Tested on OS X 10.12.6 with 0e70791

  Was failing like:
  ```
  make distclean
  ....
  rm -f config.status config.cache config.log configure.lineno config.status.lineno
  rm -f Makefile
  ERROR: files left in build directory after distclean:
  ./src/qt/temp_bitcoin_locale.qrc
  make[1]: *** [distcleancheck] Error 1
  make: *** [distcheck] Error 1
  ```

Tree-SHA512: 291c786f20a82e648fdee2bcbc654d93d9abeb7d996ae7706d304697d4952709a0ec5d3aa88d1214f22cfe81ced88f10c187929904eecd60f2165b696727dd88
@fanquake fanquake deleted the fix-osx-distcheck branch January 22, 2020 11:29
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jan 31, 2020
@laanwj @PastaPastaPasta
Merge bitcoin#11621: [build] Add temp_bitcoin_locale_qrc to CLEAN_QT …
626c74e 
…to fix make distcheck

a7c949f [build] Add temp_bitcoin_locale_qrc to CLEAN_QT to fix make distcheck (fanquake)

Pull request description:

  Fixes bitcoin#11302

  Tested on OS X 10.12.6 with 0e70791

  Was failing like:
  ```
  make distclean
  ....
  rm -f config.status config.cache config.log configure.lineno config.status.lineno
  rm -f Makefile
  ERROR: files left in build directory after distclean:
  ./src/qt/temp_bitcoin_locale.qrc
  make[1]: *** [distcleancheck] Error 1
  make: *** [distcheck] Error 1
  ```

Tree-SHA512: 291c786f20a82e648fdee2bcbc654d93d9abeb7d996ae7706d304697d4952709a0ec5d3aa88d1214f22cfe81ced88f10c187929904eecd60f2165b696727dd88
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Feb 4, 2020
@laanwj @PastaPastaPasta
Merge bitcoin#11621: [build] Add temp_bitcoin_locale_qrc to CLEAN_QT …
5b3744f 
…to fix make distcheck

a7c949f [build] Add temp_bitcoin_locale_qrc to CLEAN_QT to fix make distcheck (fanquake)

Pull request description:

  Fixes bitcoin#11302

  Tested on OS X 10.12.6 with 0e70791

  Was failing like:
  ```
  make distclean
  ....
  rm -f config.status config.cache config.log configure.lineno config.status.lineno
  rm -f Makefile
  ERROR: files left in build directory after distclean:
  ./src/qt/temp_bitcoin_locale.qrc
  make[1]: *** [distcleancheck] Error 1
  make: *** [distcheck] Error 1
  ```

Tree-SHA512: 291c786f20a82e648fdee2bcbc654d93d9abeb7d996ae7706d304697d4952709a0ec5d3aa88d1214f22cfe81ced88f10c187929904eecd60f2165b696727dd88
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Feb 9, 2020
@laanwj @PastaPastaPasta
Merge bitcoin#11621: [build] Add temp_bitcoin_locale_qrc to CLEAN_QT …
b84b36f 
…to fix make distcheck

a7c949f [build] Add temp_bitcoin_locale_qrc to CLEAN_QT to fix make distcheck (fanquake)

Pull request description:

  Fixes bitcoin#11302

  Tested on OS X 10.12.6 with 0e70791

  Was failing like:
  ```
  make distclean
  ....
  rm -f config.status config.cache config.log configure.lineno config.status.lineno
  rm -f Makefile
  ERROR: files left in build directory after distclean:
  ./src/qt/temp_bitcoin_locale.qrc
  make[1]: *** [distcleancheck] Error 1
  make: *** [distcheck] Error 1
  ```

Tree-SHA512: 291c786f20a82e648fdee2bcbc654d93d9abeb7d996ae7706d304697d4952709a0ec5d3aa88d1214f22cfe81ced88f10c187929904eecd60f2165b696727dd88
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@theuni theuni theuni approved these changes

Assignees
No one assigned
Labels
Build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues in 'make distcheck'
4 participants
@fanquake @promag @theuni @laanwj