rpc: update cli for estimate*fee argument rename #11267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Is this for 0.15.0? |
laanwj
changed the title
Member
Author
|
0.15.1 i'd say - it's not critical enough to hold up the release for, we could add an errata or such to the release notes I'll also add a commit to fix the argument name for |
Contributor
|
utACK b0a404b Thanks and sorry. Note the mining.cpp change already exists in the 0.15 branch. |
laanwj
changed the title
Contributor
|
tested ACK now... not sure about the travis failure , perhaps unrelated? |
Contributor
laanwj
force-pushed
the
2017_09_renamed_estimatefee_arg
branch
from
b0a404b to
5acd82d
Compare
Member
|
utACK 5acd82d |
Contributor
|
utACK 5acd82d |
Member
|
Nit: Mention "estimaterawfee" in the body of the first commit. utACK 5acd82d |
maflcko
pushed a commit
that referenced
this pull request
Sep 12, 2017
5acd82d rpc: make estimatesmartfee argument naming consistent with documentation (Wladimir J. van der Laan) 24697c4 rpc: update cli for estimatefee argument rename (Wladimir J. van der Laan) Pull request description: The first argument of `estimaterawfee` was renamed from `nblocks` to `conf_target` in 06bcdb8. Update the client-side table as well. This makes #10753 pass again. Tree-SHA512: 107c0072a45e0f4e083dc803d534973e6bd4c005e62337a867815d7c98ab1c21d97b7a495c32763883975cbbb001b80003001a6709b7d9bdd81ce4d441b667be
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Oct 3, 2017
The first argument of estimatesmartfee was renamed from nblocks to conf_target in 06bcdb8. Update the client-side table as well. Github-Pull: bitcoin#11267 Rebased-From: 24697c4
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Oct 3, 2017
Github-Pull: bitcoin#11267 Rebased-From: 5acd82d
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Sep 25, 2019
5acd82d rpc: make estimatesmartfee argument naming consistent with documentation (Wladimir J. van der Laan) 24697c4 rpc: update cli for estimatefee argument rename (Wladimir J. van der Laan) Pull request description: The first argument of `estimaterawfee` was renamed from `nblocks` to `conf_target` in 06bcdb8. Update the client-side table as well. This makes bitcoin#10753 pass again. Tree-SHA512: 107c0072a45e0f4e083dc803d534973e6bd4c005e62337a867815d7c98ab1c21d97b7a495c32763883975cbbb001b80003001a6709b7d9bdd81ce4d441b667be
barrystyle
pushed a commit
to PACGlobalOfficial/PAC
that referenced
this pull request
Jan 22, 2020
5acd82d rpc: make estimatesmartfee argument naming consistent with documentation (Wladimir J. van der Laan) 24697c4 rpc: update cli for estimatefee argument rename (Wladimir J. van der Laan) Pull request description: The first argument of `estimaterawfee` was renamed from `nblocks` to `conf_target` in 06bcdb8. Update the client-side table as well. This makes bitcoin#10753 pass again. Tree-SHA512: 107c0072a45e0f4e083dc803d534973e6bd4c005e62337a867815d7c98ab1c21d97b7a495c32763883975cbbb001b80003001a6709b7d9bdd81ce4d441b667be
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first argument of
estimaterawfeewas renamed fromnblockstoconf_targetin 06bcdb8. Update the client-side table as well.This makes #10753 pass again.