BIP143 clarifying semantics of ACP|SINGLE #372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACK for me except a nit that might be a english mistake on my part:
I would say
|
|
@NicolasDorier fixed. Thanks |
| @@ -1,4 +1,4 @@ | |||
| <pre> | |||
| <pre> | |||
There was a problem hiding this comment.
@luke-jr I think there was a hidden character but this PR removes it. Isn't it?
There was a problem hiding this comment.
There was a problem hiding this comment.
@MarcoFalke I think there was a BOM before, not now
| All components in the original algorithm, including the behavior <code>OP_CODESEPERATOR</code>, remains unchanged. The only difference is the way of serialization and the inclusion of amount being spent. | ||
| Semantics of the original sighash types remain unchanged, except the followings: | ||
| # The way of serialization is changed; | ||
| # All sighash types commit the amount being spent by the signed input; |
There was a problem hiding this comment.
revised and squashed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR clarifies the semantics change when ANYONECANPAY is used with SINGLE, with other minor clarifications