Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIP 321: URI Scheme (Replace BIP 21 with a new BIP containing information about more modern usage of it) #1555

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
+203 −0
Open

BIP 321: URI Scheme (Replace BIP 21 with a new BIP containing information about more modern usage of it) #1555

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8a93e77
Copy BIP 21 into a new BIP XXXX with only the header changed
TheBlueMatt Jul 13, 2024
ab95193
Update to include newer address types
dplusplus1024 Dec 19, 2022
ff71934
Update BIP XXXX with information about more modern usage of it
TheBlueMatt Jul 13, 2024
836ef06
f add examples of silent payment addresses
TheBlueMatt Jul 13, 2024
fff9ae9
Drop some stale stuff/respond to some of Murch's comments
TheBlueMatt Oct 8, 2024
62e166e
Add PoP callbacks
TheBlueMatt Oct 8, 2024
fe591e5
Further comments from mark
TheBlueMatt Oct 9, 2024
7fba7a4
Drop broken reference
TheBlueMatt Oct 9, 2024
6be4d54
mention lightning PoP for BOLT 11
TheBlueMatt Oct 17, 2024
37404d4
drop the stupid extra &pop in the response callback
TheBlueMatt Oct 17, 2024
3527ddd
One more attempt at PoP spec, this time with examples
TheBlueMatt Oct 18, 2024
869b99a
if i had a quarter for every time a second-language english speaker c…
TheBlueMatt Oct 18, 2024
d7c021a
Link BIP 352 and add BIP 351 to list of keys
TheBlueMatt Oct 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Link BIP 352 and add BIP 351 to list of keys
  • Loading branch information
@TheBlueMatt
TheBlueMatt committed Oct 19, 2024
commit d7c021a10278391580de33f847d443d5fcc1be53
3 changes: 2 additions & 1 deletion bip-XXXX.mediawiki
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,8 @@ The following keys are currently defined for payment instructions of various for

*lightning: Lightning BOLT 11 invoices
*lno: Lightning BOLT12 offers
*sp: Silent Payment addresses
*pay: [[bip-0351.mediawiki|BIP 351 Private Payment addresses]]
*sp: [[bip-0352.mediawiki|BIP 352 Silent Payment addresses]]

New payment instructions using bech32 or bech32m encodings SHOULD reuse their address format's Human Readable Part as the parameter key.
TheBlueMatt marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the discussion on this PR, some reviewers were suggesting using bc1q and bc1p as parameter keys for native segwit payment instructions. In case that was meant to be proposed here, I wanted to point out that the human-readable part for all native segwit versions is bc.

If you meant to propose that bc1q, bc1p, bc1z, to be used, this could be described as:

Suggested change
New payment instructions using bech32 or bech32m encodings SHOULD reuse their address format's Human Readable Part as the parameter key.
New payment instructions using bech32 or bech32m encodings SHOULD reuse their address format's _human-readable part (HRP)_ as the parameter key. As all native segwit outputs share the same HRP, Bech32m addresses for future native segwit output types SHOULD use the four-character prefix of the address as the parameter key, e.g. `bc1p`, `bc1z`, `bc1r`, etc.


Expand Down