Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SPV-1157) use broadcast status returned from ARC #880

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

chris-4chain
Copy link
Contributor

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

@chris-4chain chris-4chain requested a review from a team as a code owner January 29, 2025 14:51
Copy link

Manual Tests

ℹ️ Remember to ask team members to perform manual tests and to assign tested label after testing.

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 85.52632% with 11 lines in your changes missing coverage. Please review.

Project coverage is 52.86%. Comparing base (3893827) to head (63a023e).

Files with missing lines Patch % Lines
engine/v2/database/repository/operations.go 87.50% 2 Missing and 1 partial ⚠️
engine/v2/operations/operations_service.go 62.50% 2 Missing and 1 partial ⚠️
engine/v2/transaction/record/tx_flow.go 66.66% 1 Missing and 2 partials ⚠️
engine/client.go 33.33% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #880      +/-   ##
==========================================
+ Coverage   52.71%   52.86%   +0.15%     
==========================================
  Files         382      384       +2     
  Lines       17029    17084      +55     
==========================================
+ Hits         8976     9031      +55     
+ Misses       7332     7329       -3     
- Partials      721      724       +3     
Flag Coverage Δ
unittests 52.86% <85.52%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...tions/v2/operations/internal/mapping/operations.go 100.00% <100.00%> (ø)
actions/v2/operations/search.go 36.84% <100.00%> (+2.46%) ⬆️
engine/client_internal.go 69.19% <100.00%> (+0.59%) ⬆️
engine/v2/database/dbquery/paginate.go 69.09% <100.00%> (ø)
engine/v2/database/dbquery/scopes.go 100.00% <100.00%> (ø)
engine/client.go 55.48% <33.33%> (-0.44%) ⬇️
engine/v2/database/repository/operations.go 93.87% <87.50%> (-2.18%) ⬇️
engine/v2/operations/operations_service.go 62.50% <62.50%> (ø)
engine/v2/transaction/record/tx_flow.go 72.64% <66.66%> (-0.83%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3893827...63a023e. Read the comment docs.

# Conflicts:
#	engine/client.go
#	engine/client_internal.go
#	engine/interface.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants