Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SPV-847): add option to wrap defined errors with cause #654

Merged
merged 4 commits into from
Aug 5, 2024

Conversation

pawellewandowski98
Copy link
Contributor

Pull Request Checklist

  • πŸ“– I created my PR using provided : CODE_STANDARDS
  • πŸ“– I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • βœ… I have provided tests for my changes.
  • πŸ“ I have used conventional commits.
  • πŸ“— I have updated any related documentation.
  • πŸ’Ύ PR was issued based on the Github or Jira issue.

@pawellewandowski98 pawellewandowski98 self-assigned this Jul 31, 2024
@pawellewandowski98 pawellewandowski98 requested a review from a team as a code owner July 31, 2024 09:04
Copy link

github-actions bot commented Jul 31, 2024

Manual Tests

πŸ’š Manual testing by @dorzepowski resulted in success.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 49.28%. Comparing base (c19bd23) to head (85d4db0).

Files Patch % Lines
models/errors.go 0.00% 15 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #654      +/-   ##
==========================================
- Coverage   49.34%   49.28%   -0.07%     
==========================================
  Files         257      257              
  Lines       11765    11780      +15     
==========================================
  Hits         5806     5806              
- Misses       5368     5383      +15     
  Partials      591      591              
Flag Coverage Ξ”
unittests 49.28% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Ξ”
models/errors.go 0.00% <0.00%> (ΓΈ)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update c19bd23...85d4db0. Read the comment docs.

@dorzepowski dorzepowski added the tested PR was tested by a team member label Aug 5, 2024
@dorzepowski dorzepowski added tested PR was tested by a team member and removed tested PR was tested by a team member labels Aug 5, 2024
@pawellewandowski98 pawellewandowski98 merged commit 4984587 into main Aug 5, 2024
13 of 14 checks passed
@pawellewandowski98 pawellewandowski98 deleted the feat-wrap-errors branch August 5, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants