New "Spending Bitcoins" page (plus few other minor tweaks, wording fixes, etc.) #1584
Conversation
…mment about "speed-up instructions; plus make comment a link to relevant part of the documentation.
…ll links to UseBitcoins.info (except for the one on the Resources page, which expressly points to that site) with links to this new page.
… page to read "Find merchants and products".
…ple?" up-to-date given current realities (market-cap, sites that take BTC); plus minor wording tweaks.
_translations/en.yml
Outdated
| products-online: "Find products for sale online" | ||
| products-online-text: "One common use for Bitcoin is making purchases online. There are hundreds of online shops and retailers that accept Bitcoin. Using a <a href=\"https://spendabit.co/\">search-engine like Spendabit</a> you can search through millions of products, all available for purchase with bitcoins." | ||
| directory: "Navigate a business directory" | ||
| directory-text: "You can also find many businesses <a href=\"/en/spend-bitcoin\">listed in online directories</a>. (<strong>Note:</strong> Unfortunately this directory has not been well-maintained and presently includes <em>many broken links</em> and references to defunct businesses.)" |
There was a problem hiding this comment.
Usebitcoins.info/spendbitcoins.com instead of /en/spend-bitcoin
There was a problem hiding this comment.
Good catch. Pushed a fix. :-)
|
Page looks good. Here is a screenshot: Has anyone checked spendbitcoins.com if they are more up-to-date than usebitcoin? We could use them instead. Nit: Doesn't the spend-bitcoin.html belong into the _templates folder? |
|
@microbit Regarding the I Regarding SpendBitcoins.com, I've not taken a close look at that site lately. (My hunch is it's little or no better -- I've never seen one of these directories be properly maintained.) I can poke around there, however, if you think it's worth a shot. (FWIW, we [Spendabit] are planning to begin building a standard directory -- a la UseBitcoins.info/SpendBitcoins.com -- and maintain it, but that won't really help us here today; maybe 6 months down the road it will be an option.) |
|
@JustAHappyKid Thanks a bunch for working on this. Could you generate a live preview of your work if you don't mind? If you don't know how, please let me know and I'll set one up. |
|
@JustAHappyKid I have the same problem that jekyll doesn't want to generate the |
|
Get feeds that have access to bitcoin wallet. |
…tcoin page, so it points to UseBitcoins.info (and not the Spending Bitcoin page itself).
|
@wbnns Okay, here we go: https://justahappykid.github.io/en/spend-bitcoin |
|
@JustAHappyKid Ok, thanks! I'll review and will post comments later this week. There are a few issues, for example with the translation strings along with some other things. Good job setting up the preview! |
There was a problem hiding this comment.
@JustAHappyKid Great work on this. I just reviewed the PR and requested some changes. Also, we need to not make changes in any of the yml files that aren't en.yml because of the way translations work (they need to be updated first on Transifex, otherwise, your changes will get overwritten when translation strings get updated).
For now, you can just stick with the change to en.yml (and omit the ones to the other languages). Updating en.yml will ensure it gets up to Transifex so the other yml files get updated downstream.
If you have any questions about anything or if you need any help, please let me know - thanks again!
_translations/en.yml
Outdated
| pagetitle: "Spending Bitcoin" | ||
| summary: "There are thousands of businesses, across the globe, that accept Bitcoin." | ||
| products-online: "Find products for sale online" | ||
| products-online-text: "One common use for Bitcoin is making purchases online. There are hundreds of online shops and retailers that accept Bitcoin. Using a <a href=\"https://spendabit.co/\">search-engine like Spendabit</a> you can search through millions of products, all available for purchase with bitcoins." |
There was a problem hiding this comment.
Please remove the hyphen from "search-engine" and make it two distinct words.
There was a problem hiding this comment.
Also, please make the anchor text for the hyperlink just "Spendabit" instead of "search engine like Spendabit".
_translations/en.yml
Outdated
| summary: "There are thousands of businesses, across the globe, that accept Bitcoin." | ||
| products-online: "Find products for sale online" | ||
| products-online-text: "One common use for Bitcoin is making purchases online. There are hundreds of online shops and retailers that accept Bitcoin. Using a <a href=\"https://spendabit.co/\">search-engine like Spendabit</a> you can search through millions of products, all available for purchase with bitcoins." | ||
| directory: "Navigate a business directory" |
There was a problem hiding this comment.
I think the word "to" may be missing from this (Navigate to a business directory).
There was a problem hiding this comment.
I meant it to be more like "navigate through" (a la "navigate the ocean"). How about "Peruse a business directory"? Or I can just add the "to" -- either way.
There was a problem hiding this comment.
@JustAHappyKid Ah, ok, nevermind, I see. :) Feel free to leave as-is.
_translations/en.yml
Outdated
| products-online: "Find products for sale online" | ||
| products-online-text: "One common use for Bitcoin is making purchases online. There are hundreds of online shops and retailers that accept Bitcoin. Using a <a href=\"https://spendabit.co/\">search-engine like Spendabit</a> you can search through millions of products, all available for purchase with bitcoins." | ||
| directory: "Navigate a business directory" | ||
| directory-text: "You can also find many businesses <a href=\"http://usebitcoins.info/\">listed in online directories</a>. (<strong>Note:</strong> Unfortunately this directory has not been well-maintained and presently includes <em>many broken links</em> and references to defunct businesses.)" |
There was a problem hiding this comment.
Please change the anchor text to just "online directories". Also, I'm not sure about the disclaimer, this sounds a bit negative and makes me wonder as a site visitor why we're linking to it in the first place (I realize though that there are issues with the directory, just thinking about if there's a better way we can word it).
There was a problem hiding this comment.
Indeed. On the one hand it looks bad on Bitcoin.org's part to link to a site that's so poorly maintained; on the other hand we kinda need something there. Maybe if we just tone down the warning? E.g., "(Unfortunately this directory includes a number of links to defunct businesses and old websites, at present.)"
_translations/en.yml
Outdated
| directory: "Navigate a business directory" | ||
| directory-text: "You can also find many businesses <a href=\"http://usebitcoins.info/\">listed in online directories</a>. (<strong>Note:</strong> Unfortunately this directory has not been well-maintained and presently includes <em>many broken links</em> and references to defunct businesses.)" | ||
| business-map: "Find local businesses" | ||
| business-map-text: "There are also many local businesses, like cafes and restaurants, that accept Bitcoin. You can <a href=\"https://coinmap.org/\">use Coinmap.org</a> to browse thousands of businesses across the globe." |
There was a problem hiding this comment.
Please change the anchor text to just "Coinmap.org" (instead of "use Coinmap.org").
en/spend-bitcoin.html
Outdated
| @@ -0,0 +1,20 @@ | |||
| --- | |||
There was a problem hiding this comment.
This file should be set up and placed in the _templates instead of /en/.
There was a problem hiding this comment.
This is the only request I'm not exactly sure how to handle... As I mentioned in a comment above, I was not able to get Jekyll to respond to files (to compile, generate, etc.) I placed under _templates -- which was where I initially attempted to place the new page. @microbit seemed to have the same issue. Any thoughts/hints?
There was a problem hiding this comment.
@JustAHappyKid At first glance it looks like you didn't add the url at the bottom of en.yml.
_translations/en.yml
Outdated
| @@ -350,7 +350,7 @@ | |||
| howitworkstxt1: "From a user perspective, Bitcoin is nothing more than a mobile app or computer program that provides a personal Bitcoin wallet and allows a user to send and receive bitcoins with them. This is how Bitcoin works for most users." | |||
| howitworkstxt2: "Behind the scenes, the Bitcoin network is sharing a public ledger called the \"block chain\". This ledger contains every transaction ever processed, allowing a user's computer to verify the validity of each transaction. The authenticity of each transaction is protected by digital signatures corresponding to the sending addresses, allowing all users to have full control over sending bitcoins from their own Bitcoin addresses. In addition, anyone can process transactions using the computing power of specialized hardware and earn a reward in bitcoins for this service. This is often called \"mining\". To learn more about Bitcoin, you can consult the <a href=\"#how-it-works#\">dedicated page</a> and the <a href=\"#bitcoin-paper#\">original paper</a>." | |||
| used: "Is Bitcoin really used by people?" | |||
| usedtxt1: "Yes. There is a <a href=\"http://usebitcoins.info/\">growing number of businesses</a> and individuals using Bitcoin. This includes brick and mortar businesses like restaurants, apartments, law firms, and popular online services such as Namecheap, WordPress, and Reddit. While Bitcoin remains a relatively new phenomenon, it is growing fast. At the end of August 2013, the <a href=\"https://bitcoincharts.com/bitcoin/\">value of all bitcoins in circulation</a> exceeded US$ 1.5 billion with millions of dollars worth of bitcoins exchanged daily." | |||
| usedtxt1: "Yes. There is a <a href=\"/en/spend-bitcoin\">growing number of businesses</a> and individuals using Bitcoin. This includes brick-and-mortar businesses like restaurants, apartments, and law firms, as well as popular online services such as Namecheap, Overstock.com, and Reddit. While Bitcoin remains a relatively new phenomenon, it is growing fast. At the end of April 2017, the <a href=\"https://bitcoincharts.com/bitcoin/\">total value of all existing bitcoins</a> exceeded 20-billion US dollars, with millions of dollars worth of bitcoins exchanged daily." | |||
There was a problem hiding this comment.
Please change "Yes, There is a" to "Yes, There are a" (I know it was already like that)
Also, please change "20-billion" to "20 billion" (no hyphen)
There was a problem hiding this comment.
Wasn't sure whether the verb (is/are) should be acting on "number" (singular) or "businesses" (plural), so just left it as it was previously... But I concur, "There are" reads easier. :-)
|
Okay, sounds like I just need to revert all changes under |
en/spend-bitcoin.html
Outdated
| # http://opensource.org/licenses/MIT. | ||
|
|
||
| layout: base | ||
| lang: en |
There was a problem hiding this comment.
@JustAHappyKid Please remove line 6: lang: en
…n files that relate to new "Spend Bitcoin" page.
…ving hyphen), and for link to Spendabit.co only hyperlink the site name ("Spendabit") as opposed to the whole phrase "search engine like Spendabit".
… page) to just wrap text "online directories".
…unct businesses/websites at UseBitcoins.info (on new Spend page).
… to only wrap text "Coinmap.org" (not "use Coinmap.org").
…'spend-bitcoin' to 'url' section of en.yml.
|
@wbnns Okay, I've moved |
|
LGTM
|
There was a problem hiding this comment.
@JustAHappyKid Thanks for making the additional changes. We're almost there and everything you've done looks great. After further review of the Use Bitcoins website, let's go ahead and remove that section. I think sending people to that site may do more harm than good in its current condition.
_translations/en.yml
Outdated
| products-online: "Find products for sale online" | ||
| products-online-text: "One common use for Bitcoin is making purchases online. There are hundreds of online shops and retailers that accept Bitcoin. Using a search engine like <a href=\"https://spendabit.co/\">Spendabit</a> you can search through millions of products, all available for purchase with bitcoins." | ||
| directory: "Navigate a business directory" | ||
| directory-text: "You can also find many businesses listed in <a href=\"http://usebitcoins.info/\">online directories</a>. (Note: Unfortunately this directory includes a number of defunct businesses and websites.)" |
There was a problem hiding this comment.
After additional review, let's just remove the "Navigate a business directory" section. The usebitcoins.info site is heavily ad-laden (several are somewhat scammy looking) and as several others have mentioned, there are a significant number of broken links.
There was a problem hiding this comment.
Maybe we can replace it with the 99 bitcoin List :https://99bitcoins.com/who-accepts-bitcoins-payment-companies-stores-take-bitcoins/
It is not a directory but a List with the mayor merchants.
There was a problem hiding this comment.
@Mirobit Thanks for the suggestion. We could alternatively do this, too. 👍
@JustAHappyKid It's your call!
| <h2 id="products-online"><span class="fa fa-shopping-cart fa-lg"></span> {% translate products-online %}</h2> | ||
| <p>{% translate products-online-text %}</p> | ||
|
|
||
| <h2 id="directory"><span class="fa fa-book fa-lg"></span> {% translate directory %}</h2> |
There was a problem hiding this comment.
As per my other comment, let's remove this section, along with the strings in the other file.
…ns.com page (that includes links to many BTC-accepting merchants), and remove disclaimer (that was aimed at UseBitcoins.info) about directory containing defunct businesses.
|
@JustAHappyKid Awesome, this looks great. Unless others object, this will be merged on Sunday, June 25th. |
As per issue #1560.