Combine /index, /<lang>/index, and /404 #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harding
force-pushed
the
merge-index-pages
branch
from
3fbf95a to
d1f49ba
Compare
|
That's indeed better, thanks! |
|
@saivann thanks! In the absence of critical feedback, this will be merged around 16:00 UTC Saturday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on #972, I discovered Bitcoin.org has three pages with nearly identical content:
/<language>/index.htmlwhich provides the Bitcoin.org index page localized into each supported language/index.htmlwhich provides a fallback in case language redirection doesn't work. This page is currently identical to the English localized index page./404.htmlwhich provides the 404 error page, which includes a Javascript redirect to the localized index page plus fallback content that looks like an old version of the English localized index page.This PR now builds all three pages from the same source so that if we change any text, we only have to change it once. (No text changes are introduced in this PR, except that text displayed on the 404 page is now identical to the text displayed on the index pages.)
I tested this for English and Spanish.