(Trivial) Build: Put Current Git Commit ID On Site #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
|
@saivann thanks! In the absence of critical feedback (or a request for more time to review) this will be merged today around 20:00 UTC. |
harding
added a commit
that referenced
this pull request
Jul 6, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing an update to the build system, I needed this for easily tracking which of my automated local test builds were successful. However, I think it could also be useful for easily tracking what commit the site is on, so I'm submitting it as a separate PR. Here's what the command outputs on current HEAD:
I'd like to merge this later today; if anyone thinks this single line needs more review, please say so.
Once we upgrade to >= Jekyll 2.0, I think it might be worth trying https://github.com/ivantsepp/jekyll-git_metadata to add the current commit to templates, kind of like how Reddit has its current commit id and render date at the bottom right of every page.