Dev Docs: Describe P2P Messages That Request Or Reply With Data #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds to the devel reference page detailed documentation on the following messages: block, getblocks, getdata, getheaders, headers, inv, mempool, merkleblock, notfound, and tx. Adds to the devel examples page an example of requesting and parsing a merkleblock message. Adds to the devel docs overview pages links to the above two new P2P sections. Tweaks the autocrossref plugin ignore pattern to not crossref in the middle of a GIF image name; this allows the inclusion of animated GIFs.
|
|
||
| Many of the data messages use | ||
| [inventories][inventory]{:#term-inventory}{:.term} as unique identifiers for | ||
| for transactions and blocks. Inventories have a simple 36-byte |
There was a problem hiding this comment.
s/for for transactions/for transactions
|
@harding I've commented on everything that seemed worth reporting. Really amazing work!!! |
|
@saivann thank you so much for your review! (I know it was a giant pull request---thanks for taking the time.) All your comments look reasonable to me; I'll start implementing them and comment on any that I discover don't work. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
P2P Reference Preview: http://dg0.dtrt.org/en/developer-reference#p2p-network
P2P Examples Preview: http://dg0.dtrt.org/en/developer-examples#p2p-network
Adds to the devel reference page detailed documentation on the following messages: block, getblocks, getdata, getheaders, headers, inv, mempool, merkleblock, notfound, and tx.
Adds to the devel examples page an example of requesting and parsing a merkleblock message.
Adds to the devel docs overview pages links to the above two new P2P sections.
Tweaks the autocrossref plugin ignore pattern to not crossref in the middle of a GIF image name; this allows the inclusion of animated GIFs.
Note: I'm working on documenting the remaining P2P messages in a separate branch.