Display language menu in ordered columns #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@saivann - great change, LGTM. |
|
@saivann it is indeed a great change. LGTM too. |
ghost1542
pushed a commit
that referenced
this pull request
May 24, 2014
Display language menu in ordered columns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Live preview: (merged)
We are beginning to have too much languages for the current menu!
By using liquid {% cycle %} tag and pre-ordered language list in _config.yml, it is possible to display them in a "table-like" layout, which should be more scalable. The mobile menu shouldn't change.
I tested the new layout with IE6-10, as well as old and recent FF, OP, SA and chrome versions.