Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: mention separation of concerns from Bitcoin.org #1187

Merged
merged 1 commit into from
Jan 5, 2016

Conversation

harding
Copy link
Contributor

@harding harding commented Dec 29, 2015

This commit makes two changes. First it modifies the footer on the Bitcoin Core pages:

2015-12-29-012709_611x97_scrot

This drops the Press page and the Blog page and changes the About link to the page described below. Beneath the copyright statement, a short message tells readers that the Bitcoin Core pages are not a normal part of the site; the link here also points to the page described below.

The second change is a new page that describes the relationship between Bitcoin Core and Bitcoin.org in detail:

2015-12-29-012731_655x900_scrot

All the text in both changes is just draft text, so please feel free to make suggestions. In addition, I'm open to combing this with #1186 if a more visible disclaimer is desired for the main page. What I tried to aim for with this PR is a short and unobtrusive disclaimer on every Bitcoin Core page as well as a separate page where we could go into depth about the separation between the two projects.

Related to this PR, I also created a new tag for the site for Bitcoin Core issues to help people (like me) who want to focus on them: https://github.com/bitcoin-dot-org/bitcoin.org/labels/Core

@harding harding added the Core label Dec 29, 2015
@jonasschnelli
Copy link
Contributor

Concept ACK. Thanks @harding!

Nevertheless the separation is only virtual because the power/centralization is not really separated. The domain/site owners can always change the sources of the Core pages. But okay and somehow unavoidable IMO

@btcdrak
Copy link
Contributor

btcdrak commented Dec 29, 2015

ACK

@ghost1542
Copy link
Contributor

utACK, would be nice to have +1 from domain owners @theymos @Cobra-Bitcoin .

@harding harding changed the title [WIP] Core: mention separation of concerns from Bitcoin.org Core: mention separation of concerns from Bitcoin.org Dec 29, 2015
@CodeShark
Copy link
Contributor

ACK

@kanzure
Copy link
Contributor

kanzure commented Dec 29, 2015

ACK, this looks like a reasonable thing to mention on the site.

@instagibbs
Copy link
Contributor

concept ACK

@morcos
Copy link

morcos commented Dec 29, 2015

Yes I like this, but agree with @saivann that I'd like to know that the domain owners see it this way.

@eragmus
Copy link

eragmus commented Dec 29, 2015

Concept ACK.

@theymos
Copy link
Contributor

theymos commented Dec 30, 2015

ACK

@harding
Copy link
Contributor Author

harding commented Dec 30, 2015

Thanks everyone. Scheduling this for merge late tomorrow (Wednesday).

@luke-jr
Copy link
Contributor

luke-jr commented Dec 30, 2015

No offence intended, but I don't think that it's relevant whether or not the domain owners see it this way...

@ghost1542
Copy link
Contributor

@luke-jr Domain owners have been more active lately and doing more maintainer-level decision making, and technically speaking, they have control over the domain, which is the highest level of control someone can have over bitcoin.org . Thus, making sure they agree with that separation, especially given that it's only a symbolic one (basically just some general agreement), seems rather important to me.

@jrmithdobbs
Copy link

Agreed @saivann. I think merge should be postponed until the domain owners chime in.

@harding
Copy link
Contributor Author

harding commented Dec 30, 2015

@jrmithdobbs: One of the owners ACK'd here, which is why I scheduled the merge.

@jrmithdobbs
Copy link

Missed him chiming in. My bad.

@laanwj
Copy link
Contributor

laanwj commented Jan 4, 2016

ACK, sounds good to me

@harding harding merged commit 9f94bce into bitcoin-dot-org:master Jan 5, 2016
harding added a commit that referenced this pull request Jan 5, 2016
- 1187: Core: mention separation of concerns from Bitcoin.org
- 1188: Updated requirements in full-node.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.